Jason Wheeler
000a047c80
functional but needs styles completed
2022-12-09 15:49:36 -05:00
Jason Wheeler
ce3348ffe7
Merge pull request #68 from Safelite/feature/Digital/SSR-159
...
Feature/digital/ssr 159
2022-12-08 15:47:09 -05:00
Jason Wheeler
b6802f9954
Merge branch 'develop' into feature/Digital/SSR-159
2022-12-08 15:41:24 -05:00
Jason Wheeler
a15b7fb0de
fixed some tests
2022-12-08 15:40:50 -05:00
Johan Gunawan
69d96e3e2d
Merge pull request #69 from Safelite/enhancement/add-eslint
...
Add eslint and the configuration needed to lint javascript and vue files.
Please note that these commits do not enforce the rules unless eslint command is executed manually. So these rules are not going to interfere with our current process until we have a discussion what style we should be using and started to enforce it in our process.
It is still a good start to have these settings so if anyone want to lint their code they can by running the command below.
npx eslint [specific file if neeeded]
2022-12-08 14:18:52 -05:00
Johan Gunawan
be2787ee2e
Add eslint
...
Add eslint and the configuration needed to lint javascript and vue files.
2022-12-08 11:37:15 -05:00
Jason Wheeler
619a7619d2
Merge branch 'develop' into feature/Digital/SSR-159
2022-12-07 16:38:47 -05:00
Jason Wheeler
6a7d41f164
vehicle-style page will skip to damage if only one style and they haven't visited the damage page yet.
2022-12-07 16:38:03 -05:00
Johan Gunawan
147f6a27df
Merge pull request #67 from Safelite/general/Digital/match-icons-folders-structure
...
Moved the files in 'assets/icons' to 'assets/img/icons' to match the folder structure in DigitalConsumer.FixMyGlass.
2022-12-07 16:28:23 -05:00
Johan Gunawan
5a7db94bf0
Match folder structure for icons in DigitalConsumer.FixMyGlass
2022-12-07 15:02:29 -05:00
Johan Gunawan
ad524c0a1a
Merge pull request #66 from Safelite/feature/Digital/SSR-158
...
Changes for SSR-158
2022-12-06 16:41:11 -05:00
Johan Gunawan
fcd7aa7dec
SSR-158
...
Modify link text.
Add CCPA icon.
Modify components to match CF project.
2022-12-06 16:00:52 -05:00
Kulbhushan Kaushik
7aeb7a7a3b
Merge pull request #65 from Safelite/feature/SSR-131
...
commit
2022-12-06 10:34:25 -05:00
Kulbhushan Kaushik
34acc1c6ca
Merge branch 'develop' into feature/SSR-131
2022-12-06 10:19:40 -05:00
Kulbhushan Kaushik
503e594393
commit
2022-12-06 10:16:59 -05:00
Johan Gunawan
915dc8634e
Merge pull request #61 from Safelite/defect/Digital/SSR-153
...
SSR.-153. Resolve "Invalid prop" warning after a year is selected in "vehicle-year" page
2022-12-06 09:22:03 -05:00
Johan Gunawan
b60d892f2d
Merge pull request #62 from Safelite/defect/Digital/SSR-154
...
SSR-154. Resolve "cmsWidgetName" warning from unit test.
2022-12-06 09:21:15 -05:00
Kulbhushan Kaushik
3f901a8191
Merge pull request #64 from Safelite/feature/SSR-131
...
Feature/ssr 131
2022-12-06 08:59:41 -05:00
Kulbhushan Kaushik
45e73d3087
vehicle-questions-mixin unit tests
2022-12-06 08:37:41 -05:00
Kulbhushan Kaushik
8c9bc221c7
Merge branch 'develop' into feature/SSR-131
2022-12-06 08:06:37 -05:00
Kulbhushan Kaushik
2b66300178
Merge pull request #63 from Safelite/defect/Digital/SSR-155
...
Resolve warning in unit test regarding Invalid prop type check failed for prop "answers"
2022-12-06 07:37:42 -05:00
Johan Gunawan
60d98f9938
Array needs to be initialized
2022-12-05 17:28:31 -05:00
Johan Gunawan
75b7833a80
Remove unnecessary computed
...
SiteSubHeader component already has a computed property for backButtonAccessibleText.
2022-12-05 17:13:34 -05:00
Johan Gunawan
8a1933d76f
Change String to Number
...
The actual implementation in the component is using number instead of a string. The tests should match that.
2022-12-05 16:10:45 -05:00
Johan Gunawan
81a35dd0bb
Fix console warning in DevTools
2022-12-05 16:08:35 -05:00
Kulbhushan Kaushik
922e3395a2
Merge pull request #60 from Safelite/feature/SSR-131
...
Feature/ssr 131
2022-12-05 14:55:27 -05:00
Kulbhushan Kaushik
b770d9c078
commit
2022-12-05 14:51:22 -05:00
Kulbhushan Kaushik
3efb2f6e15
COMMIT
2022-12-05 10:35:25 -05:00
Kulbhushan Kaushik
17a736b542
Merge branch 'develop' into feature/SSR-131
2022-12-05 08:54:42 -05:00
Kulbhushan Kaushik
5fb48ea1ee
commit
2022-12-05 08:54:32 -05:00
Johan Gunawan
9a691aecb3
Merge pull request #58 from Safelite/defect/Digital/SSR-142
...
Fix “Invalid prop: type check failed for prop "answers" warning in "vehicle-year" page
2022-12-01 15:26:34 -05:00
Johan Gunawan
8281a7faf9
Fix “Invalid prop: type check failed for prop "answers" warnings displayed in the DevTools Console when opening the “vehicle-year” page locally.
...
Initial value for "years" should be assigned to an empty array. "Array" is a function and need to be called with "new Array()" to get an empty array. I opted for a shorter syntax but the idea is the same.
2022-12-01 15:12:09 -05:00
Kulbhushan Kaushik
a2eb94015e
commit
2022-12-01 14:59:13 -05:00
Johan Gunawan
b024112cac
Merge pull request #57 from Safelite/defect/Digital/SSR-138
...
Fix Invalid prop warning for modelValue in base-input-button component
2022-12-01 13:33:22 -05:00
Johan Gunawan
5e89a14b63
Fix Invalid prop warning for modelValue in base-input-button component
2022-12-01 12:26:44 -05:00
Jason Wheeler
d572e03827
Merge pull request #56 from Safelite/feature/Digital/SSR-136
...
Feature/digital/ssr 136
2022-11-30 13:58:43 -05:00
Jason Wheeler
c69b4a6d32
Merge branch 'develop' into feature/Digital/SSR-136
2022-11-30 13:50:36 -05:00
Jason Wheeler
566d9be53f
updated style to prevent wrapping
2022-11-30 13:48:13 -05:00
Kulbhushan Kaushik
f3d1833acd
Merge pull request #55 from Safelite/feature/SSR-129
...
Feature/ssr 129
2022-11-30 13:38:10 -05:00
Kulbhushan Kaushik
5d56f6ed7a
Merge branch 'develop' into feature/SSR-129
2022-11-30 13:13:35 -05:00
Kulbhushan Kaushik
6fa032871e
Merge pull request #54 from Safelite/feature/Digital/SSR-122
...
Feature/digital/ssr 122
2022-11-30 07:52:55 -05:00
Kulbhushan Kaushik
240e450f74
commit
2022-11-29 13:53:39 -05:00
Kulbhushan Kaushik
ef9c7af480
commit
2022-11-29 10:34:13 -05:00
Kulbhushan Kaushik
5eb4c2f9ee
commit
2022-11-29 09:58:31 -05:00
Jeremy Zimmerman
9dfd667a4f
Merge branch 'develop' into feature/Digital/SSR-122
2022-11-28 16:07:24 -05:00
Kulbhushan Kaushik
8a04f2e2ae
Merge branch 'develop' into feature/SSR-129
2022-11-28 13:00:16 -05:00
Kulbhushan Kaushik
3e8b70372d
Merge pull request #53 from Safelite/feature/Digital/SSR-130
...
Feature/digital/ssr 130
2022-11-28 13:00:03 -05:00
Jason Wheeler
21a4db6a30
completed tests
2022-11-28 12:47:15 -05:00
Jason Wheeler
cff016c30f
Merge branch 'develop' into feature/Digital/SSR-130
2022-11-28 09:36:14 -05:00
Kulbhushan Kaushik
97c4ac0a06
commit
2022-11-28 09:06:04 -05:00
