jason/DigitalConsumer.ISS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Surprise they're strings

Browse source
This commit is contained in:
Bill Richardson 2026-07-13 14:40:05 -04:00
parent f87408bac2
commit c1cf5d1f02
7 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/layouts/address-lookup/address-lookup.spec.js
View file

@ -74,10 +74,10 @@ function setupMocks({
mixins: { mixins: {
getSettingValue: jest.fn((settingName) => { getSettingValue: jest.fn((settingName) => {
if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) {
return true; return 'true';
} }
return false; return 'false';
}) })
} }
}) })
@ -433,10 +433,10 @@ describe('address-lookup.vue', () => {
wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn(); wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn();
wrapper.vm.getSettingValue = jest.fn((settingName) => { wrapper.vm.getSettingValue = jest.fn((settingName) => {
if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) {
return true; return 'true';
} }
return false; return 'false';
}); });
useMainStore().order.vehicle.carId = 'C0000'; useMainStore().order.vehicle.carId = 'C0000';
@ -475,10 +475,10 @@ describe('address-lookup.vue', () => {
wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn(); wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn();
wrapper.vm.getSettingValue = jest.fn((settingName) => { wrapper.vm.getSettingValue = jest.fn((settingName) => {
if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) {
return true; return 'true';
} }
return false; return 'false';
}); });
useMainStore().order.vehicle.carId = 'CARID3'; useMainStore().order.vehicle.carId = 'CARID3';

2
src/layouts/address-lookup/address-lookup.vue
View file

@ -345,7 +345,7 @@ export default {
{ [routerParams.DISPLAY_VEHICLE_CHANGE_ALERT]: true } { [routerParams.DISPLAY_VEHICLE_CHANGE_ALERT]: true }
); );
} else if (matchingCars.length === 1) { } else if (matchingCars.length === 1) {
const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true';
if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) {
this.mainStore.setBailout(bailoutMessage.YMMNotFound()); this.mainStore.setBailout(bailoutMessage.YMMNotFound());
return this.$router.navigate( return this.$router.navigate(

4
src/layouts/address-vehicles/address-vehicles.spec.js
View file

@ -108,10 +108,10 @@ function setupMocks({
}), }),
getSettingValue: jest.fn((settingName) => { getSettingValue: jest.fn((settingName) => {
if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) {
return true; return 'true';
} }
return false; return 'false';
}), }),
}, },
computed: { computed: {

2
src/layouts/address-vehicles/address-vehicles.vue
View file

@ -257,7 +257,7 @@ export default {
false false
); );
const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true';
if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) {
this.mainStore.setBailout(bailoutMessage.YMMNotFound()); this.mainStore.setBailout(bailoutMessage.YMMNotFound());
return this.$router.navigate( return this.$router.navigate(

2
src/layouts/license-plate-lookup/license-plate-lookup.vue
View file

@ -305,7 +305,7 @@ export default {
} }
}); });
const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true';
if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) {
this.mainStore.setBailout(bailoutMessage.YMMNotFound()); this.mainStore.setBailout(bailoutMessage.YMMNotFound());
return this.$router.navigate( return this.$router.navigate(

4
src/layouts/vin-lookup/vin-lookup.spec.js
View file

@ -176,10 +176,10 @@ const mountOptions = {
pushEventToGA: jest.fn(), pushEventToGA: jest.fn(),
getSettingValue: jest.fn((settingName) => { getSettingValue: jest.fn((settingName) => {
if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) {
return true; return 'true';
} }
return false; return 'false';
}) })
}, },
computed: { computed: {

2
src/layouts/vin-lookup/vin-lookup.vue
View file

@ -177,7 +177,7 @@ export default {
this.$refs.siteFooter.enableForwardAction(); this.$refs.siteFooter.enableForwardAction();
showIssLoadingModal(true); showIssLoadingModal(true);
const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true';
if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) {
this.mainStore.setBailout(bailoutMessage.YMMNotFound()); this.mainStore.setBailout(bailoutMessage.YMMNotFound());
return this.$router.navigate( return this.$router.navigate(