From c1cf5d1f026bfe0e37093c23dd2cad1b75213fdd Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Mon, 13 Jul 2026 14:40:05 -0400 Subject: [PATCH] Surprise they're strings --- src/layouts/address-lookup/address-lookup.spec.js | 12 ++++++------ src/layouts/address-lookup/address-lookup.vue | 2 +- .../address-vehicles/address-vehicles.spec.js | 4 ++-- src/layouts/address-vehicles/address-vehicles.vue | 2 +- .../license-plate-lookup/license-plate-lookup.vue | 2 +- src/layouts/vin-lookup/vin-lookup.spec.js | 4 ++-- src/layouts/vin-lookup/vin-lookup.vue | 2 +- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/layouts/address-lookup/address-lookup.spec.js b/src/layouts/address-lookup/address-lookup.spec.js index c284ff5c..aead77c4 100644 --- a/src/layouts/address-lookup/address-lookup.spec.js +++ b/src/layouts/address-lookup/address-lookup.spec.js @@ -74,10 +74,10 @@ function setupMocks({ mixins: { getSettingValue: jest.fn((settingName) => { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { - return true; + return 'true'; } - return false; + return 'false'; }) } }) @@ -433,10 +433,10 @@ describe('address-lookup.vue', () => { wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn(); wrapper.vm.getSettingValue = jest.fn((settingName) => { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { - return true; + return 'true'; } - return false; + return 'false'; }); useMainStore().order.vehicle.carId = 'C0000'; @@ -475,10 +475,10 @@ describe('address-lookup.vue', () => { wrapper.vm.navigateForwardWithSingleCarMatch = jest.fn(); wrapper.vm.getSettingValue = jest.fn((settingName) => { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { - return true; + return 'true'; } - return false; + return 'false'; }); useMainStore().order.vehicle.carId = 'CARID3'; diff --git a/src/layouts/address-lookup/address-lookup.vue b/src/layouts/address-lookup/address-lookup.vue index bc61bb89..35acc137 100644 --- a/src/layouts/address-lookup/address-lookup.vue +++ b/src/layouts/address-lookup/address-lookup.vue @@ -345,7 +345,7 @@ export default { { [routerParams.DISPLAY_VEHICLE_CHANGE_ALERT]: true } ); } else if (matchingCars.length === 1) { - const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); + const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true'; if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { this.mainStore.setBailout(bailoutMessage.YMMNotFound()); return this.$router.navigate( diff --git a/src/layouts/address-vehicles/address-vehicles.spec.js b/src/layouts/address-vehicles/address-vehicles.spec.js index 43256ef9..bb2c83f2 100644 --- a/src/layouts/address-vehicles/address-vehicles.spec.js +++ b/src/layouts/address-vehicles/address-vehicles.spec.js @@ -108,10 +108,10 @@ function setupMocks({ }), getSettingValue: jest.fn((settingName) => { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { - return true; + return 'true'; } - return false; + return 'false'; }), }, computed: { diff --git a/src/layouts/address-vehicles/address-vehicles.vue b/src/layouts/address-vehicles/address-vehicles.vue index 84bea124..b3ea74e8 100644 --- a/src/layouts/address-vehicles/address-vehicles.vue +++ b/src/layouts/address-vehicles/address-vehicles.vue @@ -257,7 +257,7 @@ export default { false ); - const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); + const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true'; if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { this.mainStore.setBailout(bailoutMessage.YMMNotFound()); return this.$router.navigate( diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index a86995c8..165e0084 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -305,7 +305,7 @@ export default { } }); - const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); + const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true'; if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { this.mainStore.setBailout(bailoutMessage.YMMNotFound()); return this.$router.navigate( diff --git a/src/layouts/vin-lookup/vin-lookup.spec.js b/src/layouts/vin-lookup/vin-lookup.spec.js index 4ab30d9e..b5e9efe6 100644 --- a/src/layouts/vin-lookup/vin-lookup.spec.js +++ b/src/layouts/vin-lookup/vin-lookup.spec.js @@ -176,10 +176,10 @@ const mountOptions = { pushEventToGA: jest.fn(), getSettingValue: jest.fn((settingName) => { if (settingName === experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) { - return true; + return 'true'; } - return false; + return 'false'; }) }, computed: { diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index ca20daf0..e7a91bc1 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -177,7 +177,7 @@ export default { this.$refs.siteFooter.enableForwardAction(); showIssLoadingModal(true); - const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED); + const ymmsBailoutEnabled = this.getSettingValue(experimentSettings.ISS_YMMS_VIN_REQUIRED_BAILOUT_ENABLED) === 'true'; if (ymmsBailoutEnabled && this.mainStore.order.vehicle.vinRequired) { this.mainStore.setBailout(bailoutMessage.YMMNotFound()); return this.$router.navigate(