jason/DigitalConsumer.ISS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1273 from Safelite/feature/jzimmerman/renamed_loadsession

Browse source 
Renamed loadSession method to loadSessionFromDuplicate to more accurately reflect its usage.
This commit is contained in:
Jeremy-Z 2026-06-25 12:25:17 -04:00 committed by GitHub
commit 304e6f2c01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 34 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/layouts/duplicate-check/duplicate-check.spec.js
View file

@ -297,13 +297,13 @@ describe('duplicateCheck.vue', () => {
}); });
wrapper.setData({ selectedAnswer }); wrapper.setData({ selectedAnswer });
useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.resolve({})); useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.resolve({}));
// Act // Act
await wrapper.vm.forwardButtonAction(); await wrapper.vm.forwardButtonAction();
// Assert // Assert
expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(1); expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(1);
expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1); expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1);
}); });
test('Selected new order => load session not called', async () => { test('Selected new order => load session not called', async () => {
@ -325,13 +325,13 @@ describe('duplicateCheck.vue', () => {
}); });
wrapper.setData({ selectedAnswer: newOrderSelectionName }); wrapper.setData({ selectedAnswer: newOrderSelectionName });
useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.resolve({})); useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.resolve({}));
// Act // Act
await wrapper.vm.forwardButtonAction(); await wrapper.vm.forwardButtonAction();
// Assert // Assert
expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(0); expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(0);
expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1); expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1);
}); });
test('Load session throws error => still navigate forward', async () => { test('Load session throws error => still navigate forward', async () => {
@ -354,7 +354,7 @@ describe('duplicateCheck.vue', () => {
wrapper.setData({ selectedAnswer }); wrapper.setData({ selectedAnswer });
const error = 'load session error'; const error = 'load session error';
useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.reject(error)); useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.reject(error));
// Act // Act
@ -365,7 +365,7 @@ describe('duplicateCheck.vue', () => {
} catch (e) { } catch (e) {
expect(e).toMatch(error); expect(e).toMatch(error);
} }
expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(1); expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(1);
}); });
test('coverageType deductible and policy vehicles returned => CLICKED_FORWARD_POLICY_VERIFIED_WITH_VEHICLES', async () => { test('coverageType deductible and policy vehicles returned => CLICKED_FORWARD_POLICY_VERIFIED_WITH_VEHICLES', async () => {
// Arrange // Arrange

2
src/layouts/duplicate-check/duplicate-check.vue
View file

@ -144,7 +144,7 @@ export default {
this.mainStore.applicationUser.duplicateOrders.find((o) => o.correlationId === this.selectedAnswer); this.mainStore.applicationUser.duplicateOrders.find((o) => o.correlationId === this.selectedAnswer);
if (selectedReferral) { if (selectedReferral) {
await this.mainStore.loadSession(selectedReferral); await this.mainStore.loadSessionFromDuplicate(selectedReferral);
} }
this.navigateForward(); this.navigateForward();

2
src/store/index.js
View file

@ -1617,7 +1617,7 @@ export const useMainStore = defineStore({
} }
}); });
}, },
async loadSession(duplicate) { async loadSessionFromDuplicate(duplicate) {
const { applicationUser, order } = this; const { applicationUser, order } = this;
// NOTE: We are re-using the current user's saved session id (this is required on the load-session call). // NOTE: We are re-using the current user's saved session id (this is required on the load-session call).
// This should be ok, but should probably validate. // This should be ok, but should probably validate.

52
src/store/store.spec.js
View file

@ -1140,7 +1140,7 @@ describe('Store', () => {
}); });
}); });
describe('loadSession method', () => { describe('loadSessionFromDuplicate method', () => {
describe('successful method call', () => { describe('successful method call', () => {
const applicationUser = { const applicationUser = {
experiments: getRandomString(6, 6) experiments: getRandomString(6, 6)
@ -1192,7 +1192,7 @@ describe('Store', () => {
}; };
// Act // Act
store.loadSession(duplicate); store.loadSessionFromDuplicate(duplicate);
// Asserts // Asserts
expect(globalMethods.callHttpClient).toHaveBeenCalledWith(expect.objectContaining({ expect(globalMethods.callHttpClient).toHaveBeenCalledWith(expect.objectContaining({
@ -1219,14 +1219,14 @@ describe('Store', () => {
store.policy.vehicles = [{ vehicle }]; store.policy.vehicles = [{ vehicle }];
// Act // Act
await store.loadSession(duplicate); await store.loadSessionFromDuplicate(duplicate);
// Asserts // Asserts
expect(store.vehicle.year).toBe(vehicle.year); expect(store.vehicle.year).toBe(vehicle.year);
expect(store.vehicle.make).toBe(vehicle.make); expect(store.vehicle.make).toBe(vehicle.make);
expect(store.vehicle.model).toBe(vehicle.model); expect(store.vehicle.model).toBe(vehicle.model);
expect(store.vehicle.style).toBe(vehicle.style); expect(store.vehicle.style).toBe(vehicle.style);
// vin is not set directly by loadSession, it's set by updateVehicle after lookupVehicleByVin // vin is not set directly by loadSessionFromDuplicate, it's set by updateVehicle after lookupVehicleByVin
expect(store.vehicle.registration.licensePlate).toBe(vehicle.licensePlateNumber); expect(store.vehicle.registration.licensePlate).toBe(vehicle.licensePlateNumber);
}); });
it('sets expected customer data', async () => { it('sets expected customer data', async () => {
@ -1248,7 +1248,7 @@ describe('Store', () => {
store.policy.vehicles = [{ vin: vehicle.vin }]; store.policy.vehicles = [{ vin: vehicle.vin }];
// Act // Act
await store.loadSession(duplicate); await store.loadSessionFromDuplicate(duplicate);
// Asserts // Asserts
expect(store.order.customer.address.streetAddress).toBe(customer.address.streetAddress); expect(store.order.customer.address.streetAddress).toBe(customer.address.streetAddress);
@ -1274,7 +1274,7 @@ describe('Store', () => {
}; };
// Act // Act
await store.loadSession(duplicate); await store.loadSessionFromDuplicate(duplicate);
// Asserts // Asserts
expect(store.order.referralNumber).toBe(fullApiResponse.data.referralNumber); expect(store.order.referralNumber).toBe(fullApiResponse.data.referralNumber);
@ -1295,7 +1295,7 @@ describe('Store', () => {
}; };
// Act // Act
await store.loadSession(duplicate).catch((e) => { await store.loadSessionFromDuplicate(duplicate).catch((e) => {
expect(e).toEqual(error); expect(e).toEqual(error);
}); });
@ -2233,7 +2233,7 @@ describe('Store', () => {
}); });
}); });
describe('loadSession method', () => { describe('loadSessionFromDuplicate method', () => {
let mockDuplicate; let mockDuplicate;
let mockResponse; let mockResponse;
let savedSessionId = getRandomGuid(); let savedSessionId = getRandomGuid();
@ -2296,7 +2296,7 @@ describe('Store', () => {
store.applicationUser.savedSessionId = savedSessionId; store.applicationUser.savedSessionId = savedSessionId;
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(globalMethods.callHttpClient).toHaveBeenCalledWith({ expect(globalMethods.callHttpClient).toHaveBeenCalledWith({
@ -2319,7 +2319,7 @@ describe('Store', () => {
const originalLoadedFromDupeCheck = store.order.loadedFromDupeCheck; const originalLoadedFromDupeCheck = store.order.loadedFromDupeCheck;
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.customer.address.streetAddress).toBe(originalStreetAddress); expect(store.order.customer.address.streetAddress).toBe(originalStreetAddress);
expect(store.order.loadedFromDupeCheck).toBe(originalLoadedFromDupeCheck); expect(store.order.loadedFromDupeCheck).toBe(originalLoadedFromDupeCheck);
@ -2330,7 +2330,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.customer.address.streetAddress).toBe(mockResponse.data.customer.address.streetAddress); expect(store.order.customer.address.streetAddress).toBe(mockResponse.data.customer.address.streetAddress);
@ -2345,7 +2345,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.customer.firstName).toBe(mockResponse.data.customer.firstName); expect(store.order.customer.firstName).toBe(mockResponse.data.customer.firstName);
@ -2362,7 +2362,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.contactInfo.homePhone).toBe('1234567890'); expect(store.order.contactInfo.homePhone).toBe('1234567890');
@ -2374,7 +2374,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.vehicle.year).toBe(mockResponse.data.vehicle.year); expect(store.order.vehicle.year).toBe(mockResponse.data.vehicle.year);
@ -2389,7 +2389,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.insuranceCoverage.coverageType).toBe(mockResponse.data.insuranceCoverage.coverageType); expect(store.order.insuranceCoverage.coverageType).toBe(mockResponse.data.insuranceCoverage.coverageType);
@ -2410,7 +2410,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.insuranceCoverage.coverageStatus).toBe(coverageStatuses.VERIFIED); expect(store.order.insuranceCoverage.coverageStatus).toBe(coverageStatuses.VERIFIED);
@ -2426,7 +2426,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.vehicle.registration.licensePlate).toBe(mockResponse.data.vehicle.licensePlateNumber); expect(store.order.vehicle.registration.licensePlate).toBe(mockResponse.data.vehicle.licensePlateNumber);
@ -2457,7 +2457,7 @@ describe('Store', () => {
store.updateVehicleCoverage = jest.fn(); store.updateVehicleCoverage = jest.fn();
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.lookupVehicleByVin).toHaveBeenCalledWith(mockResponse.data.vehicle.vin); expect(store.lookupVehicleByVin).toHaveBeenCalledWith(mockResponse.data.vehicle.vin);
@ -2477,7 +2477,7 @@ describe('Store', () => {
store.lookupVehicleByVin = jest.fn(); store.lookupVehicleByVin = jest.fn();
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); expect(store.lookupVehicleByVin).not.toHaveBeenCalled();
@ -2492,7 +2492,7 @@ describe('Store', () => {
store.lookupVehicleByVin = jest.fn(); store.lookupVehicleByVin = jest.fn();
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); expect(store.lookupVehicleByVin).not.toHaveBeenCalled();
@ -2507,7 +2507,7 @@ describe('Store', () => {
store.lookupVehicleByVin = jest.fn(); store.lookupVehicleByVin = jest.fn();
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); expect(store.lookupVehicleByVin).not.toHaveBeenCalled();
@ -2520,7 +2520,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.insuranceCoverage.coverageStatus).toBe(originalCoverageStatus); expect(store.order.insuranceCoverage.coverageStatus).toBe(originalCoverageStatus);
@ -2531,7 +2531,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.referralNumber).toBe(mockResponse.data.referralNumber); expect(store.order.referralNumber).toBe(mockResponse.data.referralNumber);
@ -2546,7 +2546,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.loadedFromDupeCheck).toBe(true); expect(store.order.loadedFromDupeCheck).toBe(true);
@ -2559,7 +2559,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.reject(error)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.reject(error));
// Act & Assert // Act & Assert
await expect(store.loadSession(mockDuplicate)).rejects.toThrow('API Error'); await expect(store.loadSessionFromDuplicate(mockDuplicate)).rejects.toThrow('API Error');
}); });
it('should handle missing optional fields in response data', async () => { it('should handle missing optional fields in response data', async () => {
@ -2569,7 +2569,7 @@ describe('Store', () => {
globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse));
// Act // Act
await store.loadSession(mockDuplicate); await store.loadSessionFromDuplicate(mockDuplicate);
// Assert // Assert
expect(store.order.customer.address.streetAddress2).toBeUndefined(); expect(store.order.customer.address.streetAddress2).toBeUndefined();