From b30e7bc054685151a85d861199f240140bc6e262 Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Thu, 25 Jun 2026 12:08:43 -0400 Subject: [PATCH] Renamed loadSession method to loadSessionFromDuplicate to more accurately reflect its usage. --- .../duplicate-check/duplicate-check.spec.js | 12 ++--- .../duplicate-check/duplicate-check.vue | 2 +- src/store/index.js | 2 +- src/store/store.spec.js | 52 +++++++++---------- 4 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/layouts/duplicate-check/duplicate-check.spec.js b/src/layouts/duplicate-check/duplicate-check.spec.js index 95346c26..ada47fc0 100644 --- a/src/layouts/duplicate-check/duplicate-check.spec.js +++ b/src/layouts/duplicate-check/duplicate-check.spec.js @@ -297,13 +297,13 @@ describe('duplicateCheck.vue', () => { }); wrapper.setData({ selectedAnswer }); - useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.resolve({})); + useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.resolve({})); // Act await wrapper.vm.forwardButtonAction(); // Assert - expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(1); + expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(1); expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1); }); test('Selected new order => load session not called', async () => { @@ -325,13 +325,13 @@ describe('duplicateCheck.vue', () => { }); wrapper.setData({ selectedAnswer: newOrderSelectionName }); - useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.resolve({})); + useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.resolve({})); // Act await wrapper.vm.forwardButtonAction(); // Assert - expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(0); + expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(0); expect(wrapper.vm.$router.navigate).toHaveBeenCalledTimes(1); }); test('Load session throws error => still navigate forward', async () => { @@ -354,7 +354,7 @@ describe('duplicateCheck.vue', () => { wrapper.setData({ selectedAnswer }); const error = 'load session error'; - useMainStore().loadSession = jest.fn().mockImplementation(() => Promise.reject(error)); + useMainStore().loadSessionFromDuplicate = jest.fn().mockImplementation(() => Promise.reject(error)); // Act @@ -365,7 +365,7 @@ describe('duplicateCheck.vue', () => { } catch (e) { expect(e).toMatch(error); } - expect(wrapper.vm.mainStore.loadSession).toHaveBeenCalledTimes(1); + expect(wrapper.vm.mainStore.loadSessionFromDuplicate).toHaveBeenCalledTimes(1); }); test('coverageType deductible and policy vehicles returned => CLICKED_FORWARD_POLICY_VERIFIED_WITH_VEHICLES', async () => { // Arrange diff --git a/src/layouts/duplicate-check/duplicate-check.vue b/src/layouts/duplicate-check/duplicate-check.vue index 3c4ead5f..ec33c88b 100644 --- a/src/layouts/duplicate-check/duplicate-check.vue +++ b/src/layouts/duplicate-check/duplicate-check.vue @@ -144,7 +144,7 @@ export default { this.mainStore.applicationUser.duplicateOrders.find((o) => o.correlationId === this.selectedAnswer); if (selectedReferral) { - await this.mainStore.loadSession(selectedReferral); + await this.mainStore.loadSessionFromDuplicate(selectedReferral); } this.navigateForward(); diff --git a/src/store/index.js b/src/store/index.js index 805a974b..dee920e0 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -1617,7 +1617,7 @@ export const useMainStore = defineStore({ } }); }, - async loadSession(duplicate) { + async loadSessionFromDuplicate(duplicate) { const { applicationUser, order } = this; // NOTE: We are re-using the current user's saved session id (this is required on the load-session call). // This should be ok, but should probably validate. diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 0fc1ddd0..271d1a34 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -1140,7 +1140,7 @@ describe('Store', () => { }); }); - describe('loadSession method', () => { + describe('loadSessionFromDuplicate method', () => { describe('successful method call', () => { const applicationUser = { experiments: getRandomString(6, 6) @@ -1192,7 +1192,7 @@ describe('Store', () => { }; // Act - store.loadSession(duplicate); + store.loadSessionFromDuplicate(duplicate); // Asserts expect(globalMethods.callHttpClient).toHaveBeenCalledWith(expect.objectContaining({ @@ -1219,14 +1219,14 @@ describe('Store', () => { store.policy.vehicles = [{ vehicle }]; // Act - await store.loadSession(duplicate); + await store.loadSessionFromDuplicate(duplicate); // Asserts expect(store.vehicle.year).toBe(vehicle.year); expect(store.vehicle.make).toBe(vehicle.make); expect(store.vehicle.model).toBe(vehicle.model); expect(store.vehicle.style).toBe(vehicle.style); - // vin is not set directly by loadSession, it's set by updateVehicle after lookupVehicleByVin + // vin is not set directly by loadSessionFromDuplicate, it's set by updateVehicle after lookupVehicleByVin expect(store.vehicle.registration.licensePlate).toBe(vehicle.licensePlateNumber); }); it('sets expected customer data', async () => { @@ -1248,7 +1248,7 @@ describe('Store', () => { store.policy.vehicles = [{ vin: vehicle.vin }]; // Act - await store.loadSession(duplicate); + await store.loadSessionFromDuplicate(duplicate); // Asserts expect(store.order.customer.address.streetAddress).toBe(customer.address.streetAddress); @@ -1274,7 +1274,7 @@ describe('Store', () => { }; // Act - await store.loadSession(duplicate); + await store.loadSessionFromDuplicate(duplicate); // Asserts expect(store.order.referralNumber).toBe(fullApiResponse.data.referralNumber); @@ -1295,7 +1295,7 @@ describe('Store', () => { }; // Act - await store.loadSession(duplicate).catch((e) => { + await store.loadSessionFromDuplicate(duplicate).catch((e) => { expect(e).toEqual(error); }); @@ -2233,7 +2233,7 @@ describe('Store', () => { }); }); - describe('loadSession method', () => { + describe('loadSessionFromDuplicate method', () => { let mockDuplicate; let mockResponse; let savedSessionId = getRandomGuid(); @@ -2296,7 +2296,7 @@ describe('Store', () => { store.applicationUser.savedSessionId = savedSessionId; // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(globalMethods.callHttpClient).toHaveBeenCalledWith({ @@ -2319,7 +2319,7 @@ describe('Store', () => { const originalLoadedFromDupeCheck = store.order.loadedFromDupeCheck; // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.customer.address.streetAddress).toBe(originalStreetAddress); expect(store.order.loadedFromDupeCheck).toBe(originalLoadedFromDupeCheck); @@ -2330,7 +2330,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.customer.address.streetAddress).toBe(mockResponse.data.customer.address.streetAddress); @@ -2345,7 +2345,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.customer.firstName).toBe(mockResponse.data.customer.firstName); @@ -2362,7 +2362,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.contactInfo.homePhone).toBe('1234567890'); @@ -2374,7 +2374,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.vehicle.year).toBe(mockResponse.data.vehicle.year); @@ -2389,7 +2389,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.insuranceCoverage.coverageType).toBe(mockResponse.data.insuranceCoverage.coverageType); @@ -2410,7 +2410,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.insuranceCoverage.coverageStatus).toBe(coverageStatuses.VERIFIED); @@ -2426,7 +2426,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.vehicle.registration.licensePlate).toBe(mockResponse.data.vehicle.licensePlateNumber); @@ -2457,7 +2457,7 @@ describe('Store', () => { store.updateVehicleCoverage = jest.fn(); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.lookupVehicleByVin).toHaveBeenCalledWith(mockResponse.data.vehicle.vin); @@ -2477,7 +2477,7 @@ describe('Store', () => { store.lookupVehicleByVin = jest.fn(); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); @@ -2492,7 +2492,7 @@ describe('Store', () => { store.lookupVehicleByVin = jest.fn(); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); @@ -2507,7 +2507,7 @@ describe('Store', () => { store.lookupVehicleByVin = jest.fn(); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.lookupVehicleByVin).not.toHaveBeenCalled(); @@ -2520,7 +2520,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.insuranceCoverage.coverageStatus).toBe(originalCoverageStatus); @@ -2531,7 +2531,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.referralNumber).toBe(mockResponse.data.referralNumber); @@ -2546,7 +2546,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.loadedFromDupeCheck).toBe(true); @@ -2559,7 +2559,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.reject(error)); // Act & Assert - await expect(store.loadSession(mockDuplicate)).rejects.toThrow('API Error'); + await expect(store.loadSessionFromDuplicate(mockDuplicate)).rejects.toThrow('API Error'); }); it('should handle missing optional fields in response data', async () => { @@ -2569,7 +2569,7 @@ describe('Store', () => { globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(mockResponse)); // Act - await store.loadSession(mockDuplicate); + await store.loadSessionFromDuplicate(mockDuplicate); // Assert expect(store.order.customer.address.streetAddress2).toBeUndefined();