jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #501 from Safelite/feature/CSR-628

Browse source 
CSR-628 Pass in referralNumber and accountNumber as strings
This commit is contained in:
katieoh-safelite 2022-05-20 13:36:06 -04:00 committed by GitHub
commit b3635ad6c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/helpers/heritage-integration/navigation-helper.spec.js
View file

@ -305,7 +305,7 @@ describe("getPageToRouteExistingOrderTo", () => {
describe("navigateToHeritageFunnel", () => {
test("should save order", async () => {
// Arrange
const mockReferralNumber = 2;
const mockReferralNumber = "2";
const mockCorrelationId = "55";
const mockReferralDate = "2022";
@ -337,7 +337,7 @@ describe("navigateToHeritageFunnel", () => {
test("should go to heritage funnel", async () => {
// Arrange
const mockReferralNumber = 2;
const mockReferralNumber = "2";
const mockCorrelationId = "55";
const mockReferralDate = "2022";

4
src/helpers/heritage-integration/order-helper.js
View file

@ -38,10 +38,10 @@ export async function saveOrder() {
// Save the referral information back from the store.
await baseMixin.methods.dispatchStoreAction(storeActions.SET_REFERRAL_INFORMATION, {
referralNumber: savedOrderInfo.data.referralNumber,
referralNumber: savedOrderInfo.data.referralNumber.toString(),
referralCorrelationId: savedOrderInfo.data.referralCorrelationId,
referralDate: savedOrderInfo.data.referralDate,
accountNumber: savedOrderInfo.data.accountNumber
accountNumber: savedOrderInfo.data.accountNumber.toString()
}, false);
// Update the cookie with the referral information when saved.

8
src/helpers/heritage-integration/order-helper.spec.js
View file

@ -103,11 +103,12 @@ describe("saveOrder", () => {
test("saveOrder => should set state order values", async () => {
// Arrange
const mockReferralNumber = 2;
const mockReferralNumber = "2";
const mockCorrelationId = "55";
const mockReferralDate = "2022";
const mockAccountNumber = "5";
const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate);
const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber);
const mockData = {
actionList: [
@ -131,7 +132,8 @@ describe("saveOrder", () => {
expect(mocks.baseMixin.methods.dispatchStoreAction).toHaveBeenCalledWith(storeActions.SET_REFERRAL_INFORMATION, {
referralNumber: mockReferralNumber,
referralDate: mockReferralDate,
referralCorrelationId: mockCorrelationId
referralCorrelationId: mockCorrelationId,
accountNumber: mockAccountNumber
}, false);
});

5
src/helpers/unit-test-helper.js
View file

@ -89,11 +89,12 @@ export function removeAllTestCookies() {
});
}
export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate) {
export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, accountNumber = "0") {
return {
referralNumber: mockReferralNumber,
referralCorrelationId: mockCorrelationId,
referralDate: mockReferralDate
referralDate: mockReferralDate,
accountNumber: accountNumber
}
}

8
src/store/index.js
View file

@ -573,9 +573,9 @@ export const actions = {
state: order.serviceLocation.state,
zipCode: order.serviceLocation.zipCode
},
referralNumber: order.referralNumber,
referralNumber: order.referralNumber?.toString(), // TODO It'd be nice to save these as strings in the first place
referralDate: order.referralDate,
accountNumber: order.accountNumber
accountNumber: order.accountNumber?.toString()
},
});
},
@ -585,10 +585,10 @@ export const actions = {
method: endpoints.LoadOrder.method,
endpoint: endpoints.LoadOrder.url,
payload: {
referralNumber: referralNumber,
referralNumber: referralNumber?.toString(),
referralDate: referralDate,
referralCorrelationId: referralCorrelationId,
accountNumber: accountNumber
accountNumber: accountNumber?.toString()
},
}).then((response) => {
context.commit(storeMutations.RESET_STATE);