From 3f26bf6e97e0d08c4a570ecbfc8d4c2a04eb4d9b Mon Sep 17 00:00:00 2001 From: Katie Date: Fri, 20 May 2022 13:06:34 -0400 Subject: [PATCH 1/3] CSR-628 Pass in referralNumber and accountNumber as strings --- src/helpers/heritage-integration/order-helper.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/helpers/heritage-integration/order-helper.js b/src/helpers/heritage-integration/order-helper.js index b18b64a85..d64ab865d 100644 --- a/src/helpers/heritage-integration/order-helper.js +++ b/src/helpers/heritage-integration/order-helper.js @@ -38,10 +38,10 @@ export async function saveOrder() { // Save the referral information back from the store. await baseMixin.methods.dispatchStoreAction(storeActions.SET_REFERRAL_INFORMATION, { - referralNumber: savedOrderInfo.data.referralNumber, + referralNumber: savedOrderInfo.data.referralNumber.toString(), referralCorrelationId: savedOrderInfo.data.referralCorrelationId, referralDate: savedOrderInfo.data.referralDate, - accountNumber: savedOrderInfo.data.accountNumber + accountNumber: savedOrderInfo.data.accountNumber.toString() }, false); // Update the cookie with the referral information when saved. From 844cbf088f7079ae453835cb8de584d6b31ecd86 Mon Sep 17 00:00:00 2001 From: Katie Date: Fri, 20 May 2022 13:18:46 -0400 Subject: [PATCH 2/3] CSR-628 Fix tests --- .../heritage-integration/navigation-helper.spec.js | 4 ++-- src/helpers/heritage-integration/order-helper.spec.js | 8 +++++--- src/helpers/unit-test-helper.js | 5 +++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/helpers/heritage-integration/navigation-helper.spec.js b/src/helpers/heritage-integration/navigation-helper.spec.js index 01bf5dcdc..e212284b8 100644 --- a/src/helpers/heritage-integration/navigation-helper.spec.js +++ b/src/helpers/heritage-integration/navigation-helper.spec.js @@ -305,7 +305,7 @@ describe("getPageToRouteExistingOrderTo", () => { describe("navigateToHeritageFunnel", () => { test("should save order", async () => { // Arrange - const mockReferralNumber = 2; + const mockReferralNumber = "2"; const mockCorrelationId = "55"; const mockReferralDate = "2022"; @@ -337,7 +337,7 @@ describe("navigateToHeritageFunnel", () => { test("should go to heritage funnel", async () => { // Arrange - const mockReferralNumber = 2; + const mockReferralNumber = "2"; const mockCorrelationId = "55"; const mockReferralDate = "2022"; diff --git a/src/helpers/heritage-integration/order-helper.spec.js b/src/helpers/heritage-integration/order-helper.spec.js index 803c94b6b..b66286d50 100644 --- a/src/helpers/heritage-integration/order-helper.spec.js +++ b/src/helpers/heritage-integration/order-helper.spec.js @@ -103,11 +103,12 @@ describe("saveOrder", () => { test("saveOrder => should set state order values", async () => { // Arrange - const mockReferralNumber = 2; + const mockReferralNumber = "2"; const mockCorrelationId = "55"; const mockReferralDate = "2022"; + const mockAccountNumber = "5"; - const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate); + const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber); const mockData = { actionList: [ @@ -131,7 +132,8 @@ describe("saveOrder", () => { expect(mocks.baseMixin.methods.dispatchStoreAction).toHaveBeenCalledWith(storeActions.SET_REFERRAL_INFORMATION, { referralNumber: mockReferralNumber, referralDate: mockReferralDate, - referralCorrelationId: mockCorrelationId + referralCorrelationId: mockCorrelationId, + accountNumber: mockAccountNumber }, false); }); diff --git a/src/helpers/unit-test-helper.js b/src/helpers/unit-test-helper.js index 6577ed6ff..4f4214120 100644 --- a/src/helpers/unit-test-helper.js +++ b/src/helpers/unit-test-helper.js @@ -89,11 +89,12 @@ export function removeAllTestCookies() { }); } -export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate) { +export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, accountNumber = "0") { return { referralNumber: mockReferralNumber, referralCorrelationId: mockCorrelationId, - referralDate: mockReferralDate + referralDate: mockReferralDate, + accountNumber: accountNumber } } From 3acea7906a115abb2e37561a5c70c2e82fa7fa80 Mon Sep 17 00:00:00 2001 From: Katie Date: Fri, 20 May 2022 13:33:05 -0400 Subject: [PATCH 3/3] CSR-628 Type changes --- src/store/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 0d5a9e355..814ca2d5b 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -573,9 +573,9 @@ export const actions = { state: order.serviceLocation.state, zipCode: order.serviceLocation.zipCode }, - referralNumber: order.referralNumber, + referralNumber: order.referralNumber?.toString(), // TODO It'd be nice to save these as strings in the first place referralDate: order.referralDate, - accountNumber: order.accountNumber + accountNumber: order.accountNumber?.toString() }, }); }, @@ -585,10 +585,10 @@ export const actions = { method: endpoints.LoadOrder.method, endpoint: endpoints.LoadOrder.url, payload: { - referralNumber: referralNumber, + referralNumber: referralNumber?.toString(), referralDate: referralDate, referralCorrelationId: referralCorrelationId, - accountNumber: accountNumber + accountNumber: accountNumber?.toString() }, }).then((response) => { context.commit(storeMutations.RESET_STATE);