jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1519 from Safelite/feature/skiener/CSR-1452

Browse source 
CSR-1452 | Tech review changes
This commit is contained in:
scottkiener 2023-11-13 16:21:07 -05:00 committed by GitHub
commit 8f9cee7070
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/fmg-components/funnel-header/funnel-header.vue
View file

@ -32,7 +32,6 @@ export default {
name: "funnel-header", name: "funnel-header",
data() { data() {
return { return {
alertIdCounter: 0,
globalAlertMessages: [], globalAlertMessages: [],
}; };
}, },
@ -47,8 +46,7 @@ export default {
methods: { methods: {
pushGlobalAlert(alertToPush, isAutoDismissing) { pushGlobalAlert(alertToPush, isAutoDismissing) {
alertToPush.displayAlert = true; alertToPush.displayAlert = true;
alertToPush.id = this.alertIdCounter; alertToPush.id = crypto.randomUUID();
this.alertIdCounter++;
if (isAutoDismissing) { if (isAutoDismissing) {
setTimeout(() => { setTimeout(() => {
alertToPush.displayAlert = false; alertToPush.displayAlert = false;

6
src/store/index.js
View file

@ -546,7 +546,6 @@ export const mutations = {
state.order.customer.phoneNumber = sessionInformation.order.customer.phoneNumber; state.order.customer.phoneNumber = sessionInformation.order.customer.phoneNumber;
state.order.customer.isSmsOptIn = sessionInformation.order.customer.isSmsOptIn; state.order.customer.isSmsOptIn = sessionInformation.order.customer.isSmsOptIn;
state.order.existingPromoCode = sessionInformation.order.existingPromoCode;
state.applicationUser.experiments = sessionInformation.applicationUser.experiments; state.applicationUser.experiments = sessionInformation.applicationUser.experiments;
state.applicationUser.crmCustomerId = sessionInformation.applicationUser.crmCustomerId; state.applicationUser.crmCustomerId = sessionInformation.applicationUser.crmCustomerId;
state.applicationUser.pageData = sessionInformation.applicationUser.pageData; state.applicationUser.pageData = sessionInformation.applicationUser.pageData;
@ -1718,7 +1717,6 @@ export const actions = {
jobMaxMinutes: order.schedule?.jobMaxMinutes, jobMaxMinutes: order.schedule?.jobMaxMinutes,
jobMinMinutes: order.schedule?.jobMinMinutes, jobMinMinutes: order.schedule?.jobMinMinutes,
}, },
existingPromoCode: null,
referralCorrelationId: order.referralCorrelationId, referralCorrelationId: order.referralCorrelationId,
referralDate: order.referralDate, referralDate: order.referralDate,
referralNumber: order.referralNumber?.toString(), referralNumber: order.referralNumber?.toString(),
@ -2792,8 +2790,8 @@ function convertGlassPieceToBackEndCompatibleFormat(glassPieces) {
function renameGlassToReplaceAttributes(glassToReplace) { function renameGlassToReplaceAttributes(glassToReplace) {
let newGlassToReplace = []; let newGlassToReplace = [];
if (glassToReplace) { if (glassToReplace) {
glassToReplace.forEach((item) => { newGlassToReplace = glassToReplace.map((item) => {
newGlassToReplace.push({ location: item.glassLocation, name: item.glassName }); return { location: item.glassLocation, name: item.glassName };
}); });
} }
return newGlassToReplace; return newGlassToReplace;