From 13be6d455971abd92353a6905a0fa2a5c546fae2 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Mon, 13 Nov 2023 15:48:42 -0500 Subject: [PATCH 1/2] CSR-1452 | Tech review changes --- src/fmg-components/funnel-header/funnel-header.vue | 3 +-- src/store/index.js | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/fmg-components/funnel-header/funnel-header.vue b/src/fmg-components/funnel-header/funnel-header.vue index 26a9652d4..d3ddceea5 100644 --- a/src/fmg-components/funnel-header/funnel-header.vue +++ b/src/fmg-components/funnel-header/funnel-header.vue @@ -47,8 +47,7 @@ export default { methods: { pushGlobalAlert(alertToPush, isAutoDismissing) { alertToPush.displayAlert = true; - alertToPush.id = this.alertIdCounter; - this.alertIdCounter++; + alertToPush.id = crypto.randomUUID(); if (isAutoDismissing) { setTimeout(() => { alertToPush.displayAlert = false; diff --git a/src/store/index.js b/src/store/index.js index 320ff3e28..941b65aca 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -546,7 +546,6 @@ export const mutations = { state.order.customer.phoneNumber = sessionInformation.order.customer.phoneNumber; state.order.customer.isSmsOptIn = sessionInformation.order.customer.isSmsOptIn; - state.order.existingPromoCode = sessionInformation.order.existingPromoCode; state.applicationUser.experiments = sessionInformation.applicationUser.experiments; state.applicationUser.crmCustomerId = sessionInformation.applicationUser.crmCustomerId; state.applicationUser.pageData = sessionInformation.applicationUser.pageData; @@ -1718,7 +1717,6 @@ export const actions = { jobMaxMinutes: order.schedule?.jobMaxMinutes, jobMinMinutes: order.schedule?.jobMinMinutes, }, - existingPromoCode: null, referralCorrelationId: order.referralCorrelationId, referralDate: order.referralDate, referralNumber: order.referralNumber?.toString(), @@ -2792,8 +2790,8 @@ function convertGlassPieceToBackEndCompatibleFormat(glassPieces) { function renameGlassToReplaceAttributes(glassToReplace) { let newGlassToReplace = []; if (glassToReplace) { - glassToReplace.forEach((item) => { - newGlassToReplace.push({ location: item.glassLocation, name: item.glassName }); + newGlassToReplace = glassToReplace.map((item) => { + return { location: item.glassLocation, name: item.glassName }; }); } return newGlassToReplace; From 09d21df0725e1dc9e6404631f0b23d3b85b6fe51 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Mon, 13 Nov 2023 16:16:21 -0500 Subject: [PATCH 2/2] CSR-1452 | Remove unused data member --- src/fmg-components/funnel-header/funnel-header.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/fmg-components/funnel-header/funnel-header.vue b/src/fmg-components/funnel-header/funnel-header.vue index d3ddceea5..4a0936fd5 100644 --- a/src/fmg-components/funnel-header/funnel-header.vue +++ b/src/fmg-components/funnel-header/funnel-header.vue @@ -32,7 +32,6 @@ export default { name: "funnel-header", data() { return { - alertIdCounter: 0, globalAlertMessages: [], }; },