jason/polaris-task-force
1
0
Fork 0
Code Issues Wiki Activity

fix: use span for close button to ensure true transparency

Browse source 
- Browser button elements have default background/border
- Span with onClick provides the same functionality with no defaults
- Maintains keyboard focus states and accessibility
This commit is contained in:
Jason Fraley 2026-07-28 17:33:20 -04:00
parent fbaad2e4bb
commit 9651ad83ae
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/components/admin/narrative-flow/NodeEditDialog.tsx
View file

@ -249,13 +249,13 @@ export const NodeEditDialog: FC<NodeEditDialogProps> = ({
<DialogHeader> <DialogHeader>
<DialogTitle className="flex items-center justify-between"> <DialogTitle className="flex items-center justify-between">
<span>Edit {typeLabel}</span> <span>Edit {typeLabel}</span>
<button <span
onClick={() => onOpenChange(false)} onClick={() => onOpenChange(false)}
className="hover:bg-zinc-100 dark:hover:bg-zinc-800 transition-colors" className="hover:bg-zinc-100 dark:hover:bg-zinc-800 transition-colors focus:outline-none focus-visible:ring-2 focus-visible:ring-zinc-400 rounded-full"
aria-label="Close" aria-label="Close"
> >
<XIcon className="size-4 text-zinc-500" /> <XIcon className="size-8 text-zinc-500" />
</button> </span>
</DialogTitle> </DialogTitle>
</DialogHeader> </DialogHeader>
{renderFields()} {renderFields()}