From b0157f4c90adc5019f2544bfaeeddd5b1a746511 Mon Sep 17 00:00:00 2001 From: Mic Date: Wed, 5 Mar 2025 18:08:16 +0100 Subject: [PATCH 1/4] filtering placeholders base on add_tags option and not tb permissions --- js/mzta-placeholders.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/mzta-placeholders.js b/js/mzta-placeholders.js index 3c87be15..aa7173f7 100644 --- a/js/mzta-placeholders.js +++ b/js/mzta-placeholders.js @@ -162,7 +162,8 @@ export async function getPlaceholders(onlyEnabled = false){ output.sort((a, b) => a.id.localeCompare(b.id)); } // console.log('>>>>>>>>>>>> getPlaceholders output: ' + JSON.stringify(output)); - if (!await browser.permissions.contains({ permissions: ["messagesTagsList"] })) { + let prefs = await browser.storage.local.get({ add_tags: false }); + if (prefs.add_tags) { output = output.filter(obj => obj.id !== 'tags_full_list' && obj.id !== 'tags_current_email'); } return output; From a06d19169597f3d6b91cc7481770a303700826aa Mon Sep 17 00:00:00 2001 From: Mic Date: Wed, 5 Mar 2025 18:09:01 +0100 Subject: [PATCH 2/4] refactor: change const to let for permission request variables --- options/mzta-options.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/options/mzta-options.js b/options/mzta-options.js index 20f88862..ad4b31ed 100644 --- a/options/mzta-options.js +++ b/options/mzta-options.js @@ -302,7 +302,7 @@ document.addEventListener('DOMContentLoaded', async () => { addtags_el.addEventListener('click', (event) => { async function _addtags_el_change() { if (event.target.checked) { - const granted = await messenger.permissions.request({ permissions: ["messagesTagsList", "messagesTags", "messagesUpdate"] }); + let granted = await messenger.permissions.request({ permissions: ["messagesTagsList", "messagesTags", "messagesUpdate"] }); if (!granted) { event.target.checked = false; addtags_info_btn.disabled = 'disabled'; @@ -319,7 +319,7 @@ document.addEventListener('DOMContentLoaded', async () => { spamfilter_el.addEventListener('click', (event) => { async function _spamfilter_el_change() { if (event.target.checked) { - const granted = await messenger.permissions.request({ permissions: ["messagesMove"] }); + let granted = await messenger.permissions.request({ permissions: ["messagesMove"] }); if (!granted) { event.target.checked = false; spamfilter_info_btn.disabled = 'disabled'; From 242dfb70f1859844c094dcfd7011352860dd509b Mon Sep 17 00:00:00 2001 From: Mic Date: Wed, 5 Mar 2025 18:10:09 +0100 Subject: [PATCH 3/4] update version to 3.2.2 --- CHANGELOG.md | 4 ++++ manifest.json | 2 +- options/mzta-release-notes.html | 4 ++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5cad6e7b..a17fec4d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ +

Version 3.2.2 - ??/??/2025

+
    +
  • ...
    • +

Version 3.2.1 - 03/03/2025

  • Fix calling a prompt without giving tags related permissions [#275].
    • diff --git a/manifest.json b/manifest.json index a7b01a5c..21eb8ac2 100644 --- a/manifest.json +++ b/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "ThunderAI", "description": "__MSG_extensionDescription__", - "version": "3.2.1", + "version": "3.2.2", "author": "Mic (m@micz.it)", "homepage_url": "https://micz.it/thunderbird-addon-thunderai/", "browser_specific_settings": { diff --git a/options/mzta-release-notes.html b/options/mzta-release-notes.html index c50c2b53..7b3295ff 100644 --- a/options/mzta-release-notes.html +++ b/options/mzta-release-notes.html @@ -7,6 +7,10 @@

    ThunderAI Release Notes

    +

    Version 3.2.2 - ??/??/2025

    +
      +
    • ...
      • +

    Version 3.2.1 - 03/03/2025

    • Fix calling a prompt without giving tags related permissions [#275].
      • From 5a795a1e1fa788158cb7bc045592dd97bd956afa Mon Sep 17 00:00:00 2001 From: Mic Date: Wed, 5 Mar 2025 18:15:19 +0100 Subject: [PATCH 4/4] remove permission checks for add_tags and spamfilter options --- mzta-background.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/mzta-background.js b/mzta-background.js index dd310a59..c073cf5c 100644 --- a/mzta-background.js +++ b/mzta-background.js @@ -798,20 +798,4 @@ const newEmailListener = (folder, messagesList) => { return _newEmailListener(); } -// Disable tag option if permissions are not granted -if (prefs_init.add_tags) { - if(!await browser.permissions.contains({permissions: ["messagesTagsList", "messagesTags", "messagesUpdate"]})){ - browser.storage.sync.set({add_tags: false}); - taLog.log("Permissions not granted, disabling add_tags"); - } -} - -// Disable anti spam option if permissions are not granted -if (prefs_init.spamfilter) { - if(!await browser.permissions.contains({permissions: ["messagesMove"]})){ - browser.storage.sync.set({spamfilter: false}); - taLog.log("Permissions not granted, disabling spamfilter"); - } -} - browser.messages.onNewMailReceived.addListener(newEmailListener, !prefs_init.add_tags_auto_only_inbox);