Merge pull request #404 from Safelite/refactor/initial-prefer-default

prefer default - initial attempt: application-config
This commit is contained in:
Jeremy-Z 2023-08-09 12:29:49 -04:00 committed by GitHub
commit f44d13505c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 24 additions and 24 deletions

View file

@ -1,36 +1,36 @@
const analyticsPageEvents = { const analyticsPageEvents = Object.freeze({
ENTRY: 'ENTRY', ENTRY: 'ENTRY',
EVENT: 'EVENT' EVENT: 'EVENT'
}; });
// GA Constants // GA Constants
const GaEvents = { const GaEvents = Object.freeze({
GENERIC_EVENT: 'event', GENERIC_EVENT: 'event',
PAGE_VIEW_EVENT: 'logPageview' PAGE_VIEW_EVENT: 'logPageview'
}; });
const GaCategories = { const GaCategories = Object.freeze({
API_RESPONSE: 'Api_Response', API_RESPONSE: 'Api_Response',
EVOX: 'Evox' EVOX: 'Evox'
}; });
const GaActions = { const GaActions = Object.freeze({
RESULT: 'Result', RESULT: 'Result',
CLICKED: 'Clicked', CLICKED: 'Clicked',
VIF: 'vif', VIF: 'vif',
SUBMITTED: 'Submitted' SUBMITTED: 'Submitted'
}; });
const GaLabels = { const GaLabels = Object.freeze({
SUCCESS: 'Success', SUCCESS: 'Success',
ERROR: 'Error', ERROR: 'Error',
LICENSE_PLATE_LOOKUP: 'License_Plate_Look_Up', LICENSE_PLATE_LOOKUP: 'License_Plate_Look_Up',
VIN_LOOKUP: 'Vin_Look_Up', VIN_LOOKUP: 'Vin_Look_Up',
ADDRESS_LOOKUP: 'Address_Look_up' ADDRESS_LOOKUP: 'Address_Look_up'
}; });
const ValueToLogTypes = { const ValueToLogTypes = Object.freeze({
LAST_5: 'last_5' LAST_5: 'last_5'
}; });
export { analyticsPageEvents, GaCategories, GaActions, GaLabels, GaEvents, ValueToLogTypes }; export { analyticsPageEvents, GaCategories, GaActions, GaLabels, GaEvents, ValueToLogTypes };

View file

@ -14,4 +14,4 @@ const applicationConfig = {
CASH_PARENT_ACCOUNT_NUMBER: 167132 CASH_PARENT_ACCOUNT_NUMBER: 167132
}; };
export { applicationConfig }; export default Object.freeze(applicationConfig);

View file

@ -1,4 +1,4 @@
import { applicationConfig } from '@/constants/application-config.js'; import applicationConfig from '@/constants/application-config.js';
const cookieNames = { const cookieNames = {
ISS_SESSION_INFO: `ISSSessionInfo-${applicationConfig.CURRENT_ENVIRONMENT}`, ISS_SESSION_INFO: `ISSSessionInfo-${applicationConfig.CURRENT_ENVIRONMENT}`,

View file

@ -2,7 +2,7 @@ import axios from 'axios';
import analyticsMixIn from '@/mixins/analytics-mixin.js'; import analyticsMixIn from '@/mixins/analytics-mixin.js';
import { useMainStore } from '@/store'; import { useMainStore } from '@/store';
import { applicationConfig } from '@/constants/application-config.js'; import applicationConfig from '@/constants/application-config.js';
import { GaCategories, GaActions, GaLabels } from '@/constants/analytics'; import { GaCategories, GaActions, GaLabels } from '@/constants/analytics';
import { headerKeys } from '@/constants/header-keys'; import { headerKeys } from '@/constants/header-keys';

View file

@ -1,5 +1,5 @@
import { cookieNames } from '@/constants/cookie-names'; import { cookieNames } from '@/constants/cookie-names';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
import { useMainStore } from '@/store'; import { useMainStore } from '@/store';
/* /*

View file

@ -1,4 +1,4 @@
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
import { getISSCookie } from '@/helpers/cookie-helper.js'; import { getISSCookie } from '@/helpers/cookie-helper.js';
/* /*

View file

@ -4,7 +4,7 @@ import {
isSavedSessionStillActive, isSavedSessionStillActive,
getDateForSavedSessionTimeout getDateForSavedSessionTimeout
} from '@/helpers/session-helper'; } from '@/helpers/session-helper';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
describe('isAnalyticsSessionStillActive', () => { describe('isAnalyticsSessionStillActive', () => {
test('isAnalyticsSessionStillActive, should return true', () => { test('isAnalyticsSessionStillActive, should return true', () => {

View file

@ -92,7 +92,7 @@
import textboxQuestion from '@/digital-components/textbox-question/textbox-question'; import textboxQuestion from '@/digital-components/textbox-question/textbox-question';
import dropdownQuestion from '@/digital-components/dropdown-question/dropdown-question'; import dropdownQuestion from '@/digital-components/dropdown-question/dropdown-question';
import alert from '@/ux-components/alert/alert'; import alert from '@/ux-components/alert/alert';
import { applicationConfig } from '@/constants/application-config.js'; import applicationConfig from '@/constants/application-config.js';
import { defineRule } from 'vee-validate'; import { defineRule } from 'vee-validate';
import { required, regex } from '@/helpers/validation-rules'; import { required, regex } from '@/helpers/validation-rules';
import { errorMessages } from '@/constants/error-messages'; import { errorMessages } from '@/constants/error-messages';

View file

@ -11,7 +11,7 @@ import { nextTick } from 'vue';
import baseMixin from '@/mixins/base-mixin.js'; import baseMixin from '@/mixins/base-mixin.js';
import { useMainStore } from '@/store'; import { useMainStore } from '@/store';
import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
// Mock our module for promises. // Mock our module for promises.
jest.mock('@/helpers/layout-helper.js', () => ({ jest.mock('@/helpers/layout-helper.js', () => ({

View file

@ -7,7 +7,7 @@ import { settleAllPromises } from '@/helpers/layout-helper.js';
import { fetchCmsContentForPage } from '@/helpers/cms-content-helper'; import { fetchCmsContentForPage } from '@/helpers/cms-content-helper';
import baseMixin from '@/mixins/base-mixin.js'; import baseMixin from '@/mixins/base-mixin.js';
import { getMountOptions } from '@/helpers/unit-test-helper.js'; import { getMountOptions } from '@/helpers/unit-test-helper.js';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
import { useMainStore } from '@/store'; import { useMainStore } from '@/store';
import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios';

View file

@ -12,7 +12,7 @@ import {
updateSessionIdCookie updateSessionIdCookie
} from '@/helpers/cookie-helper'; } from '@/helpers/cookie-helper';
import { experimentTriggers } from '@/constants/experiments'; import { experimentTriggers } from '@/constants/experiments';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
import analyticsMixin from '@/mixins/analytics-mixin'; import analyticsMixin from '@/mixins/analytics-mixin';
import { navigationScenarios } from './router-constants/navigation-scenarios'; import { navigationScenarios } from './router-constants/navigation-scenarios';

View file

@ -6,7 +6,7 @@ import { getDateForSavedSessionTimeout } from '@/helpers/session-helper';
// eslint-disable-next-line import/no-cycle // eslint-disable-next-line import/no-cycle
import globalMethods from '@/global-methods'; import globalMethods from '@/global-methods';
import { experimentTriggers } from '@/constants/experiments'; import { experimentTriggers } from '@/constants/experiments';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
import { issPageValues } from '@/router/router-constants/issPage-values'; import { issPageValues } from '@/router/router-constants/issPage-values';
import { damageLocationsSelected } from '@/constants/damage-locations-selected'; import { damageLocationsSelected } from '@/constants/damage-locations-selected';
import { coverageStatuses } from '@/constants/coverage-statuses'; import { coverageStatuses } from '@/constants/coverage-statuses';

View file

@ -60,7 +60,7 @@ import {
getRouterLinkDisplayTextFromCopy, getRouterLinkDisplayTextFromCopy,
splitCMSCopyOnParagraphTag splitCMSCopyOnParagraphTag
} from '@/helpers/cms-content-helper'; } from '@/helpers/cms-content-helper';
import { applicationConfig } from '@/constants/application-config'; import applicationConfig from '@/constants/application-config';
export default { export default {
name: 'alert', name: 'alert',