From ca3aad4112272db26563015f5ac883d55b74a8ba Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 27 Apr 2023 16:26:06 -0400 Subject: [PATCH 01/13] resize site-header to match Figma specs --- src/iss-components/site-header/menu-modal/menu-modal.vue | 6 +++--- src/iss-components/site-header/site-header.vue | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/iss-components/site-header/menu-modal/menu-modal.vue b/src/iss-components/site-header/menu-modal/menu-modal.vue index 214076d0..1330a6da 100644 --- a/src/iss-components/site-header/menu-modal/menu-modal.vue +++ b/src/iss-components/site-header/menu-modal/menu-modal.vue @@ -63,7 +63,7 @@ export default { }, methods: { show() { - this.currentFooterAndHeaderHeight = this.getFooterInfoBoxHeight() + 72; + this.currentFooterAndHeaderHeight = this.getFooterInfoBoxHeight() + 56; this.isActive = true; document.querySelector('.fade-on-route-transition').scrollTo({ top: 0, behavior: 'instant' @@ -123,8 +123,8 @@ export default { &.menu-modal { max-width: 576px; left: auto; - height: calc(100% - 72px); - top: 72px; + height: calc(100% - 56px); + top: 56px; border-top: 1px solid $gray-300; overflow-x: visible; overflow-y: visible; diff --git a/src/iss-components/site-header/site-header.vue b/src/iss-components/site-header/site-header.vue index 75a82bef..7aa03480 100644 --- a/src/iss-components/site-header/site-header.vue +++ b/src/iss-components/site-header/site-header.vue @@ -88,13 +88,12 @@ export default({ From d5c08cf894d5f9299bf789582b587aecbbd6849c Mon Sep 17 00:00:00 2001 From: Jason Wheeler Date: Fri, 28 Apr 2023 10:19:50 -0400 Subject: [PATCH 05/13] Set default header to account number 0 and loaded on nextclick to fix race condition --- .../site-header/site-header.vue | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/iss-components/site-header/site-header.vue b/src/iss-components/site-header/site-header.vue index 75a82bef..4c9e4938 100644 --- a/src/iss-components/site-header/site-header.vue +++ b/src/iss-components/site-header/site-header.vue @@ -53,12 +53,19 @@ export default({ }; } }, + methods: { + setupHeader(){ + const answers = this.getCmsContent(this.cmsWidgetName, "Answers"); + if(Array.isArray(answers)) + { + this.headerAnswers = answers.filter(x => x.AccountNumber == this.mainStore.issConfig.accountNumber)[0] + this.headerAnswers = !this.headerAnswers ? answers.filter(x => x.AccountNumber === '0')[0] : this.headerAnswers; + } + } + }, mounted() { - const answers = this.getCmsContent(this.cmsWidgetName, "Answers"); - this.headerAnswers = Array.isArray(answers) - ? answers.filter(x => x.AccountNumber == this.mainStore.issConfig.accountNumber)[0] - : null; - + this.$nextTick(this.setupHeader); + // Check if alert event is on the bus const alertEvent = eventBus.readAndPopEventFromBus( globalEvents.Categories.GLOBAL_ALERT, @@ -78,11 +85,11 @@ export default({ { document.getElementsByTagName("body")[0].className += " " + clientOverrideClass; } - }, - components: { - menuModal, - alert - }, + }, + components: { + menuModal, + alert + }, }) From 26e177116056ada580f9280ac968c74e90e22d0c Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Fri, 28 Apr 2023 19:50:34 +0530 Subject: [PATCH 06/13] navigationScenarios optimised navigationScenarios optimised --- .../policy-holder-details/policy-holder-details.vue | 2 +- src/layouts/welcome-page/welcome-page.vue | 2 +- src/router/router-constants/navigation-scenarios.js | 8 +++++--- src/router/router-constants/routing-table.js | 4 ++-- src/router/router.spec.js | 2 +- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/layouts/policy-holder-details/policy-holder-details.vue b/src/layouts/policy-holder-details/policy-holder-details.vue index 324babc7..6a75e5b7 100644 --- a/src/layouts/policy-holder-details/policy-holder-details.vue +++ b/src/layouts/policy-holder-details/policy-holder-details.vue @@ -132,7 +132,7 @@ export default { ); else this.$router.navigate( - this.navigationScenarios.CLICKED_FORWARD_POLICY_HOLDER_DETAILS, + this.navigationScenarios.CLICKED_FORWARD_POLICY_UNVERIFIED, this.$route ); }, diff --git a/src/layouts/welcome-page/welcome-page.vue b/src/layouts/welcome-page/welcome-page.vue index 3757e2e4..737c636c 100644 --- a/src/layouts/welcome-page/welcome-page.vue +++ b/src/layouts/welcome-page/welcome-page.vue @@ -241,7 +241,7 @@ export default { navigateForward() { this.$router.navigate( - this.navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE, + this.navigationScenarios.CLICKED_FORWARD, this.$route ); }, diff --git a/src/router/router-constants/navigation-scenarios.js b/src/router/router-constants/navigation-scenarios.js index 7bdb0f02..f0a0c871 100644 --- a/src/router/router-constants/navigation-scenarios.js +++ b/src/router/router-constants/navigation-scenarios.js @@ -10,10 +10,12 @@ const navigationScenarios = { SELECTED_YEAR: "SELECTED_YEAR", SELECTED_MAKE: "SELECTED_MAKE", SELECTED_MODEL: "SELECTED_MODEL", - SELECTED_STYLE: "SELECTED_STYLE", - CLICKED_FORWARD_WELCOME_PAGE: "CLICKED_FORWARD_WELCOME_PAGE", - CLICKED_FORWARD_POLICY_HOLDER_DETAILS: "CLICKED_FORWARD_POLICY_HOLDER_DETAILS", + SELECTED_STYLE: "SELECTED_STYLE", + + //Policy Holder Details + CLICKED_FORWARD_POLICY_UNVERIFIED: "CLICKED_FORWARD_POLICY_UNVERIFIED", CLICKED_FORWARD_POLICY_VERIFIED: "CLICKED_FORWARD_POLICY_VERIFIED", + // Vehicle Damage CLICKED_FORWARD_WITH_REPAIR: 'CLICKED_FORWARD_WITH_REPAIR', diff --git a/src/router/router-constants/routing-table.js b/src/router/router-constants/routing-table.js index 30df077c..b8681067 100644 --- a/src/router/router-constants/routing-table.js +++ b/src/router/router-constants/routing-table.js @@ -375,7 +375,7 @@ const routingTable = function(store) { destinationIssPageValue: issPageValues.WELCOME_PAGE }, { - scenario: navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE, + scenario: navigationScenarios.CLICKED_FORWARD, destinationIssPageValue: issPageValues.POLICY_HOLDER_DETAILS } ] @@ -388,7 +388,7 @@ const routingTable = function(store) { destinationIssPageValue: issPageValues.WELCOME_PAGE }, { - scenario: navigationScenarios.CLICKED_FORWARD_POLICY_HOLDER_DETAILS, + scenario: navigationScenarios.CLICKED_FORWARD_POLICY_UNVERIFIED, destinationIssPageValue: issPageValues.VEHICLE_YEAR }, { diff --git a/src/router/router.spec.js b/src/router/router.spec.js index 67962988..92301ca9 100644 --- a/src/router/router.spec.js +++ b/src/router/router.spec.js @@ -15,7 +15,7 @@ describe("Router", () => { it("Should push next view when navigating locally", () => { - let scenario = navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE; + let scenario = navigationScenarios.CLICKED_FORWARD; let currentRoute = { query: { issPage: issPageValues.WELCOME_PAGE }}; router.push = jest.fn(); From 50ff72b91cd61c49111f1092ed70b3502a70ecf6 Mon Sep 17 00:00:00 2001 From: Kroell Date: Fri, 28 Apr 2023 16:57:33 -0400 Subject: [PATCH 07/13] updates to margins around site-header --- src/layouts/address-lookup/address-lookup.vue | 4 ++-- src/layouts/address-vehicles/address-vehicles.vue | 2 +- src/layouts/coverage-statement/coverage-statement.vue | 2 +- src/layouts/license-plate-lookup/license-plate-lookup.vue | 2 +- src/layouts/policy-holder-details/policy-holder-details.vue | 1 + src/layouts/vehicle-damage/vehicle-damage.vue | 4 ++-- src/layouts/vehicle-lookup/vehicle-lookup.vue | 4 ++-- src/layouts/vin-lookup/vin-lookup.vue | 2 +- src/layouts/welcome-page/welcome-page.vue | 4 ++-- 9 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/layouts/address-lookup/address-lookup.vue b/src/layouts/address-lookup/address-lookup.vue index a2c345f3..ea0b4622 100644 --- a/src/layouts/address-lookup/address-lookup.vue +++ b/src/layouts/address-lookup/address-lookup.vue @@ -9,11 +9,11 @@
- +
diff --git a/src/layouts/coverage-statement/coverage-statement.vue b/src/layouts/coverage-statement/coverage-statement.vue index d6aa5d42..dd4048db 100644 --- a/src/layouts/coverage-statement/coverage-statement.vue +++ b/src/layouts/coverage-statement/coverage-statement.vue @@ -12,7 +12,7 @@ cmsWidgetName="verifyingCoverageStatement" typeStyle="h5" justifyText="center" - class="mt-0 mb-4" + class="mt-4 mb-4" id="coverage-statement-text-block" />
diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index b1c49299..485e6b7d 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -8,7 +8,7 @@
- +
-
+
diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.vue b/src/layouts/vehicle-lookup/vehicle-lookup.vue index 6d30d29e..9bebbd57 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.vue +++ b/src/layouts/vehicle-lookup/vehicle-lookup.vue @@ -8,8 +8,8 @@
- - + +
diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index 8221c7c6..58356d9c 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -8,7 +8,7 @@
- + diff --git a/src/layouts/welcome-page/welcome-page.vue b/src/layouts/welcome-page/welcome-page.vue index 737c636c..bb43b7c2 100644 --- a/src/layouts/welcome-page/welcome-page.vue +++ b/src/layouts/welcome-page/welcome-page.vue @@ -3,9 +3,9 @@
- +
-
+
Date: Mon, 1 May 2023 11:11:50 -0400 Subject: [PATCH 08/13] update spacing around site-header --- .../questions-page-layout.vue | 2 +- .../policy-vehicles/policy-vehicles.vue | 2 +- .../provider-preference.vue | 2 +- .../service-location/service-location.vue | 21 ++++--------------- .../service-packages/service-packages.vue | 3 ++- src/layouts/vehicle-parts/vehicle-parts.vue | 2 +- 6 files changed, 10 insertions(+), 22 deletions(-) diff --git a/src/iss-components/questions-page-layout/questions-page-layout.vue b/src/iss-components/questions-page-layout/questions-page-layout.vue index be67de5b..49bde25e 100644 --- a/src/iss-components/questions-page-layout/questions-page-layout.vue +++ b/src/iss-components/questions-page-layout/questions-page-layout.vue @@ -8,7 +8,7 @@
- +
- +
diff --git a/src/layouts/provider-preference/provider-preference.vue b/src/layouts/provider-preference/provider-preference.vue index c9079718..eb049925 100644 --- a/src/layouts/provider-preference/provider-preference.vue +++ b/src/layouts/provider-preference/provider-preference.vue @@ -6,7 +6,7 @@
- +
- +
@@ -28,8 +28,7 @@ buttonTypeString="listCard" isRequired v-model="selectedAppointmentType" - validationRules="selection-required" - class="service-location-button-question"/> + validationRules="selection-required" />
@@ -235,7 +234,7 @@ export default { } .question-text { & > span { - line-height: 1.500rem; + line-height: 1.5rem; } } .list-card-content p { @@ -246,12 +245,6 @@ export default { line-height: 1.250rem; } } -.siteHeader{ - .site-header{ - margin-bottom: 1.25rem !important; - } - -} .choose-option{ .button-question >div { &:first-of-type { @@ -262,13 +255,7 @@ export default { } .button-question{ .row.form-test-error{ - line-height:1.500rem; - padding-left: 0rem !important; - } -} -.service-location-button-question { - .question-text { - margin-top: 1.5rem; + line-height:1.5rem; } } diff --git a/src/layouts/service-packages/service-packages.vue b/src/layouts/service-packages/service-packages.vue index 14adb371..1c427ec4 100644 --- a/src/layouts/service-packages/service-packages.vue +++ b/src/layouts/service-packages/service-packages.vue @@ -5,7 +5,8 @@ + issContainingPage="service-packages" + class="my-5"/>
From 6142d3639751321f497ea0ca44eb76b2543a18b3 Mon Sep 17 00:00:00 2001 From: Kroell Date: Mon, 1 May 2023 11:45:34 -0400 Subject: [PATCH 09/13] margin fix --- .../questions-page-layout/questions-page-layout.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/iss-components/questions-page-layout/questions-page-layout.vue b/src/iss-components/questions-page-layout/questions-page-layout.vue index 49bde25e..657d02b9 100644 --- a/src/iss-components/questions-page-layout/questions-page-layout.vue +++ b/src/iss-components/questions-page-layout/questions-page-layout.vue @@ -16,7 +16,8 @@ alertClass="alert-warning" :manualHeadline="alertFewMoreQuestionsHeader" :manualCopy="alertFewMoreQuestionsCopy" - v-bind:isDismissible="false" /> + v-bind:isDismissible="false" + class="mt-5"/>
Date: Mon, 1 May 2023 11:56:11 -0400 Subject: [PATCH 10/13] remove styling - affects other pages --- src/layouts/policy-holder-details/policy-holder-details.vue | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/layouts/policy-holder-details/policy-holder-details.vue b/src/layouts/policy-holder-details/policy-holder-details.vue index e0ccd451..bf726402 100644 --- a/src/layouts/policy-holder-details/policy-holder-details.vue +++ b/src/layouts/policy-holder-details/policy-holder-details.vue @@ -168,11 +168,6 @@ export default { } \ No newline at end of file diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index d21a16fe..8059b5b8 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -2,14 +2,14 @@
- +
- +
@@ -29,11 +29,15 @@ import policyVehiclesQuestion from "@/layouts/policy-vehicles/policy-vehicles-qu // Supporting files import { fetchCmsContentForPage } from "@/helpers/cms-content-helper"; import { settleAllPromises } from "@/helpers/layout-helper"; -import { Form } from "vee-validate"; +import { Form,defineRule } from "vee-validate"; import BaseFormMixin from '@/mixins/base-form-mixin.js'; import { issPageValues } from "@/router/router-constants/issPage-values"; import { useMainStore } from '@/store'; +import { errorMessages } from "@/constants/error-messages"; +import { required } from "@/helpers/validation-rules"; +// DEFINE VALIDATION RULES +defineRule("option-required", required(errorMessages.OPTION_REQUIRED)); export default { name: "policy-vehicles", mixins: [BaseFormMixin], @@ -94,4 +98,14 @@ export default { Form, }, } - \ No newline at end of file + + \ No newline at end of file From e8c6250d14bc09c5b662f8193011423a4daaae45 Mon Sep 17 00:00:00 2001 From: DavidAtSafelite Date: Tue, 2 May 2023 08:04:23 -0400 Subject: [PATCH 12/13] Modified to conform to SSR-315 --- .../service-package-question.vue | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/layouts/service-packages/service-package-question/service-package-question.vue b/src/layouts/service-packages/service-package-question/service-package-question.vue index 1a44ba9b..c9011df2 100644 --- a/src/layouts/service-packages/service-package-question/service-package-question.vue +++ b/src/layouts/service-packages/service-package-question/service-package-question.vue @@ -54,7 +54,7 @@ }, servicePackageAnswers() { if (!this.cmsWidgetName) return []; - const cmsAnswersContent = [ + let cmsAnswersContent = [ { Name: 'TierOne', cmsWidgetName: 'EconomyServicePackage' @@ -72,6 +72,10 @@ if (this.getCmsContent(cmsAnswersContent[0].cmsWidgetName, 'HeaderText') == '') { return {}; } + + if (!this.shouldDisplayTierTwoPackage) { + cmsAnswersContent = cmsAnswersContent.filter((answer) => answer.Name != packageNames.TIER_TWO); + } const modifiedAnswers = cmsAnswersContent.map((answer) => ({ value: answer.Name, buttonLabel: this.getHeaderTextFromCms(answer.cmsWidgetName), @@ -88,13 +92,9 @@ }, frontWipersApplicableForTierTwo() { const store = useMainStore(); - const frontWipersAreAvailable = this.lineItemsContainsPartType( - partTypeStrings.FRONT_WIPER - ); + const frontWipersAreAvailable = this.lineItemsContainsPartType(partTypeStrings.FRONT_WIPER); const isRepair = store.order.damage.isRepair; - const glassToReplaceContainsWindshield = this.glassToReplaceContainsGlassLocation( - glassLocations.WINDSHIELD - ); + const glassToReplaceContainsWindshield = this.glassToReplaceContainsGlassLocation(glassLocations.WINDSHIELD); if (frontWipersAreAvailable) { if (isRepair) { return true; @@ -162,7 +162,7 @@ }, getPackagePriceString(packageName) { const formattedPriceFloat = parseFloat(this.getPackagePrice(packageName)).toFixed(2); - return '$' + formattedPriceFloat; + return '+$' + formattedPriceFloat; }, getPackagePrice(packageName) { let priceFloat = 0; @@ -178,11 +178,9 @@ const priceFrontWipers = this.frontWipersApplicableForTierTwo; const priceRearWipers = this.rearWiperApplicableForTierTwo; this.nullSafeAvailableLineItems.forEach((item) => { - if ( - (priceFrontWipers && - item.partType.toUpperCase() === partTypeStrings.FRONT_WIPER) || - (priceRearWipers && item.partType.toUpperCase() === partTypeStrings.REAR_WIPER) - ) { + if ((priceFrontWipers && + item.partType.toUpperCase() === partTypeStrings.FRONT_WIPER) || + (priceRearWipers && item.partType.toUpperCase() === partTypeStrings.REAR_WIPER)) { vapsPrice += this.getTotalLineItemPrice(item); } }); From ec2a01a9d966020420ffd8222f5e1a3cdfa1f229 Mon Sep 17 00:00:00 2001 From: Kroell Date: Tue, 2 May 2023 09:54:29 -0400 Subject: [PATCH 13/13] spacing change for service-location page --- src/layouts/service-location/service-location.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index c78468db..133fab9c 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -3,7 +3,7 @@
- +