jason/DigitalConsumer.ISS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #989 from Safelite/feature/humphries/INSR-7892

Browse source 
INSR-7892: Some fixes for default package select
This commit is contained in:
AHumphriesSL 2025-12-19 12:03:40 -05:00 committed by GitHub
commit e138a09499
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 15 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/constants/part-type-strings.js
View file

@ -3,7 +3,7 @@
WINDSHIELD: 'WINDSHIELD', WINDSHIELD: 'WINDSHIELD',
FRONT_WIPER: 'FRONT WIPER', FRONT_WIPER: 'FRONT WIPER',
REAR_WIPER: 'REAR WIPER', REAR_WIPER: 'REAR WIPER',
RAIN_DEFENSE: 'RAIN DEFENSE', RAIN_DEFENSE: 'RAIN REPEL',
RECALIBRATION: 'RECALIBRATION', RECALIBRATION: 'RECALIBRATION',
REPLACE_FEE: 'REPLACE FEE', REPLACE_FEE: 'REPLACE FEE',
MOBILE_FEE: 'MOBILE FEE', MOBILE_FEE: 'MOBILE FEE',

6
src/helpers/service-package-helper.spec.js
View file

@ -33,9 +33,9 @@ const rearWiperLineItem = {
}; };
const rainDefenseLineItem = { const rainDefenseLineItem = {
partNumber: 'RAIN DEFENSE', partNumber: 'RAIN REPEL',
description: null, description: null,
partType: 'RAIN DEFENSE', partType: 'RAIN REPEL',
price: 35.5 price: 35.5
}; };
@ -115,7 +115,7 @@ describe('service-package-helper.js', () => {
passengerFrontWiperLineItem, passengerFrontWiperLineItem,
rainDefenseLineItem rainDefenseLineItem
]; ];
const partType = 'rAin DEfenSe'; const partType = 'rAin rEpeL';
// Act // Act
const result = servicePackageHelper.findLineItemsWithPartType(partType, lineItems); const result = servicePackageHelper.findLineItemsWithPartType(partType, lineItems);

2
src/iss-components/cart-dropdown/cart-dropdown.spec.js
View file

@ -688,7 +688,7 @@ describe('cart-dropdown component', () => {
}); });
const expectedFrontWiperName = 'front wiper'; const expectedFrontWiperName = 'front wiper';
const expectedRearWiperName = 'rear wiper'; const expectedRearWiperName = 'rear wiper';
const expectedRainDefenseName = 'rain defense'; const expectedRainDefenseName = 'rain repel';
const vapsItemDescriptions = [ const vapsItemDescriptions = [
{ {
Name: frontWiperPartType, Name: frontWiperPartType,

6
src/layouts/payment-method/review-dropdown/review-sections/service-package-review/service-package-review.spec.js
View file

@ -31,7 +31,7 @@ const testConstants = {
vapsCopy: { vapsCopy: {
frontWiperCopy: 'Front Wiper copy', frontWiperCopy: 'Front Wiper copy',
rearWiperCopy: 'Rear Wiper copy', rearWiperCopy: 'Rear Wiper copy',
rainDefenseCopy: 'Rain defense copy' rainDefenseCopy: 'Rain repel copy'
}, },
parts: { parts: {
frontWiperPart: { frontWiperPart: {
@ -47,9 +47,9 @@ const testConstants = {
price: 24.48 price: 24.48
}, },
rainDefensePart: { rainDefensePart: {
partNumber: 'RAIN DEFENSE', partNumber: 'RAIN REPEL',
description: null, description: null,
partType: 'RAIN DEFENSE', partType: 'RAIN REPEL',
price: 35.5 price: 35.5
}, },
recalPart: { recalPart: {

6
src/layouts/payment-page/payment-page.spec.js
View file

@ -45,10 +45,10 @@ const parts = {
price: 24.48 price: 24.48
}, },
rainDefense: { rainDefense: {
name: 'rain defense', name: 'rain repel',
partNumber: 'RAIN DEFENSE', partNumber: 'RAIN REPEL',
description: null, description: null,
partType: 'RAIN DEFENSE', partType: 'RAIN REPEL',
price: 35.5 price: 35.5
} }
}; };

4
src/layouts/service-packages/service-package-question/service-package-question.vue
View file

@ -143,9 +143,7 @@ export default {
}, },
watch: { watch: {
availableLineItems() { availableLineItems() {
if (allGlassPartsAndItemsHavePrices(store.order.lineItems)) { this.selectDefaultPackage();
this.selectDefaultPackage();
}
}, },
selectedPackageName(newValue) { selectedPackageName(newValue) {
const VapsProductsInSelectedPackage = this.getVapsLineItemsForSelectedPackage(newValue); const VapsProductsInSelectedPackage = this.getVapsLineItemsForSelectedPackage(newValue);

6
src/layouts/service-packages/service-packages.vue
View file

@ -114,7 +114,7 @@ export default {
const availableLineItems = []; const availableLineItems = [];
if (resultMap?.rainDefense?.length > 0) { if (resultMap?.rainDefense) {
availableLineItems.push(resultMap.rainDefense); availableLineItems.push(resultMap.rainDefense);
} }
@ -127,7 +127,7 @@ export default {
} }
let hasBailedOut = false; let hasBailedOut = false;
await store.getCombinedQuote(availableLineItems) const pricedItems = await store.getCombinedQuote(availableLineItems)
.catch((err) => { .catch((err) => {
useMainStore().setBailout(bailoutMessage.pricingResponseError( useMainStore().setBailout(bailoutMessage.pricingResponseError(
availableLineItems.map((li) => li.partNumber), availableLineItems.map((li) => li.partNumber),
@ -141,7 +141,7 @@ export default {
if (!hasBailedOut) { if (!hasBailedOut) {
next((vm) => { next((vm) => {
vm.setCmsContent(resultMap.cmsContent); vm.setCmsContent(resultMap.cmsContent);
vm.setData([resultMap.rainDefense, ...resultMap.wipers]); vm.setData(pricedItems);
}); });
} }
}, },