jason/DigitalConsumer.ISS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #266 from Safelite/feature/digital/SSR-426

Browse source 
added logic to prevent page crashing due to analytics service being un…
This commit is contained in:
Jason Wheeler 2023-04-25 13:32:56 -04:00 committed by GitHub
commit dc08ffa17c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/mixins/analytics-mixin.js
View file

@ -144,18 +144,18 @@ export default {
const response = await useMainStore().initializeSession(payload); const response = await useMainStore().initializeSession(payload);
if (response.data) { if (response?.data) {
if (response.data.sessionKey && skey === 0) { if (response?.data.sessionKey && skey === 0) {
setCookieProperties( setCookieProperties(
{ [cookieNames.SESSION_KEY]: response.data.sessionKey }, { [cookieNames.SESSION_KEY]: response?.data.sessionKey },
{ {
useDefaultFunnelCookieAttributes: false, useDefaultFunnelCookieAttributes: false,
} }
); );
} }
if (response.data.sessionId && sid === "00000000-0000-0000-0000-000000000000") { if (response?.data.sessionId && sid === "00000000-0000-0000-0000-000000000000") {
setCookieProperties( setCookieProperties(
{ [cookieNames.SESSION_ID]: response.data.sessionId }, { [cookieNames.SESSION_ID]: response?.data.sessionId },
{ {
maxAge: 60 * 30, // 30 minutes maxAge: 60 * 30, // 30 minutes
} }

27
src/store/index.js
View file

@ -973,7 +973,14 @@ export const useMainStore = defineStore({
endpoint: endpoints.LogPageView.url, endpoint: endpoints.LogPageView.url,
payload: payload, payload: payload,
logApiCall: false logApiCall: false
}); }).then(
(response) => {
return response;
},
(error) => {
console.log("Analytics Service Error: " + error.data);
}
);
}, },
logCustomEvent({ userId, sessionKey, pageName, sessionId, category, action, label, value, shouldUseSessionId, experimentsForUser}) logCustomEvent({ userId, sessionKey, pageName, sessionId, category, action, label, value, shouldUseSessionId, experimentsForUser})
{ {
@ -999,7 +1006,14 @@ export const useMainStore = defineStore({
endpoint: endpoints.LogCustomEvent.url, endpoint: endpoints.LogCustomEvent.url,
payload: payload, payload: payload,
logApiCall: false logApiCall: false
}); }).then(
(response) => {
return response;
},
(error) => {
console.log("Analytics Service Error: " + error.data);
}
);
}, },
initializeSession({ userId, sessionId, userAgent, referrer }) { initializeSession({ userId, sessionId, userAgent, referrer }) {
var payload = { var payload = {
@ -1018,7 +1032,14 @@ export const useMainStore = defineStore({
endpoint: endpoints.InitializeSession.url, endpoint: endpoints.InitializeSession.url,
payload: payload, payload: payload,
logApiCall: false logApiCall: false
}); }).then(
(response) => {
return response;
},
(error) => {
console.log("Analytics Service Error: " + error.data);
}
);
}, },
updateLastPageVisited(lastPageVisited) { updateLastPageVisited(lastPageVisited) {