From d8f52ed821b5606d1d9a4117b7d365d47a978c47 Mon Sep 17 00:00:00 2001 From: brydon1 Date: Mon, 18 Sep 2023 16:28:16 -0400 Subject: [PATCH] Refactor --- src/layouts/welcome-page/welcome-page.spec.js | 22 ++----------------- src/layouts/welcome-page/welcome-page.vue | 6 +---- src/store/index.js | 8 ++++++- 3 files changed, 10 insertions(+), 26 deletions(-) diff --git a/src/layouts/welcome-page/welcome-page.spec.js b/src/layouts/welcome-page/welcome-page.spec.js index e6c59695..573b8fce 100644 --- a/src/layouts/welcome-page/welcome-page.spec.js +++ b/src/layouts/welcome-page/welcome-page.spec.js @@ -178,20 +178,7 @@ describe('welcome-page.vue', () => { describe('navigation', () => { test('if duplicates found, navigate to duplicate check page', async () => { // Arrange - const accountNumber = getRandomString(5, 5); - const policyNumber = getRandomString(5, 5); - const dateOfLoss = getRandomString(5, 5); - const { wrapper } = getMountedComponent({ - order: { - policy: { - policyNumber: policyNumber, - dateOfLoss: dateOfLoss - } - }, - issConfig: { - accountNumber: accountNumber - } - }); + const { wrapper } = getMountedComponent({}); const duplicatesExist = { policyLookupResponse: {}, @@ -204,12 +191,7 @@ describe('navigation', () => { await wrapper.vm.forwardButtonAction(); // Assert - expect(wrapper.vm.mainStore.getDuplicates).toHaveBeenCalledWith( - { - accountNumber: accountNumber, - policyNumber: policyNumber, - dateOfLoss: dateOfLoss - }); + expect(wrapper.vm.mainStore.getDuplicateReferrals).toHaveBeenCalled(); expect(wrapper.vm.$router.navigate).toHaveBeenCalledWith( navigationScenarios.CLICKED_FORWARD_WITH_DUPLICATES, undefined, diff --git a/src/layouts/welcome-page/welcome-page.vue b/src/layouts/welcome-page/welcome-page.vue index 477d811c..fec2bfad 100644 --- a/src/layouts/welcome-page/welcome-page.vue +++ b/src/layouts/welcome-page/welcome-page.vue @@ -298,11 +298,7 @@ export default { methods: { async forwardButtonAction() { this.mainStore.updatePolicyData(this.welcomePageModel); - const duplicateCheckResponse = useMainStore().getDuplicates({ - accountNumber: this.mainStore.issConfig.accountNumber.toString(), - policyNumber: this.mainStore.order.policy.policyNumber, - dateOfLoss: this.mainStore.order.policy.dateOfLoss - }); + const duplicateCheckResponse = useMainStore().getDuplicateReferrals(); const duplicatePromiseResultMap = [ { resultKey: 'duplicateCheckResponse', diff --git a/src/store/index.js b/src/store/index.js index 4cad1921..8427db57 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -470,7 +470,13 @@ export const useMainStore = defineStore({ }); }, // TODO when endpoint finished replace dummy data with api call - getDuplicates({accountNumber, policyNumber, dateOfLoss}) { + getDuplicateReferrals() { + const apiInputs = [ + this.issConfig.accountNumber, + this.order.policy.policyNumber, + this.order.policy.dateOfLoss + ]; + return [ { referralNumber: "12345",