From 302ddf30900db65335be369bcd9671f799e8774d Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 4 Aug 2023 15:45:34 -0400 Subject: [PATCH 1/5] display clear vehicle image when vehicle is autoselected --- src/layouts/policy-vehicles/policy-vehicles.vue | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 16699160..56985843 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -72,14 +72,17 @@ export default { vm.setCmsContent(cmsContentPromise); }); }, + mounted() { + if (this.VehiclesFromApi?.length === 1) { + this.selectedVehicleVin = this.VehiclesFromApi[0].vin; + } + }, data() { const policyVehicles = useMainStore().pageData(issPageValues.POLICY_VEHICLES); return { policyVehicles, - selectedVehicleVin: (policyVehicles?.length ?? 0) === 1 - ? policyVehicles[0].vin - : '', - displayGeneric: (policyVehicles?.length ?? 0) !== 1, + selectedVehicleVin: '', + displayGeneric: true, bailout: false, rules: { optionRequired: globalRules.OPTION_REQUIRED From 73c36be620e25d88b641932ea65f88e94c32f91c Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 4 Aug 2023 15:57:33 -0400 Subject: [PATCH 2/5] linting fix --- src/layouts/policy-vehicles/policy-vehicles.vue | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 56985843..efd7777b 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -72,11 +72,6 @@ export default { vm.setCmsContent(cmsContentPromise); }); }, - mounted() { - if (this.VehiclesFromApi?.length === 1) { - this.selectedVehicleVin = this.VehiclesFromApi[0].vin; - } - }, data() { const policyVehicles = useMainStore().pageData(issPageValues.POLICY_VEHICLES); return { @@ -160,6 +155,11 @@ export default { } } }, + mounted() { + if (this.VehiclesFromApi?.length === 1) { + this.selectedVehicleVin = this.VehiclesFromApi[0].vin; + } + }, methods: { backButtonAction() { From 0cc039f15f0b29134f6ac89961409c33825875dc Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Mon, 7 Aug 2023 10:22:43 -0400 Subject: [PATCH 3/5] replace references to policyVehicles with VehiclesFromApi --- src/layouts/policy-vehicles/policy-vehicles.vue | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index efd7777b..ea683c21 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -73,9 +73,7 @@ export default { }); }, data() { - const policyVehicles = useMainStore().pageData(issPageValues.POLICY_VEHICLES); return { - policyVehicles, selectedVehicleVin: '', displayGeneric: true, bailout: false, @@ -87,7 +85,7 @@ export default { computed: { VehiclesForQuestions() { // Map API result data, to address-vehicles data structure - const vehicles = this.policyVehicles; + const vehicles = this.VehiclesFromApi; const mappedData = vehicles?.map((v) => { const maskSymbol = 'X'; const vinStart = maskSymbol.repeat(v.vin.length - 6); @@ -103,13 +101,13 @@ export default { return mappedData; }, noCoverageForSelectedVehicle() { - const vehicle = this.policyVehicles.find((policyVehicle) => - policyVehicle.vin === this.selectedVehicleVin); + const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => + vehicleFromApi.vin === this.selectedVehicleVin); return (vehicle?.coverages?.length ?? 0) === 0; }, deductibleForSelectedVehicle() { - const vehicle = this.policyVehicles.find((policyVehicle) => - policyVehicle?.vin === this.selectedVehicleVin); + const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => + vehicleFromApi?.vin === this.selectedVehicleVin); if (!vehicle) { return undefined; } @@ -119,8 +117,8 @@ export default { : 0; }, repairWaivedForSelectedVehicle() { - const vehicle = this.policyVehicles.find((policyVehicle) => - policyVehicle.vin === this.selectedVehicleVin); + const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => + vehicleFromApi.vin === this.selectedVehicleVin); return vehicle?.endorsements?.includes(endorsementOptions.REPAIR_WAIVED) ?? false; }, VehiclesFromApi() { From e992673f3834c167480d306dfd40030a952737d0 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Mon, 7 Aug 2023 10:30:52 -0400 Subject: [PATCH 4/5] Revert "replace references to policyVehicles with VehiclesFromApi" This reverts commit 0cc039f15f0b29134f6ac89961409c33825875dc. --- src/layouts/policy-vehicles/policy-vehicles.vue | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index ea683c21..efd7777b 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -73,7 +73,9 @@ export default { }); }, data() { + const policyVehicles = useMainStore().pageData(issPageValues.POLICY_VEHICLES); return { + policyVehicles, selectedVehicleVin: '', displayGeneric: true, bailout: false, @@ -85,7 +87,7 @@ export default { computed: { VehiclesForQuestions() { // Map API result data, to address-vehicles data structure - const vehicles = this.VehiclesFromApi; + const vehicles = this.policyVehicles; const mappedData = vehicles?.map((v) => { const maskSymbol = 'X'; const vinStart = maskSymbol.repeat(v.vin.length - 6); @@ -101,13 +103,13 @@ export default { return mappedData; }, noCoverageForSelectedVehicle() { - const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => - vehicleFromApi.vin === this.selectedVehicleVin); + const vehicle = this.policyVehicles.find((policyVehicle) => + policyVehicle.vin === this.selectedVehicleVin); return (vehicle?.coverages?.length ?? 0) === 0; }, deductibleForSelectedVehicle() { - const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => - vehicleFromApi?.vin === this.selectedVehicleVin); + const vehicle = this.policyVehicles.find((policyVehicle) => + policyVehicle?.vin === this.selectedVehicleVin); if (!vehicle) { return undefined; } @@ -117,8 +119,8 @@ export default { : 0; }, repairWaivedForSelectedVehicle() { - const vehicle = this.VehiclesFromApi?.find((vehicleFromApi) => - vehicleFromApi.vin === this.selectedVehicleVin); + const vehicle = this.policyVehicles.find((policyVehicle) => + policyVehicle.vin === this.selectedVehicleVin); return vehicle?.endorsements?.includes(endorsementOptions.REPAIR_WAIVED) ?? false; }, VehiclesFromApi() { From ac0d99ea33889c658ae65f49bd4f30170af8b229 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Mon, 7 Aug 2023 10:50:41 -0400 Subject: [PATCH 5/5] remove reference to VehiclesFromApi --- src/layouts/policy-vehicles/policy-vehicles.vue | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index efd7777b..12747012 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -123,9 +123,6 @@ export default { policyVehicle.vin === this.selectedVehicleVin); return vehicle?.endorsements?.includes(endorsementOptions.REPAIR_WAIVED) ?? false; }, - VehiclesFromApi() { - return useMainStore().pageData(issPageValues.POLICY_VEHICLES); - }, selectedVehicle() { const vehicle = this.mainStore.lookupVehicleByVin(this.selectedVehicleVin); return vehicle; @@ -156,8 +153,8 @@ export default { } }, mounted() { - if (this.VehiclesFromApi?.length === 1) { - this.selectedVehicleVin = this.VehiclesFromApi[0].vin; + if (this.policyVehicles?.length === 1) { + this.selectedVehicleVin = this.policyVehicles[0].vin; } }, methods: