From ca31c4e8d70ccc2126392fe5c80fa10d8bc6c2d1 Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Fri, 29 Mar 2024 10:17:23 -0400 Subject: [PATCH] Part number --- src/constants/part-number-strings.js | 5 +++++ src/constants/part-type-strings.js | 1 - src/iss-components/cart-dropdown/cart-dropdown.vue | 6 +++--- 3 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 src/constants/part-number-strings.js diff --git a/src/constants/part-number-strings.js b/src/constants/part-number-strings.js new file mode 100644 index 00000000..a72684f8 --- /dev/null +++ b/src/constants/part-number-strings.js @@ -0,0 +1,5 @@ +const partNumberStrings = Object.freeze({ + RECYCLE_FEE: 'RECYCLE FEE' +}); + +export default partNumberStrings; diff --git a/src/constants/part-type-strings.js b/src/constants/part-type-strings.js index 52a3a2c7..786a069d 100644 --- a/src/constants/part-type-strings.js +++ b/src/constants/part-type-strings.js @@ -4,7 +4,6 @@ RAIN_DEFENSE: 'RAIN DEFENSE', RECALIBRATION: 'RECALIBRATION', REPLACE_FEE: 'REPLACE FEE', - RECYCLE_FEE: 'RECYCLE FEE', MOBILE_FEE: 'MOBILE FEE', REPAIR_FEE: 'REPAIR FEE' }); diff --git a/src/iss-components/cart-dropdown/cart-dropdown.vue b/src/iss-components/cart-dropdown/cart-dropdown.vue index aded2b5e..66f10dcc 100644 --- a/src/iss-components/cart-dropdown/cart-dropdown.vue +++ b/src/iss-components/cart-dropdown/cart-dropdown.vue @@ -154,6 +154,7 @@ import { getHighestFullySatisfiedTier, getPackageContents } from '@/helpers/serv // Constants import partTypeStrings from '@/constants/part-type-strings.js'; +import partNumberStrings from '@/constants/part-number-strings.js'; import widgetFields from '@/constants/cms-widget-fields.js'; const VERIFYING_COVERAGE = 'Verifying coverage'; @@ -336,16 +337,15 @@ export default { return currentPackage?.SubWidgetName ?? ''; }, - // TODO there is something weird with recycling in the backend where partType is Replace instead of recycle recycleFeeCartItem() { const recycleFeeLineItem = useMainStore().lineItems.supportingItems - ?.find((lineItem) => lineItem.partNumber === partTypeStrings.RECYCLE_FEE); + ?.find((lineItem) => lineItem.partNumber === partNumberStrings.RECYCLE_FEE); return recycleFeeLineItem ? this.getCartItem( this.getCmsContent(this.widget.recycleFee, widgetFields.TEXT_BLOCK_WIDGET.TEXT), [recycleFeeLineItem], false, - partTypeStrings.REPLACE_FEE, // TODO this is because of the awkwardness + partTypeStrings.REPLACE_FEE, // NOTE this is not a mistake false, true )