diff --git a/src/iss-components/address-questions/address-questions.spec.js b/src/iss-components/address-questions/address-questions.spec.js index f3f7ceae..a0c93388 100644 --- a/src/iss-components/address-questions/address-questions.spec.js +++ b/src/iss-components/address-questions/address-questions.spec.js @@ -143,13 +143,11 @@ describe('address-questions.vue', () => { }; // Act - autocompleteElement.dispatchEvent( - new CustomEvent('place_changed', { detail: selectedPlace }) - ); + autocompleteElement.dispatchEvent(new CustomEvent('place_changed', { detail: selectedPlace })); // Assert - wrapper.vm.$nextTick(function () { - const addressModel = wrapper.vm.addressModel; + wrapper.vm.$nextTick(() => { + const { addressModel } = wrapper.vm; expect(addressModel.streetAddress).toEqual('1234 Test Road'); expect(addressModel.city).toEqual('Columbus'); expect(addressModel.state).toEqual('OH'); @@ -169,9 +167,9 @@ describe('address-questions.vue', () => { }); const { wrapper } = setupMocks({ - querySelectorFunction: function (query) { + querySelectorFunction(query) { if (query == '.pac-container .pac-item') { - let element = document.createElement('div'); + const element = document.createElement('div'); element.textContent = '123 Test Street'; return element; } @@ -222,8 +220,8 @@ describe('address-questions.vue', () => { } }); - let noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); - let verificationAlert = wrapper.findComponent({ ref: 'alertVerificationWarning' }); + const noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); + const verificationAlert = wrapper.findComponent({ ref: 'alertVerificationWarning' }); expect(noMatchAlert.exists()).toBeFalsy(); expect(verificationAlert.exists()).toBeFalsy(); @@ -235,7 +233,7 @@ describe('address-questions.vue', () => { await wrapper.vm.$nextTick(); // Assert - const addressModel = wrapper.vm.addressModel; + const { addressModel } = wrapper.vm; expect(addressModel.streetAddress).toEqual('1234 Test Road'); expect(addressModel.city).toEqual('Columbus'); expect(addressModel.state).toEqual('OH'); @@ -245,8 +243,7 @@ describe('address-questions.vue', () => { describe('alerts', () => { const places = [null, { address_components: null }, undefined, {}]; - test.each(places)( - 'selected place/place properties is null => display verification alert', + test.each(places)('selected place/place properties is null => display verification alert', async (place) => { // Arrange const { wrapper } = setupMocks({}); @@ -259,9 +256,7 @@ describe('address-questions.vue', () => { const selectedPlace = place; // Act - autocompleteElement.dispatchEvent( - new CustomEvent('place_changed', { detail: selectedPlace }) - ); + autocompleteElement.dispatchEvent(new CustomEvent('place_changed', { detail: selectedPlace })); await wrapper.vm.$nextTick(); // Assert @@ -273,8 +268,7 @@ describe('address-questions.vue', () => { const noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); expect(noMatchAlert.exists()).toBe(false); - } - ); + }); test('user enters address that yields no autocomplete results => show noMatch alert', async () => { // Arrange @@ -318,9 +312,9 @@ describe('address-questions.vue', () => { }); const { wrapper } = setupMocks({ - querySelectorFunction: function (query) { + querySelectorFunction(query) { if (query == '.pac-container .pac-item') { - let element = document.createElement('div'); + const element = document.createElement('div'); element.textContent = '123 Test Street'; return element; } @@ -369,7 +363,7 @@ describe('address-questions.vue', () => { }); // Assert - wrapper.vm.$nextTick(function () { + wrapper.vm.$nextTick(() => { expect(wrapper.vm.displayNoMatchWarning).toBeFalsy(); noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); @@ -396,7 +390,7 @@ describe('address-questions.vue', () => { }); // Assert - wrapper.vm.$nextTick(function () { + wrapper.vm.$nextTick(() => { expect(wrapper.vm.displayNoMatchWarning).toBeFalsy(); noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); @@ -423,7 +417,7 @@ describe('address-questions.vue', () => { }); // Assert - wrapper.vm.$nextTick(function () { + wrapper.vm.$nextTick(() => { expect(wrapper.vm.displayNoMatchWarning).toBeFalsy(); noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); @@ -450,7 +444,7 @@ describe('address-questions.vue', () => { }); // Assert - wrapper.vm.$nextTick(function () { + wrapper.vm.$nextTick(() => { expect(wrapper.vm.displayNoMatchWarning).toBeFalsy(); noMatchAlert = wrapper.findComponent({ ref: 'alertNoMatchWarning' }); @@ -461,6 +455,15 @@ describe('address-questions.vue', () => { }); }); +/** + * + * @param root0 + * @param root0.mountOptions + * @param root0.props + * @param root0.isShallowMount + * @param root0.querySelectorFunction + * @param root0.geocoderResult + */ function setupMocks({ mountOptions, props, @@ -483,6 +486,10 @@ function setupMocks({ addListener: jest .fn() .mockImplementation((element, eventName, callbackFunction) => { + /** + * + * @param e + */ function interceptedCallbackFunction(e) { callbackFunction(e.detail); } diff --git a/src/iss-components/address-questions/address-questions.vue b/src/iss-components/address-questions/address-questions.vue index ff2a1872..ca89447a 100644 --- a/src/iss-components/address-questions/address-questions.vue +++ b/src/iss-components/address-questions/address-questions.vue @@ -1,26 +1,26 @@