From 2fa12be3599194bd0558badcbce17a6c5a0d4ddc Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 09:45:43 -0500 Subject: [PATCH 1/4] SSR-235 --- src/ux-components/text-link/text-link.vue | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/ux-components/text-link/text-link.vue b/src/ux-components/text-link/text-link.vue index 1e22e2b0..49d08ffb 100644 --- a/src/ux-components/text-link/text-link.vue +++ b/src/ux-components/text-link/text-link.vue @@ -11,10 +11,6 @@ {{text}} - - {{text}} - - {{text}} @@ -33,6 +29,12 @@ }, methods: { handleClick(event) { + this.pushEventToGA( + this.$route.query[this.queryStrings.ISS_PAGE], + this.GaActions.CLICKED, + this.text, + true + ); this.$emit("click-event"); }, }, @@ -41,10 +43,9 @@ \ No newline at end of file From ae4817bcf47aef2076aaf125feae85260b190795 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:12:39 -0500 Subject: [PATCH 2/4] Fix vin-location-information test affected by text-link --- .../vin-location-information.spec.js | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js b/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js index b6a5ed5d..c493fde7 100644 --- a/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js +++ b/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js @@ -2,12 +2,23 @@ import { render } from '@testing-library/vue'; import userEvent from '@testing-library/user-event'; import '@testing-library/jest-dom'; +import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import VinLocationInformationComponent from './vin-location-information.vue'; const mockText = Object.freeze({ HEADER: 'Mock Header', BODY: 'Mock Body', }); +const mockRoute = { + query: { + issPage: issPageValues.VIN_LOOKUP, + }, +}; +const mockRouter = { + navigate: jest.fn(), +}; const mountOptions = { global: { @@ -27,9 +38,22 @@ const mountOptions = { return ''; }), + pushEventToGA: jest.fn() }, + computed: { + GaActions() { + return GaActions; + }, + queryStrings() { + return queryStrings; + }, + } }, ], + mocks: { + $route: mockRoute, + $router: mockRouter, + }, }, }; From 2171f473c0e2a30366b40cb7ae5308bda7b3ae34 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:17:33 -0500 Subject: [PATCH 3/4] Fix vin-lookup test affected by text-link --- src/layouts/vin-lookup/vin-lookup.spec.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/layouts/vin-lookup/vin-lookup.spec.js b/src/layouts/vin-lookup/vin-lookup.spec.js index bdd7fbd7..894ac297 100644 --- a/src/layouts/vin-lookup/vin-lookup.spec.js +++ b/src/layouts/vin-lookup/vin-lookup.spec.js @@ -6,6 +6,8 @@ import { createTestingPinia } from '@pinia/testing'; import userEvent from '@testing-library/user-event'; import { errorMessages } from '@/constants/error-messages'; import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; import { routerParams } from '@/router/router-params'; import { useMainStore } from '@/store'; @@ -134,11 +136,18 @@ const mountOptions = { getFooterInfoBoxHeight: jest.fn(() => 80), cssClassNameForCmsWidget: jest.fn(() => 'widget-name-mock-class'), getPageNameByQueryString: jest.fn(() => ''), + pushEventToGA: jest.fn(), }, computed: { + GaActions() { + return GaActions; + }, navigationScenarios() { return navigationScenarios; }, + queryStrings() { + return queryStrings; + }, }, }, ], From 5af50be77b9fa229deb4da22fde15c6e34cfe641 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:19:37 -0500 Subject: [PATCH 4/4] Fix vehicle-lookup test affected by text-link --- src/layouts/vehicle-lookup/vehicle-lookup.spec.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js index a84b712e..12a84a88 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js +++ b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js @@ -1,6 +1,9 @@ /* eslint-env jest */ import { mount } from '@vue/test-utils'; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; +import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import VehicleLookup from './vehicle-lookup.vue'; const vinLookupMethodsMockData = { @@ -55,6 +58,12 @@ function setupMocks() { mixins: [ { computed: { + GaActions() { + return GaActions; + }, + queryStrings() { + return queryStrings; + }, navigationScenarios() { return navigationScenarios; }, @@ -80,6 +89,7 @@ function setupMocks() { }), getFooterInfoBoxHeight: jest.fn(() => 80), getPageNameByQueryString: jest.fn(() => "vehicle-lookup"), + pushEventToGA: jest.fn(), }, }, ],