From a57c6e4c49c42e31e1458c693064ef923fc0ceb1 Mon Sep 17 00:00:00 2001 From: DavidAtSafelite Date: Fri, 11 Aug 2023 07:35:54 -0400 Subject: [PATCH] Another prefer-default update --- src/constants/dynamic-strings.js | 6 +++--- src/constants/dynamictext-mapper.js | 10 ++++++---- src/constants/endorsement-options.js | 6 +++--- src/constants/error-messages.js | 6 +++--- src/constants/events.js | 8 ++++---- src/constants/experiments.js | 12 ++++++------ src/constants/global-rules.js | 4 ++-- src/constants/part-type-strings.js | 6 +++--- src/constants/query-strings.js | 6 +++--- src/constants/states.js | 6 ++++-- src/helpers/cms-content-helper.js | 2 +- src/helpers/global-rule-definer.js | 2 +- src/helpers/unit-test-helper.js | 2 +- .../address-questions/address-questions.vue | 4 ++-- src/layouts/address-vehicles/address-vehicles.vue | 2 +- .../license-plate-lookup/license-plate-lookup.vue | 4 ++-- src/layouts/policy-vehicles/policy-vehicles.spec.js | 2 +- src/layouts/policy-vehicles/policy-vehicles.vue | 2 +- .../provider-preference/provider-preference.vue | 2 +- .../shop-preference-modal/shop-preference-modal.vue | 2 +- .../steering-modal/steering-modal.vue | 2 +- .../tpa-recal-toggle/tpa-recal-toggle.spec.js | 2 +- src/layouts/service-location/service-location.vue | 2 +- .../service-zip-question/service-zip-question.vue | 2 +- .../service-package-question.vue | 3 ++- .../damage-location-question.vue | 2 +- .../side-door-options/side-door-options.vue | 2 +- src/layouts/vehicle-damage/vehicle-damage.vue | 2 +- .../windshield-options/windshield-options.vue | 2 +- src/layouts/vehicle-lookup/vehicle-lookup.spec.js | 4 ++-- .../glass-part-question/glass-part-question.vue | 4 ++-- src/layouts/vehicle-selection/vehicle-selection.vue | 2 +- .../vin-location-information.spec.js | 2 +- src/layouts/vin-lookup/vin-lookup.spec.js | 4 ++-- src/layouts/vin-lookup/vin-question/vin-question.vue | 2 +- src/layouts/welcome-page/welcome-page.vue | 4 ++-- src/mixins/analytics-mixin.js | 2 +- src/mixins/base-mixin.js | 4 ++-- 38 files changed, 73 insertions(+), 68 deletions(-) diff --git a/src/constants/dynamic-strings.js b/src/constants/dynamic-strings.js index b146b472..ffea41fc 100644 --- a/src/constants/dynamic-strings.js +++ b/src/constants/dynamic-strings.js @@ -1,10 +1,10 @@ -const dynamicStrings = { +const dynamicStrings = Object.freeze({ GLOBAL_STATE: 'globalState', CUSTOM: 'custom', ROUTER_LINK: 'routerLink:', MODAL_LINK: 'modalLink', TEXT_LINK: 'textLink', EXTERNAL_LINK: 'externalLink' -}; +}); -export { dynamicStrings }; \ No newline at end of file +export default dynamicStrings; diff --git a/src/constants/dynamictext-mapper.js b/src/constants/dynamictext-mapper.js index 26e10bbf..b9914f29 100644 --- a/src/constants/dynamictext-mapper.js +++ b/src/constants/dynamictext-mapper.js @@ -2,7 +2,7 @@ // Example: {custom:glassName}, each key in the array is the value after custom:, like 'glassname' // Please use lowercase only so that we don't have to worry about case sensitivity. -const customMappings = { +const customMappings = Object.freeze({ formattedglassname: [ { key: 'Windshield Single', transformedValue: 'windshield' }, { key: 'Windshield Driver', transformedValue: 'driver side split windshield' }, @@ -20,12 +20,12 @@ const customMappings = { { key: 'Passenger Quarter', transformedValue: 'passenger side quarter panel' }, { key: 'Passenger SlideDoor', transformedValue: 'passenger side sliding door' } ] -}; +}); // Gets an instance of a string where the dynamic portion of the text {custom:KeyName} // is replaced by a value from the above map. // If the value isn't found, return the original dynamic string without replacement -export function getCustomTransformValue(dynamicString, key) { +const getCustomTransformValue = (dynamicString, key) => { // Get array key from the dynamic string const regexExp = /{(.*?):(.*?)}/g; const matches = [...dynamicString.matchAll(regexExp)]; @@ -53,4 +53,6 @@ export function getCustomTransformValue(dynamicString, key) { const finalString = dynamicString.replace(`{custom:${arrayKey}}`, mapObject.transformedValue); return finalString; -} +}; + +export default getCustomTransformValue; diff --git a/src/constants/endorsement-options.js b/src/constants/endorsement-options.js index ab8a83af..66e5d076 100644 --- a/src/constants/endorsement-options.js +++ b/src/constants/endorsement-options.js @@ -1,9 +1,9 @@ -const endorsementOptions = { +const endorsementOptions = Object.freeze({ EDUCATOR: 'Educator', OEM_APPROVED: 'OEM Approved', FULL_GLASS: 'Full Glass Coverage', PARKING_GUARD: 'Parking Guard', REPAIR_WAIVED: 'Repair Waived' -}; +}); -export { endorsementOptions }; \ No newline at end of file +export default endorsementOptions; diff --git a/src/constants/error-messages.js b/src/constants/error-messages.js index b03dba2f..307eb8bd 100644 --- a/src/constants/error-messages.js +++ b/src/constants/error-messages.js @@ -1,4 +1,4 @@ -const errorMessages = { +const errorMessages = Object.freeze({ DAMAGE_LOCATION_REQUIRED: 'Please select damage location', DAMAGE_SIDE_REQUIRED: 'Please select vehicle side', DRIVER_SIDE_OPTIONS_REQUIRED: 'Please select window', @@ -46,6 +46,6 @@ const errorMessages = { MAKE_REQUIRED: 'Please select your vehicle make', MODEL_REQUIRED: 'Please select your vehicle model', STYLE_REQUIRED: 'Please select your vehicle style' -}; +}); -export { errorMessages }; +export default errorMessages; diff --git a/src/constants/events.js b/src/constants/events.js index dca48ac3..3f857914 100644 --- a/src/constants/events.js +++ b/src/constants/events.js @@ -1,17 +1,17 @@ -const globalEvents = { +const globalEvents = Object.freeze({ Categories: { GLOBAL_ALERT: 'GLOBAL_ALERT' }, SubCategories: { PAGE_NOT_FOUND: 'PAGE_NOT_FOUND' } -}; +}); -const globalEventTypes = { +const globalEventTypes = Object.freeze({ Success: 'alert-success', Warning: 'alert-warning', Info: 'alert-info', Danger: 'alert-danger' -}; +}); export { globalEvents, globalEventTypes }; diff --git a/src/constants/experiments.js b/src/constants/experiments.js index 37815889..a6fa86a3 100644 --- a/src/constants/experiments.js +++ b/src/constants/experiments.js @@ -1,14 +1,14 @@ -const experimentUniverses = { +const experimentUniverses = Object.freeze({ ISS_FUNNEL: 'ISSFunnel' -}; +}); -const experimentSettings = { +const experimentSettings = Object.freeze({ GOOGLE_CUSTOM_DIMENSION_INDEX: 'Google Custom Dimension Index' -}; +}); -const experimentTriggers = { +const experimentTriggers = Object.freeze({ SITE_ENTRY: 'SiteEntry', PAGE_ENTRY: 'PageEntry' -}; +}); export { experimentUniverses, experimentSettings, experimentTriggers }; diff --git a/src/constants/global-rules.js b/src/constants/global-rules.js index aa65a5da..2c086aa2 100644 --- a/src/constants/global-rules.js +++ b/src/constants/global-rules.js @@ -7,7 +7,7 @@ /** * @summary Contains all the globally defined rules. */ -const globalRules = { +const globalRules = Object.freeze({ POLICYHOLDER_FIRST_NAME_REQUIRED: 'policyholder-first-name-required', POLICYHOLDER_LAST_NAME_REQUIRED: 'policyholder-last-name-required', FIRST_NAME_REQUIRED: 'first-name-required', @@ -18,6 +18,6 @@ const globalRules = { PHONE_NUMBER_FORMAT: 'phone-number-format', PHONE_NUMBER_FORMAT_SHORT: 'phone-number-format-short', OPTION_REQUIRED: 'option-required' -}; +}); export default globalRules; diff --git a/src/constants/part-type-strings.js b/src/constants/part-type-strings.js index 8e4a4951..90c6b5dc 100644 --- a/src/constants/part-type-strings.js +++ b/src/constants/part-type-strings.js @@ -1,8 +1,8 @@ -const partTypeStrings = { +const partTypeStrings = Object.freeze({ FRONT_WIPER: 'FRONT WIPER', REAR_WIPER: 'REAR WIPER', RAIN_DEFENSE: 'RAIN DEFENSE', RECALIBRATION: 'RECALIBRATION' -}; +}); -export { partTypeStrings }; \ No newline at end of file +export default partTypeStrings; diff --git a/src/constants/query-strings.js b/src/constants/query-strings.js index 3978df89..9b486517 100644 --- a/src/constants/query-strings.js +++ b/src/constants/query-strings.js @@ -1,5 +1,5 @@ -const queryStrings = { +const queryStrings = Object.freeze({ ISS_PAGE: 'issPage' -}; +}); -export { queryStrings }; \ No newline at end of file +export default queryStrings; diff --git a/src/constants/states.js b/src/constants/states.js index e7177057..e2c263c1 100644 --- a/src/constants/states.js +++ b/src/constants/states.js @@ -1,4 +1,4 @@ -export const states = { +const states = Object.freeze({ AL: 'Alabama', AK: 'Alaska', AZ: 'Arizona', @@ -50,4 +50,6 @@ export const states = { WV: 'West Virginia', WI: 'Wisconsin', WY: 'Wyoming' -}; +}); + +export default states; diff --git a/src/helpers/cms-content-helper.js b/src/helpers/cms-content-helper.js index 4ca3523b..7ac4917b 100644 --- a/src/helpers/cms-content-helper.js +++ b/src/helpers/cms-content-helper.js @@ -1,4 +1,4 @@ -import { dynamicStrings } from '@/constants/dynamic-strings'; +import dynamicStrings from '@/constants/dynamic-strings'; import { useMainStore } from '@/store'; export function fetchCmsContentForPage(issPage) { diff --git a/src/helpers/global-rule-definer.js b/src/helpers/global-rule-definer.js index 4a33990b..5a06dad7 100644 --- a/src/helpers/global-rule-definer.js +++ b/src/helpers/global-rule-definer.js @@ -1,5 +1,5 @@ import { defineRule } from 'vee-validate'; -import { errorMessages } from '@/constants/error-messages'; +import errorMessages from '@/constants/error-messages'; import globalRules from '@/constants/global-rules'; import { required, regex } from '@/helpers/validation-rules'; diff --git a/src/helpers/unit-test-helper.js b/src/helpers/unit-test-helper.js index 01a6a286..9ec182ee 100644 --- a/src/helpers/unit-test-helper.js +++ b/src/helpers/unit-test-helper.js @@ -10,7 +10,7 @@ import { setCookieProperties } from '@/helpers/cookie-helper'; import { GaActions } from '@/constants/analytics'; -import { queryStrings } from '@/constants/query-strings'; +import queryStrings from '@/constants/query-strings'; import { useMainStore } from '@/store'; import { mapStores } from 'pinia'; import { createTestingPinia } from '@pinia/testing'; diff --git a/src/iss-components/address-questions/address-questions.vue b/src/iss-components/address-questions/address-questions.vue index 0ae33166..2c0f9501 100644 --- a/src/iss-components/address-questions/address-questions.vue +++ b/src/iss-components/address-questions/address-questions.vue @@ -95,8 +95,8 @@ import alert from '@/ux-components/alert/alert'; import applicationConfig from '@/constants/application-config.js'; import { defineRule } from 'vee-validate'; import { required, regex } from '@/helpers/validation-rules'; -import { errorMessages } from '@/constants/error-messages'; -import { states } from '@/constants/states'; +import errorMessages from '@/constants/error-messages'; +import states from '@/constants/states'; import { endpoints } from '@/constants/endpoints'; // DEFINE VALIDATION RULES diff --git a/src/layouts/address-vehicles/address-vehicles.vue b/src/layouts/address-vehicles/address-vehicles.vue index 0b26a012..3048a549 100644 --- a/src/layouts/address-vehicles/address-vehicles.vue +++ b/src/layouts/address-vehicles/address-vehicles.vue @@ -68,7 +68,7 @@ import { settleAllPromises } from '@/helpers/layout-helper'; import { useMainStore } from '@/store'; import { issPageValues } from '@/router/router-constants/issPage-values'; -import { errorMessages } from '@/constants/error-messages'; +import errorMessages from '@/constants/error-messages'; import { required } from '@/helpers/validation-rules'; import { Form, defineRule } from 'vee-validate'; import { isGlassAvailableForCarId } from '@/helpers/damage-helper'; diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index 96ab6265..088659b9 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -80,12 +80,12 @@ import { fetchCmsContentForPage } from '@/helpers/cms-content-helper'; import { settleAllPromises } from '@/helpers/layout-helper'; import { useMainStore } from '@/store'; -import { errorMessages } from '@/constants/error-messages'; +import errorMessages from '@/constants/error-messages'; import { required } from '@/helpers/validation-rules'; import { defineRule, Form } from 'vee-validate'; import { getDamageString, isGlassAvailableForCarId } from '@/helpers/damage-helper.js'; import { routerParams } from '@/router/router-params.js'; -import { states } from '@/constants/states'; +import states from '@/constants/states'; // Import Component import baseFormMixin from '@/mixins/base-form-mixin'; diff --git a/src/layouts/policy-vehicles/policy-vehicles.spec.js b/src/layouts/policy-vehicles/policy-vehicles.spec.js index 6b221d1e..03a18cdf 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.spec.js +++ b/src/layouts/policy-vehicles/policy-vehicles.spec.js @@ -7,7 +7,7 @@ import { fetchCmsContentForPage } from '@/helpers/cms-content-helper'; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; import baseMixin from '@/mixins/base-mixin'; import { getRandomString, getRandomInt } from '@/helpers/data-generation'; -import { endorsementOptions } from '@/constants/endorsement-options'; +import endorsementOptions from '@/constants/endorsement-options'; import { createTestingPinia } from '@pinia/testing'; import { issPageValues } from '@/router/router-constants/issPage-values'; import { vehicleSelectionOptions } from '@/constants/vehicle-selection-options'; diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 12747012..8cfbd451 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -51,7 +51,7 @@ import { Form } from 'vee-validate'; import BaseFormMixin from '@/mixins/base-form-mixin.js'; import { issPageValues } from '@/router/router-constants/issPage-values.js'; import { vehicleSelectionOptions } from '@/constants/vehicle-selection-options.js'; -import { endorsementOptions } from '@/constants/endorsement-options.js'; +import endorsementOptions from '@/constants/endorsement-options.js'; import globalRules from '@/constants/global-rules.js'; import { useMainStore } from '@/store/index.js'; diff --git a/src/layouts/provider-preference/provider-preference.vue b/src/layouts/provider-preference/provider-preference.vue index 6a1f15fe..081d4b84 100644 --- a/src/layouts/provider-preference/provider-preference.vue +++ b/src/layouts/provider-preference/provider-preference.vue @@ -53,7 +53,7 @@ // Import Supporting Files import { fetchCmsContentForPage, setupModalLinks } from '@/helpers/cms-content-helper'; import { settleAllPromises } from '@/helpers/layout-helper'; -import { errorMessages } from '@/constants/error-messages'; +import errorMessages from '@/constants/error-messages'; import buttonQuestion from '@/digital-components/button-question/button-question'; import { issPageValues } from '@/router/router-constants/issPage-values'; diff --git a/src/layouts/provider-preference/shop-preference-modal/shop-preference-modal.vue b/src/layouts/provider-preference/shop-preference-modal/shop-preference-modal.vue index ee1400cc..36a4e27c 100644 --- a/src/layouts/provider-preference/shop-preference-modal/shop-preference-modal.vue +++ b/src/layouts/provider-preference/shop-preference-modal/shop-preference-modal.vue @@ -23,7 +23,7 @@