From bed6a765929abc3beaae84ba713624b8d41cfb05 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Mon, 5 Jan 2026 14:29:47 -0500 Subject: [PATCH 1/7] copy change for error message --- src/constants/error-messages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/constants/error-messages.js b/src/constants/error-messages.js index 90493221..e1d23731 100644 --- a/src/constants/error-messages.js +++ b/src/constants/error-messages.js @@ -29,7 +29,7 @@ const errorMessages = Object.freeze({ VIN_FORMAT: // eslint-disable-next-line max-len 'Invalid VIN. Please make sure that you entered the correct 17-digit, alpha-numeric number. VINs do not contain the letters I, O, or Q', - OPTION_REQUIRED: 'Please select an option', + OPTION_REQUIRED: 'Please choose an option', VEHICLE_REQUIRED: 'Please select a vehicle', POLICY_NUMBER_REQUIRED: 'Policy number is required.', POLICY_NUMBER_FORMAT: 'Please enter an alpha-numeric string', From b77b40672ce86c22d6684e85b640c48fca76a527 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Thu, 8 Jan 2026 10:18:12 -0500 Subject: [PATCH 2/7] linting fixes --- src/constants/endpoints.js | 3 +-- src/store/index.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/constants/endpoints.js b/src/constants/endpoints.js index 055b56b4..cfcd501c 100644 --- a/src/constants/endpoints.js +++ b/src/constants/endpoints.js @@ -217,7 +217,6 @@ const endpoints = Object.freeze({ method: 'POST' }, DuplicateSearch: { - // eslint-disable-next-line max-len url: `${ORDER_BASE_URL}/duplicate-check`, method: 'GET' }, @@ -231,4 +230,4 @@ const endpoints = Object.freeze({ } }); -export { endpoints }; +export default endpoints; diff --git a/src/store/index.js b/src/store/index.js index 14106bf2..faac0194 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -7,7 +7,7 @@ import bailoutMessage from '@/constants/bailoutMessage'; import coverageStatuses from '@/constants/coverage-statuses'; import coverageType from '@/constants/coverage-type'; import damageLocationsSelected from '@/constants/damage-locations-selected'; -import { endpoints } from '@/constants/endpoints'; +import endpoints from '@/constants/endpoints'; import { experimentSettings, experimentTriggers, experimentUniverses } from '@/constants/experiments'; import partNumberStrings from '@/constants/part-number-strings'; import partTypeStrings from '@/constants/part-type-strings'; From 2f557137e0771f69ae691ed7397a8136dd74d132 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Thu, 8 Jan 2026 14:56:12 -0500 Subject: [PATCH 3/7] UI/copy changes WIP --- src/layouts/duplicate-check/duplicate-check.vue | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/layouts/duplicate-check/duplicate-check.vue b/src/layouts/duplicate-check/duplicate-check.vue index 6d157400..9df50bc7 100644 --- a/src/layouts/duplicate-check/duplicate-check.vue +++ b/src/layouts/duplicate-check/duplicate-check.vue @@ -107,7 +107,7 @@ export default { return this.answersFromCms?.[0]?.Name ?? ''; }, duplicateOrders() { - const duplicateOrderText = 'Finish Existing Claim'; + const duplicateOrderText = 'Finish existing claim'; const orders = useMainStore().applicationUser.duplicateOrders; return ( orders?.map((o) => { @@ -216,13 +216,11 @@ export default { .subheader-secondary { margin-top: map-get($spacers, 2); } - p { - span { - font-size: $h6-font-size; - } - } } .duplicate-check-question { + span { + font-weight:600; + } .question-text { justify-content: left; display: inline-flex !important; From 5e681ff909de17afb730e31af952bd500a829840 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 9 Jan 2026 14:02:28 -0500 Subject: [PATCH 4/7] UI updates, unit test fixes --- .../duplicate-check/duplicate-check.spec.js | 22 +-------- .../duplicate-check/duplicate-check.vue | 46 ++++++++++++++----- 2 files changed, 35 insertions(+), 33 deletions(-) diff --git a/src/layouts/duplicate-check/duplicate-check.spec.js b/src/layouts/duplicate-check/duplicate-check.spec.js index c6cce7c8..5662fe97 100644 --- a/src/layouts/duplicate-check/duplicate-check.spec.js +++ b/src/layouts/duplicate-check/duplicate-check.spec.js @@ -55,7 +55,7 @@ function getMountedComponent(mainInitialState = {}, initialData = {}, methodToRu return { wrapper }; } -const duplicateOrderText = 'Finish Existing Claim'; +const duplicateOrderText = 'Finish existing claim'; describe('duplicateCheck.vue', () => { describe('Rendering', () => { @@ -313,26 +313,6 @@ describe('duplicateCheck.vue', () => { // Assert expect(wrapper.vm.getNewOrderSelectionName).toBe(''); }); - test('answersFromCms first item has Name property => returns expected', () => { - // Arrange - const mountOptions = getMountOptions({ - router: { navigate: jest.fn() } - }); - const expectedName = getRandomString(6, 6); - const answersFromCmsValue = [{ Name: expectedName }]; - mountOptions.mixins = [{ - methods: { - getCmsContent: jest.fn().mockImplementation((_, label) => (label === 'Answers' - ? answersFromCmsValue - : '')) - } - }]; - - const wrapper = shallowMount(duplicateCheck, mountOptions); - - // Assert - expect(wrapper.vm.getNewOrderSelectionName).toBe(expectedName); - }); }); }); diff --git a/src/layouts/duplicate-check/duplicate-check.vue b/src/layouts/duplicate-check/duplicate-check.vue index 9df50bc7..c8c38623 100644 --- a/src/layouts/duplicate-check/duplicate-check.vue +++ b/src/layouts/duplicate-check/duplicate-check.vue @@ -23,11 +23,16 @@ class="duplicate-check-question" :cmsWidgetName="widget.existingOrNewQuestion" :questionText="questionText" - :answers="answers" + :answers="duplicateOrders" groupName="existingOrNewQuestionOption" buttonTypeString="listButton" isRequired :validationRules="rules.selectionRequired" /> + From 73e2bccb54abf2f753698a172ac08b9d4d55a625 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 9 Jan 2026 15:39:33 -0500 Subject: [PATCH 5/7] remove unneeded computed --- src/layouts/duplicate-check/duplicate-check.vue | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/layouts/duplicate-check/duplicate-check.vue b/src/layouts/duplicate-check/duplicate-check.vue index c8c38623..e0e892e1 100644 --- a/src/layouts/duplicate-check/duplicate-check.vue +++ b/src/layouts/duplicate-check/duplicate-check.vue @@ -107,9 +107,6 @@ export default { questionText() { return this.getCmsContent(this.widget.existingOrNewQuestion, 'QuestionText'); }, - getNewOrderSelectionName() { - return this.answersFromCms?.[0]?.Name ?? ''; - }, duplicateOrders() { const duplicateOrderText = 'Finish existing claim'; const orders = useMainStore().applicationUser.duplicateOrders; From 95c0719bccbfbc198699b9ce982066f352f19543 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 9 Jan 2026 15:59:08 -0500 Subject: [PATCH 6/7] cursor fix - remove unit tests for removed computed property --- .../duplicate-check/duplicate-check.spec.js | 55 ------------------- 1 file changed, 55 deletions(-) diff --git a/src/layouts/duplicate-check/duplicate-check.spec.js b/src/layouts/duplicate-check/duplicate-check.spec.js index 5662fe97..cebc9fb9 100644 --- a/src/layouts/duplicate-check/duplicate-check.spec.js +++ b/src/layouts/duplicate-check/duplicate-check.spec.js @@ -259,61 +259,6 @@ describe('duplicateCheck.vue', () => { }); }); }); - describe('getNewOrderSelectionName', () => { - test('answersFromCms null => returns empty string', () => { - // Arrange - const mountOptions = getMountOptions({ - router: { navigate: jest.fn() } - }); - const answersFromCmsValue = null; - mountOptions.mixins = [{ - methods: { - getCmsContent: jest.fn().mockImplementation((_, label) => (label === 'Answers' ? answersFromCmsValue : '')) - } - }]; - - const wrapper = shallowMount(duplicateCheck, mountOptions); - - // Assert - expect(wrapper.vm.getNewOrderSelectionName).toBe(''); - }); - test('answersFromCms empty list => returns empty string', () => { - // Arrange - const mountOptions = getMountOptions({ - router: { navigate: jest.fn() } - }); - const answersFromCmsValue = []; - mountOptions.mixins = [{ - methods: { - getCmsContent: jest.fn().mockImplementation((_, label) => (label === 'Answers' ? answersFromCmsValue : '')) - } - }]; - - const wrapper = shallowMount(duplicateCheck, mountOptions); - - // Assert - expect(wrapper.vm.getNewOrderSelectionName).toBe(''); - }); - test('answersFromCms non-empty list whose first item has no Name property => returns empty string', () => { - // Arrange - const mountOptions = getMountOptions({ - router: { navigate: jest.fn() } - }); - const answersFromCmsValue = [{ test: getRandomString(6, 6) }]; - mountOptions.mixins = [{ - methods: { - getCmsContent: jest.fn().mockImplementation((_, label) => (label === 'Answers' - ? answersFromCmsValue - : '')) - } - }]; - - const wrapper = shallowMount(duplicateCheck, mountOptions); - - // Assert - expect(wrapper.vm.getNewOrderSelectionName).toBe(''); - }); - }); }); describe('Navigation', () => { From a335488559e5ec34a9ba11d22b307864add3989b Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Fri, 9 Jan 2026 15:59:21 -0500 Subject: [PATCH 7/7] cursor fix --- src/store/store.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 55898656..154776b2 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -10,7 +10,7 @@ import { } from '@/helpers/data-generation.js'; import coverageStatuses from '@/constants/coverage-statuses.js'; import { paymentMethods } from '@/constants/payment-method-constants'; -import { endpoints } from '@/constants/endpoints'; +import endpoints from '@/constants/endpoints'; import { AppointmentTypeStrings } from '@/constants/schedule-constants'; import bailoutCode from '@/constants/bailoutCode'; import coverageType from '@/constants/coverage-type';