From 44225e192188a0251a54d38290cf6550e71bb0fd Mon Sep 17 00:00:00 2001 From: Kroell Date: Wed, 1 Mar 2023 15:15:13 -0500 Subject: [PATCH 01/14] update to method to check for ADAS --- .../coverage-statement/coverage-statement.vue | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/layouts/coverage-statement/coverage-statement.vue b/src/layouts/coverage-statement/coverage-statement.vue index 22dde734..bec770e0 100644 --- a/src/layouts/coverage-statement/coverage-statement.vue +++ b/src/layouts/coverage-statement/coverage-statement.vue @@ -183,16 +183,13 @@ export default { // get array of parts for vehicle let parts = useMainStore().order.lineItems.glassParts; - // loop through parts to check for ADAS - for (let part of parts) { - // if ADAS, display ADASNextSteps - if (part.requiresRecalibration) { - this.unverifiedADASNextSteps = true - } - // if non-ADAS, display NonADASNextSteps - else { - this.unverifiedNonADASNextSteps = true - } + // if ADAS, display ADASNextSteps + if (parts.filter(part => part.requiresRecalibration).length > 0) { + this.unverifiedADASNextSteps = true; + } + // if non-ADAS, display NonADASNextSteps + else { + this.unverifiedNonADASNextSteps = true; } }, stripOlTagFromCopy(copy) { From 33235224be14569bbe58f273c4481996e97b6f0c Mon Sep 17 00:00:00 2001 From: Kroell Date: Wed, 1 Mar 2023 15:46:16 -0500 Subject: [PATCH 02/14] change to damageString if >1 damage location --- src/layouts/coverage-statement/coverage-statement.vue | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/layouts/coverage-statement/coverage-statement.vue b/src/layouts/coverage-statement/coverage-statement.vue index bec770e0..a80cc341 100644 --- a/src/layouts/coverage-statement/coverage-statement.vue +++ b/src/layouts/coverage-statement/coverage-statement.vue @@ -131,10 +131,10 @@ export default { return this.getCmsContent('continueWithSchedulingCopy', 'BodyText'); }, unverifiedADASNextStepsBodyText() { - return this.getCmsContent('UnverifiedADASNextStepsWidget', 'BodyText').replaceAll("{custom:damage}", getDamageString()); + return this.getCmsContent('UnverifiedADASNextStepsWidget', 'BodyText').replaceAll("{custom:damage}", this.damageText); }, unverifiedNonADASNextStepsBodyText() { - return this.getCmsContent('UnverifiedNonADASNextStepsWidget', 'BodyText').replaceAll("{custom:damage}", getDamageString()); + return this.getCmsContent('UnverifiedNonADASNextStepsWidget', 'BodyText').replaceAll("{custom:damage}", this.damageText); }, unverifiedNonADASRepairBodyText() { return this.getCmsContent('UnverifiedNonADASRepairWidget', 'BodyText'); @@ -145,7 +145,11 @@ export default { }, arrayOfListItemsFromBodyText() { return this.getArrayOfListItemsFromRawCmsCopy(this.unverifiedADASNextStepsBodyText); - } + }, + damageText() { + var damageString = getDamageString(); + return damageString == "match" ? "" : damageString; + }, }, async beforeRouteEnter(to, from, next) { // Call APIs From dec8f048d6ae5158e702f1f35b9ca3cfe0307aa9 Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Thu, 2 Mar 2023 12:52:51 +0530 Subject: [PATCH 03/14] SSR-268 updated endpoint to get prohibited states with single source of truth --- src/constants/endpoints.js | 4 +++ .../vehicle-lookup/vehicle-lookup.spec.js | 28 +++++++++++++++++-- .../vin-lookup-methods/vin-lookup-methods.vue | 23 ++++++++++++++- src/store/index.js | 19 +++++++++++-- 4 files changed, 69 insertions(+), 5 deletions(-) diff --git a/src/constants/endpoints.js b/src/constants/endpoints.js index 36d21a69..27cc4df1 100644 --- a/src/constants/endpoints.js +++ b/src/constants/endpoints.js @@ -98,6 +98,10 @@ const endpoints = { url: "/clientauth/api/v1/clientauth/validateClientTag", method: "GET", }, + IsVinbyAddressPermissible:{ + url:"/vehicle/api/v1/vehicle/is-vin-by-address-permissible", + method:"Get", + } }; export { endpoints }; diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js index 12a84a88..11b7b309 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js +++ b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js @@ -5,6 +5,7 @@ import { issPageValues } from '@/router/router-constants/issPage-values'; import { queryStrings } from '@/constants/query-strings'; import { GaActions } from "@/constants/analytics"; import VehicleLookup from './vehicle-lookup.vue'; +import VIN_LOOKUP_METHODS from '@/constants/vin-lookup-methods'; const vinLookupMethodsMockData = { QuestionText: 'To find the right part, let’s get your VIN. Or we can look it up for you!', @@ -47,6 +48,10 @@ function setupMocks() { const mockRouter = { navigate: jest.fn(), }; + + const mockIsVinbyAddressPermissibleToBeFalse={ + IsVinbyAddressPermissible:false, + }; const wrapper = mount(VehicleLookup, { data() { @@ -95,7 +100,7 @@ function setupMocks() { ], mocks: { $route: mockRoute, - $router: mockRouter, + $router: mockRouter, }, stubs: { SiteHeader: true, @@ -105,10 +110,29 @@ function setupMocks() { }, }); - return { mockRoute, mockRouter, wrapper }; + return { mockRoute, mockRouter, wrapper,mockIsVinbyAddressPermissibleToBeFalse }; } describe('vehicle-lookup.vue', () => { + test('IsVinbyAddressPermissible to be false', () => { + const { wrapper,mockIsVinbyAddressPermissibleToBeFalse } = setupMocks(); + + const vinLookupMethodsWrapper = wrapper.findComponent({ name: 'vin-lookup-methods' }); + // Not using initializeComponent() because it doesn't trigger reactivity in test. + const Answers = JSON.parse(JSON.stringify(vinLookupMethodsMockData.Answers)); + if(!mockIsVinbyAddressPermissibleToBeFalse.IsVinbyAddressPermissible){ + Answers.splice(Answers.indexOf(VIN_LOOKUP_METHODS.homeAddress),1); + } + vinLookupMethodsWrapper.setData({ + questionTextFromCms: vinLookupMethodsMockData.QuestionText, + answersFromCms: Answers, + }); + + const lookupByAddressOptionLabel = wrapper.find('[data-test-id="vin-lookup-methods-button-question"] label[for="VinLookupMethods-HomeAddress"]'); + expect(lookupByAddressOptionLabel.exists()).toBe(false); + + }); + test('"Continue" button is disabled when no VIN Lookup method is selected.', () => { const { wrapper } = setupMocks(); diff --git a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue index e5b8bee2..706ec731 100644 --- a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue +++ b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue @@ -16,6 +16,9 @@ import { defineRule } from 'vee-validate'; import { required } from '@/helpers/validation-rules'; import { errorMessages } from '@/constants/error-messages'; +import { useMainStore } from "@/store"; +import VIN_LOOKUP_METHODS from '@/constants/vin-lookup-methods'; +import { settleAllPromises } from "@/helpers/layout-helper"; // Import Component import ButtonQuestion from '@/digital-components/button-question/button-question.vue'; @@ -38,6 +41,7 @@ export default { required, }, }, + emits: ['update:modelValue'], components: { ButtonQuestion, @@ -53,14 +57,31 @@ export default { }, }, methods: { - initializeComponent() { + async initializeComponent() { + const isVinbyAddressPermissible = await this.getIsVinbyAddressPermissible(); this.questionTextFromCms = this.getCmsContent(this.cmsWidgetName, 'QuestionText'); const answers = this.getCmsContent(this.cmsWidgetName, 'Answers'); if (Array.isArray(answers)) { + if(!isVinbyAddressPermissible){ + answers.splice(answers.indexOf(VIN_LOOKUP_METHODS.homeAddress),1); + } this.answersFromCms = answers; } }, + async getIsVinbyAddressPermissible(){ + const isVinbyAddressPermissibleResponse = useMainStore().getIsVinbyAddressPermissible(); + // Settle promises and get results + const promiseResultMap = [ + { + resultKey: "isVinbyAddressPermissible", + promise: isVinbyAddressPermissibleResponse, + } + ]; + + const resultMap = await settleAllPromises(promiseResultMap); + return resultMap.isVinbyAddressPermissible; + } }, }; diff --git a/src/store/index.js b/src/store/index.js index 19aff5c1..f08af4e8 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -298,7 +298,22 @@ export const useMainStore = defineStore({ payload: {}, }); }, - + getIsVinbyAddressPermissible(){ + try{ + const response = globalMethods.callHttpClient({ + method:endpoints.IsVinbyAddressPermissible.method, + endpoint:`${endpoints.IsVinbyAddressPermissible.url}?state=${this.order.customer.address.state}`, + payload: {}, + }); + return response; + } catch (responseError) { + return { + error: { + status: responseError.status, + }, + }; + } + }, async lookupVinByPlate(licensePlate, licenseState) { try { const response = await globalMethods.callHttpClient({ @@ -1028,7 +1043,7 @@ export const useMainStore = defineStore({ resetPartsAndDependencies() { this.resetGlassPartsState(); this.updateSupportingItems(null); - }, + }, }, persist: true }); From 742ee8eeae5c554f8598bb25a8a80d93f3376e90 Mon Sep 17 00:00:00 2001 From: sheena Date: Thu, 2 Mar 2023 16:30:01 +0530 Subject: [PATCH 04/14] SSR-277 Defect Card fixed the overlap issue --- src/digital-components/button-question/button-question.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/digital-components/button-question/button-question.vue b/src/digital-components/button-question/button-question.vue index 010eea5b..628b7c48 100644 --- a/src/digital-components/button-question/button-question.vue +++ b/src/digital-components/button-question/button-question.vue @@ -229,7 +229,7 @@ export default { .overflow-scroll { // Height will be determined by overall height of content above list - height: calc(100% - 314px); + height: calc(100% - 383px); overflow-x: hidden !important; -webkit-overflow-scrolling: touch; } From d8173d54bac7a8bbc7693674a04621f57a64221c Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 09:08:00 -0500 Subject: [PATCH 05/14] Parse modalLink in CMS --- src/constants/dynamic-strings.js | 3 ++- src/helpers/cms-content-helper.js | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/constants/dynamic-strings.js b/src/constants/dynamic-strings.js index fdadc6f1..167d72a4 100644 --- a/src/constants/dynamic-strings.js +++ b/src/constants/dynamic-strings.js @@ -2,7 +2,8 @@ const dynamicStrings = { GLOBAL_STATE: "globalState", CUSTOM: "custom", ROUTER_LINK: "routerLink:", - TEXT_LINK: "textLink:" + TEXT_LINK: "textLink:", + MODAL_LINK: "modalLink:" }; export { dynamicStrings }; \ No newline at end of file diff --git a/src/helpers/cms-content-helper.js b/src/helpers/cms-content-helper.js index 95fb1850..e1f90305 100644 --- a/src/helpers/cms-content-helper.js +++ b/src/helpers/cms-content-helper.js @@ -124,6 +124,9 @@ function processWidgetItemForReplacement(widgetModel, key) { if (widgetModel[key].includes(dynamicStrings.GLOBAL_STATE)) { widgetModel[key] = mapStringToState(widgetModel[key]); } + if (widgetModel[key].includes(dynamicStrings.MODAL_LINK)) { + widgetModel[key] = mapStringToModal(widgetModel[key]); + } return widgetModel[key]; } @@ -143,6 +146,18 @@ function processWidgetItemForReplacement(widgetModel, key) { return widgetModel[key]; } +function mapStringToModal(str) { + let startIndex = str.indexOf("{" + dynamicStrings.MODAL_LINK); + let linkToReplace = str.substring(startIndex, str.length); + linkToReplace = linkToReplace.substring(0, linkToReplace.indexOf("}") + 1); + + let params = linkToReplace.substring((dynamicStrings.MODAL_LINK).length + 1, linkToReplace.length -1) + let splitParams = params.split(","); + let BodyText = '' + splitParams[1] +'' + + return str.replace(linkToReplace, BodyText); +} + // Function to convert a string, into a matching global state item. function mapStringToState(str) { // Pull all matches out of the string. From 8b19f3045b0c59fa1a0790815aba2b2a086ee5c7 Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 09:13:37 -0500 Subject: [PATCH 06/14] remove code related to textLink (no longer using) --- src/constants/dynamic-strings.js | 1 - src/helpers/cms-content-helper.js | 4 ---- 2 files changed, 5 deletions(-) diff --git a/src/constants/dynamic-strings.js b/src/constants/dynamic-strings.js index 167d72a4..9943ba90 100644 --- a/src/constants/dynamic-strings.js +++ b/src/constants/dynamic-strings.js @@ -2,7 +2,6 @@ const dynamicStrings = { GLOBAL_STATE: "globalState", CUSTOM: "custom", ROUTER_LINK: "routerLink:", - TEXT_LINK: "textLink:", MODAL_LINK: "modalLink:" }; diff --git a/src/helpers/cms-content-helper.js b/src/helpers/cms-content-helper.js index e1f90305..0de5b265 100644 --- a/src/helpers/cms-content-helper.js +++ b/src/helpers/cms-content-helper.js @@ -200,10 +200,6 @@ export function doesCopyContainRouterLink(copy) { return copy.includes(this.dynamicStrings.ROUTER_LINK); } -export function doesCopyContainTextLink(copy) { - return copy.includes(this.dynamicStrings.TEXT_LINK); -} - export function splitCopyOnCMSPlaceHolder(copy) { // splits copy on { ... } such as {routerlink: ...} return copy.split(/{(.*?)}/g); From aa48a73e2b7de4ca9655ad68cd5701fc6efddfed Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 09:22:58 -0500 Subject: [PATCH 07/14] update coverage-statement page to use modalLink --- src/helpers/cms-content-helper.js | 6 +- .../coverage-statement/coverage-statement.vue | 102 ++++-------------- 2 files changed, 23 insertions(+), 85 deletions(-) diff --git a/src/helpers/cms-content-helper.js b/src/helpers/cms-content-helper.js index 0de5b265..30255527 100644 --- a/src/helpers/cms-content-helper.js +++ b/src/helpers/cms-content-helper.js @@ -151,11 +151,11 @@ function mapStringToModal(str) { let linkToReplace = str.substring(startIndex, str.length); linkToReplace = linkToReplace.substring(0, linkToReplace.indexOf("}") + 1); - let params = linkToReplace.substring((dynamicStrings.MODAL_LINK).length + 1, linkToReplace.length -1) + let params = linkToReplace.substring((dynamicStrings.MODAL_LINK).length + 2, linkToReplace.length -1) let splitParams = params.split(","); - let BodyText = '' + splitParams[1] +'' + let bodyText = '' + splitParams[1] +'' - return str.replace(linkToReplace, BodyText); + return str.replace(linkToReplace, bodyText); } // Function to convert a string, into a matching global state item. diff --git a/src/layouts/coverage-statement/coverage-statement.vue b/src/layouts/coverage-statement/coverage-statement.vue index a80cc341..3aaa0ebd 100644 --- a/src/layouts/coverage-statement/coverage-statement.vue +++ b/src/layouts/coverage-statement/coverage-statement.vue @@ -18,45 +18,12 @@
+ >
-
-
    -
  1. - - - - -
    2. -
-
-
-
-
-
+
part.requiresRecalibration).length > 0) { + return this.unverifiedADASNextStepsBodyText; + } + // if non-ADAS, display NonADASNextSteps + else { + return this.unverifiedNonADASNextStepsBodyText; + } + } + }, continueWithSchedulingBodyText() { return this.getCmsContent('continueWithSchedulingCopy', 'BodyText'); }, @@ -139,13 +107,6 @@ export default { unverifiedNonADASRepairBodyText() { return this.getCmsContent('UnverifiedNonADASRepairWidget', 'BodyText'); }, - splitADASCoverageStatementCopy() { - // Splits content when brackets are found in text so that text can be looped through and text-link can be injected when needed - return this.splitCopyOnCMSPlaceHolder(this.unverifiedADASNextStepsBodyText); - }, - arrayOfListItemsFromBodyText() { - return this.getArrayOfListItemsFromRawCmsCopy(this.unverifiedADASNextStepsBodyText); - }, damageText() { var damageString = getDamageString(); return damageString == "match" ? "" : damageString; @@ -183,29 +144,6 @@ export default { */ this.$router.navigate(this.navigationScenarios.CLICKED_BACK, this.$route); }, - displayReplaceCoverageStatement() { - // get array of parts for vehicle - let parts = useMainStore().order.lineItems.glassParts; - - // if ADAS, display ADASNextSteps - if (parts.filter(part => part.requiresRecalibration).length > 0) { - this.unverifiedADASNextSteps = true; - } - // if non-ADAS, display NonADASNextSteps - else { - this.unverifiedNonADASNextSteps = true; - } - }, - stripOlTagFromCopy(copy) { - const regex = /(?:)|(?:<\/ol>)/g; - return copy.replace(regex, ""); - }, - getArrayOfListItemsFromRawCmsCopy(copy) { - const withoutOlTags = this.stripOlTagFromCopy(copy); - return withoutOlTags - .split(/(?:)|(?:<\/li>)/g) - .filter((lineItem) => lineItem); - }, }, async forwardButtonAction() {}, resetDependentState() {}, From 93084e5adea53bdfbb31a36b68c952fc70367520 Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 09:24:39 -0500 Subject: [PATCH 08/14] typo --- src/layouts/coverage-statement/coverage-statement.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/layouts/coverage-statement/coverage-statement.vue b/src/layouts/coverage-statement/coverage-statement.vue index 3aaa0ebd..7778c6e6 100644 --- a/src/layouts/coverage-statement/coverage-statement.vue +++ b/src/layouts/coverage-statement/coverage-statement.vue @@ -61,7 +61,6 @@ import { import { settleAllPromises } from '@/helpers/layout-helper'; import { getDamageString } from '@/helpers/damage-helper.js'; import { useMainStore } from "@/store"; -import { throwStatement, tSMethodSignature } from '@babel/types'; export default { name: 'coverage-statement', From 1ed1561598dc8f0464813d5b52cd982c27de26b1 Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Thu, 2 Mar 2023 20:34:07 +0530 Subject: [PATCH 09/14] SSR - 268 update naming conventions --- src/layouts/vehicle-lookup/vehicle-lookup.spec.js | 4 ++-- src/layouts/vehicle-lookup/vehicle-lookup.vue | 8 ++++---- .../vin-lookup-methods/vin-lookup-methods.vue | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js index 11b7b309..e86a57d1 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js +++ b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js @@ -5,7 +5,7 @@ import { issPageValues } from '@/router/router-constants/issPage-values'; import { queryStrings } from '@/constants/query-strings'; import { GaActions } from "@/constants/analytics"; import VehicleLookup from './vehicle-lookup.vue'; -import VIN_LOOKUP_METHODS from '@/constants/vin-lookup-methods'; +import vinLookupMethods from '@/constants/vin-lookup-methods'; const vinLookupMethodsMockData = { QuestionText: 'To find the right part, let’s get your VIN. Or we can look it up for you!', @@ -121,7 +121,7 @@ describe('vehicle-lookup.vue', () => { // Not using initializeComponent() because it doesn't trigger reactivity in test. const Answers = JSON.parse(JSON.stringify(vinLookupMethodsMockData.Answers)); if(!mockIsVinbyAddressPermissibleToBeFalse.IsVinbyAddressPermissible){ - Answers.splice(Answers.indexOf(VIN_LOOKUP_METHODS.homeAddress),1); + Answers.splice(Answers.indexOf(vinLookupMethods.homeAddress),1); } vinLookupMethodsWrapper.setData({ questionTextFromCms: vinLookupMethodsMockData.QuestionText, diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.vue b/src/layouts/vehicle-lookup/vehicle-lookup.vue index 34124672..768cc21d 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.vue +++ b/src/layouts/vehicle-lookup/vehicle-lookup.vue @@ -38,7 +38,7 @@ import { fetchCmsContentForPage } from '@/helpers/cms-content-helper'; import { settleAllPromises } from '@/helpers/layout-helper'; import { Form } from 'vee-validate'; import BaseFormMixin from '@/mixins/base-form-mixin'; -import VIN_LOOKUP_METHODS from '@/constants/vin-lookup-methods'; +import constVinLookupMethods from '@/constants/vin-lookup-methods'; // Import Component import SiteFooter from '@/iss-components/site-footer/site-footer.vue'; @@ -98,13 +98,13 @@ export default { }, forwardButtonAction() { switch (this.selectedVinLookupMethod) { - case VIN_LOOKUP_METHODS.manualVin: + case constVinLookupMethods.manualVin: this.$router.navigate(this.navigationScenarios.SELECTED_MANUAL_VIN, this.$route); break; - case VIN_LOOKUP_METHODS.licensePlate: + case constVinLookupMethods.licensePlate: this.$router.navigate(this.navigationScenarios.SELECTED_LICENSE_PLATE, this.$route); break; - case VIN_LOOKUP_METHODS.homeAddress: + case constVinLookupMethods.homeAddress: this.$router.navigate(this.navigationScenarios.SELECTED_HOME_ADDRESS, this.$route); break; default: diff --git a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue index 706ec731..5d3fc77e 100644 --- a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue +++ b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue @@ -17,7 +17,7 @@ import { defineRule } from 'vee-validate'; import { required } from '@/helpers/validation-rules'; import { errorMessages } from '@/constants/error-messages'; import { useMainStore } from "@/store"; -import VIN_LOOKUP_METHODS from '@/constants/vin-lookup-methods'; +import vinLookupMethods from '@/constants/vin-lookup-methods'; import { settleAllPromises } from "@/helpers/layout-helper"; // Import Component @@ -64,7 +64,7 @@ export default { const answers = this.getCmsContent(this.cmsWidgetName, 'Answers'); if (Array.isArray(answers)) { if(!isVinbyAddressPermissible){ - answers.splice(answers.indexOf(VIN_LOOKUP_METHODS.homeAddress),1); + answers.splice(answers.indexOf(vinLookupMethods.homeAddress),1); } this.answersFromCms = answers; } From ed405fd19bf2bca49dd75c3559cab7f44139c49c Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Thu, 2 Mar 2023 20:58:48 +0530 Subject: [PATCH 10/14] updated vinlookupmethod constant updated vin lookup method constant file --- src/constants/vin-lookup-methods.js | 10 +++++----- src/layouts/vehicle-lookup/vehicle-lookup.spec.js | 4 ++-- src/layouts/vehicle-lookup/vehicle-lookup.vue | 8 ++++---- .../vin-lookup-methods/vin-lookup-methods.vue | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/constants/vin-lookup-methods.js b/src/constants/vin-lookup-methods.js index a12f29eb..ce2f2859 100644 --- a/src/constants/vin-lookup-methods.js +++ b/src/constants/vin-lookup-methods.js @@ -1,7 +1,7 @@ -const VIN_LOOKUP_METHODS = Object.freeze({ - manualVin: 'ManualVin', - licensePlate: 'LicensePlate', - homeAddress: 'HomeAddress', +const vinLookupMethodSelections = Object.freeze({ + MANUALVIN: 'ManualVin', + LICENSEPLATE: 'LicensePlate', + HOMEADDRESS: 'HomeAddress', }); -export default VIN_LOOKUP_METHODS; +export {vinLookupMethodSelections}; diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js index e86a57d1..491adc70 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js +++ b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js @@ -5,7 +5,7 @@ import { issPageValues } from '@/router/router-constants/issPage-values'; import { queryStrings } from '@/constants/query-strings'; import { GaActions } from "@/constants/analytics"; import VehicleLookup from './vehicle-lookup.vue'; -import vinLookupMethods from '@/constants/vin-lookup-methods'; +import {vinLookupMethodSelections} from '@/constants/vin-lookup-methods'; const vinLookupMethodsMockData = { QuestionText: 'To find the right part, let’s get your VIN. Or we can look it up for you!', @@ -121,7 +121,7 @@ describe('vehicle-lookup.vue', () => { // Not using initializeComponent() because it doesn't trigger reactivity in test. const Answers = JSON.parse(JSON.stringify(vinLookupMethodsMockData.Answers)); if(!mockIsVinbyAddressPermissibleToBeFalse.IsVinbyAddressPermissible){ - Answers.splice(Answers.indexOf(vinLookupMethods.homeAddress),1); + Answers.splice(Answers.indexOf(vinLookupMethodSelections.HOMEADDRESS),1); } vinLookupMethodsWrapper.setData({ questionTextFromCms: vinLookupMethodsMockData.QuestionText, diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.vue b/src/layouts/vehicle-lookup/vehicle-lookup.vue index 768cc21d..4f16ccd5 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.vue +++ b/src/layouts/vehicle-lookup/vehicle-lookup.vue @@ -38,7 +38,7 @@ import { fetchCmsContentForPage } from '@/helpers/cms-content-helper'; import { settleAllPromises } from '@/helpers/layout-helper'; import { Form } from 'vee-validate'; import BaseFormMixin from '@/mixins/base-form-mixin'; -import constVinLookupMethods from '@/constants/vin-lookup-methods'; +import {vinLookupMethodSelections} from '@/constants/vin-lookup-methods'; // Import Component import SiteFooter from '@/iss-components/site-footer/site-footer.vue'; @@ -98,13 +98,13 @@ export default { }, forwardButtonAction() { switch (this.selectedVinLookupMethod) { - case constVinLookupMethods.manualVin: + case vinLookupMethodSelections.MANUALVIN: this.$router.navigate(this.navigationScenarios.SELECTED_MANUAL_VIN, this.$route); break; - case constVinLookupMethods.licensePlate: + case vinLookupMethodSelections.LICENSEPLATE: this.$router.navigate(this.navigationScenarios.SELECTED_LICENSE_PLATE, this.$route); break; - case constVinLookupMethods.homeAddress: + case vinLookupMethodSelections.HOMEADDRESS: this.$router.navigate(this.navigationScenarios.SELECTED_HOME_ADDRESS, this.$route); break; default: diff --git a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue index 5d3fc77e..392dbdfa 100644 --- a/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue +++ b/src/layouts/vehicle-lookup/vin-lookup-methods/vin-lookup-methods.vue @@ -17,7 +17,7 @@ import { defineRule } from 'vee-validate'; import { required } from '@/helpers/validation-rules'; import { errorMessages } from '@/constants/error-messages'; import { useMainStore } from "@/store"; -import vinLookupMethods from '@/constants/vin-lookup-methods'; +import {vinLookupMethodSelections} from '@/constants/vin-lookup-methods'; import { settleAllPromises } from "@/helpers/layout-helper"; // Import Component @@ -64,7 +64,7 @@ export default { const answers = this.getCmsContent(this.cmsWidgetName, 'Answers'); if (Array.isArray(answers)) { if(!isVinbyAddressPermissible){ - answers.splice(answers.indexOf(vinLookupMethods.homeAddress),1); + answers.splice(answers.indexOf(vinLookupMethodSelections.HOMEADDRESS),1); } this.answersFromCms = answers; } From aa56529089af9c3ae34dd652482f777adc6f1432 Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 11:14:13 -0500 Subject: [PATCH 11/14] typo fix --- src/constants/dynamic-strings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/constants/dynamic-strings.js b/src/constants/dynamic-strings.js index 9943ba90..b81c0f30 100644 --- a/src/constants/dynamic-strings.js +++ b/src/constants/dynamic-strings.js @@ -2,7 +2,7 @@ const dynamicStrings = { GLOBAL_STATE: "globalState", CUSTOM: "custom", ROUTER_LINK: "routerLink:", - MODAL_LINK: "modalLink:" + MODAL_LINK: "modalLink" }; export { dynamicStrings }; \ No newline at end of file From a14908206618b7528a84e4d0810ac6d113773534 Mon Sep 17 00:00:00 2001 From: Kroell Date: Thu, 2 Mar 2023 11:14:27 -0500 Subject: [PATCH 12/14] set default for carrier name in store --- src/store/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index 19aff5c1..42bc530d 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -98,7 +98,7 @@ const getDefaultState = () => { triggeredSiteEntry: false, }, issConfig: { - clientName: "", + clientName: "Carrier", // this is the default and will be overriden by the client's name styleSheet: "", accountNumber: 0, } From fb3dd18a33f2549e30fb7351b0c8f9631f665719 Mon Sep 17 00:00:00 2001 From: Kroell Date: Fri, 3 Mar 2023 08:19:43 -0500 Subject: [PATCH 13/14] renamed default value in store --- src/store/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index 42bc530d..a0483873 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -98,7 +98,7 @@ const getDefaultState = () => { triggeredSiteEntry: false, }, issConfig: { - clientName: "Carrier", // this is the default and will be overriden by the client's name + clientName: "Generic Insurance", // this is the default and will be overriden by the client's name styleSheet: "", accountNumber: 0, } From 6496fff524fc6e2109dbd8708a6bd4a2ae7db84b Mon Sep 17 00:00:00 2001 From: Kroell Date: Fri, 3 Mar 2023 11:26:56 -0500 Subject: [PATCH 14/14] placeholder for provider-preference page --- .../provider-preference.vue | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 src/layouts/provider-preference/provider-preference.vue diff --git a/src/layouts/provider-preference/provider-preference.vue b/src/layouts/provider-preference/provider-preference.vue new file mode 100644 index 00000000..6e8c2067 --- /dev/null +++ b/src/layouts/provider-preference/provider-preference.vue @@ -0,0 +1,69 @@ + + \ No newline at end of file