From 93ec6050d8c42d2365115fc7ec090c78b7d67280 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Tue, 30 Apr 2024 17:01:02 -0400 Subject: [PATCH] PR feedback updates --- src/constants/bailoutCode.js | 3 ++- src/constants/bailoutMessage.js | 8 ++++++-- src/layouts/vehicle-damage/vehicle-damage.vue | 2 +- src/layouts/vin-lookup/vin-lookup.vue | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/constants/bailoutCode.js b/src/constants/bailoutCode.js index 402f207e..0753da70 100644 --- a/src/constants/bailoutCode.js +++ b/src/constants/bailoutCode.js @@ -9,7 +9,8 @@ const bailoutCode = Object.freeze({ TPANotEnabled: 7, RequestCallback: 8, HeavyTruckVehicle: 9, - PartDBError: 10 + NoPartsAvailable: 10, + PartsServiceError: 11 }); export default bailoutCode; diff --git a/src/constants/bailoutMessage.js b/src/constants/bailoutMessage.js index 0eb7ea25..2dbbcfe6 100644 --- a/src/constants/bailoutMessage.js +++ b/src/constants/bailoutMessage.js @@ -53,8 +53,12 @@ const bailoutMessage = Object.freeze({ code: bailoutCode.HeavyTruckVehicle, message: `User selected a heavy truck vehicle. Car ID: ${carId} ` }), - PartDBError: (error) => ({ - code: bailoutCode.PartDBError, + NoPartsAvailable: () => ({ + code: bailoutCode.NoPartsAvailable, + message: 'No parts were returned' + }), + PartsServiceError: (error) => ({ + code: bailoutCode.PartsServiceError, message: `An error occurred in getPartsOrQuestions. Error: ${getItemData(error)}` }) }); diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index 6d7a8715..b756523e 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -433,7 +433,7 @@ export default { const partsOrQuestionsResponse = await this.getPartsOrQuestions(); if (partsOrQuestionsResponse.error) { - this.mainStore.setBailout(bailoutMessage.PartDBError(partsOrQuestionsResponse.error.data)); + this.mainStore.setBailout(bailoutMessage.PartsServiceError(partsOrQuestionsResponse.error.data)); window.console.error('Error on retrieving PartsOrQuestions'); this.$refs.siteFooter.removeLoader(); this.hasBailedOut = true; diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index 4bebbe13..5517b3ac 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -266,7 +266,7 @@ export default { const partsOrQuestionsResponse = await this.getPartsOrQuestions(); if (partsOrQuestionsResponse.error) { - this.mainStore.setBailout(bailoutMessage.PartDBError(partsOrQuestionsResponse.error.data)); + this.mainStore.setBailout(bailoutMessage.PartsServiceError(partsOrQuestionsResponse.error.data)); window.console.error('Error on retrieving PartsOrQuestions'); this.$refs.siteFooter.removeLoader(); this.hasBailedOut = true;