From 19e48b61cb71284ca40e9893fae125e939fe6b8d Mon Sep 17 00:00:00 2001 From: Alex Humphries Date: Tue, 21 Jul 2026 14:47:24 -0400 Subject: [PATCH 1/5] INSR-10446: Update policy number/member number handling - When using member number, holds on to policy number from lookup for later use in claim registration --- src/store/index.js | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index e0d32e74..a131748c 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -118,7 +118,8 @@ export const getDefaultState = () => ({ cvrgEndorsementCode: null, status: null, policyData: null, - policyLookupErrorCode: 0 + policyLookupErrorCode: 0, + memberNumber: null }, customer: { address: { @@ -587,7 +588,7 @@ export const useMainStore = defineStore({ }; // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name if (this.issConfig.useMemberNumber) { - payload.memberNumber = policy.policyNumber; + payload.memberNumber = policy.memberNumber ?? policy.policyNumber; } const response = await globalMethods.callHttpClient({ method: endpoints.CoveragePolicyInfo.method, @@ -617,6 +618,13 @@ export const useMainStore = defineStore({ // populate additional fields order.policy.policyData = responsePolicy.policyData; + if (this.issConfig.useMemberNumber) { + if (!order.policy.memberNumber) { + // We only do this once, otherwise we would overwrite the member number with the policy number on subsequent lookups. + order.policy.memberNumber = order.policy.policyNumber; + } + order.policy.policyNumber = responsePolicy.policyNumber; + } // populate vehicles order.policy.vehicles = responsePolicy.vehicles ?? []; @@ -716,7 +724,7 @@ export const useMainStore = defineStore({ }; // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name if (this.issConfig.useMemberNumber) { - payload.memberNumber = this.order.policy.policyNumber; + payload.memberNumber = this.order.policy.memberNumber ?? this.order.policy.policyNumber; } await updateClientSpecificFieldsForClaimRegistration(payload, this.order); const response = await globalMethods.callHttpClient({ @@ -777,7 +785,7 @@ export const useMainStore = defineStore({ }; // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name if (this.issConfig.useMemberNumber) { - payload.memberNumber = this.order.policy.policyNumber; + payload.memberNumber = this.order.policy.memberNumber ?? this.order.policy.policyNumber; } try { @@ -1827,6 +1835,7 @@ export const useMainStore = defineStore({ order.policy.isDamageGlassOnly = data?.policy?.isDamageGlassOnly; order.policy.policyNumber = data?.policy?.policyNumber; order.policy.policyZipCode = data?.policy?.policyZipCode; + order.policy.memberNumber = data?.policy?.memberNumber; order.referralNumber = data?.referralNumber; order.referralDate = data?.referralDate; @@ -2207,6 +2216,7 @@ export const useMainStore = defineStore({ this.order.policy.policyLookupErrorCode = 0; this.order.policy.deductible.repair = null; this.order.policy.deductible.replace = null; + this.order.policy.memberNumber = null; }, resetPayment() { From 6a7d6f401c312dfd383adaa3062783cbf1323135 Mon Sep 17 00:00:00 2001 From: Alex Humphries Date: Tue, 21 Jul 2026 15:14:27 -0400 Subject: [PATCH 2/5] INSR-10446: More member number adjustments - Clarify some comments - Add a unit test - Remove field from loading session until its saving properly --- src/store/index.js | 9 ++++----- src/store/store.spec.js | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index a131748c..9d23d112 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -586,7 +586,7 @@ export const useMainStore = defineStore({ referralCorrelationId: order.referralCorrelationId, referralNumber: order.referralNumber }; - // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name + // Clients (i.e. USAA) may sometimes use member number in addition to a policy number if (this.issConfig.useMemberNumber) { payload.memberNumber = policy.memberNumber ?? policy.policyNumber; } @@ -620,7 +620,7 @@ export const useMainStore = defineStore({ order.policy.policyData = responsePolicy.policyData; if (this.issConfig.useMemberNumber) { if (!order.policy.memberNumber) { - // We only do this once, otherwise we would overwrite the member number with the policy number on subsequent lookups. + // We capture the member number (entered as policy number) once, so we don't overwrite it with returned policy number on subsequent lookups order.policy.memberNumber = order.policy.policyNumber; } order.policy.policyNumber = responsePolicy.policyNumber; @@ -722,7 +722,7 @@ export const useMainStore = defineStore({ fleetNumber: this.order.vehicle.fleetNumber, fleetUnitNumber: this.order.vehicle.fleetUnitNumber }; - // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name + // Clients (i.e. USAA) may sometimes use member number in addition to a policy number if (this.issConfig.useMemberNumber) { payload.memberNumber = this.order.policy.memberNumber ?? this.order.policy.policyNumber; } @@ -783,7 +783,7 @@ export const useMainStore = defineStore({ policyData: this.order.policy.policyData, isItac: this.isITAC }; - // Clients (i.e. USAA) may sometimes use member number, which is just policy number by a different name + // Clients (i.e. USAA) may sometimes use member number in addition to a policy number if (this.issConfig.useMemberNumber) { payload.memberNumber = this.order.policy.memberNumber ?? this.order.policy.policyNumber; } @@ -1835,7 +1835,6 @@ export const useMainStore = defineStore({ order.policy.isDamageGlassOnly = data?.policy?.isDamageGlassOnly; order.policy.policyNumber = data?.policy?.policyNumber; order.policy.policyZipCode = data?.policy?.policyZipCode; - order.policy.memberNumber = data?.policy?.memberNumber; order.referralNumber = data?.referralNumber; order.referralDate = data?.referralDate; diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 78345ff4..c52ee6cf 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -1496,6 +1496,30 @@ describe('Store', () => { }) })); }); + it('useMemberNumber is true => member number set and policy number changed after response', async () => { + // Arrange + const originalPolicyNumber = getRandomString(6, 6); + store.order.policy.policyNumber = originalPolicyNumber; + const returnedPolicyNumber = getRandomString(6, 6); + const responseNoPolicies = { + data: { + policies: [{ + policyNumber: returnedPolicyNumber + }] + } + }; + store.issConfig.isCoverageEnabled = true; + store.applicationUser.coverageLookupAttempts = 0; + store.issConfig.useMemberNumber = true; + globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(responseNoPolicies)); + + // Act + await store.getCoveragePolicyInfo(); + + // Asserts + expect(store.order.policy.memberNumber).toBe(originalPolicyNumber); + expect(store.order.policy.policyNumber).toBe(returnedPolicyNumber); + }) it('null response by api => insuranceCoverage.coverageType is NONE', async () => { // Arrange store.issConfig.isCoverageEnabled = true; From f81895f768f67e1858cff417f09df1f43e05cede Mon Sep 17 00:00:00 2001 From: Alex Humphries Date: Tue, 21 Jul 2026 15:24:42 -0400 Subject: [PATCH 3/5] INSR-10446: More robust polcy number reassignment and related test --- src/store/index.js | 4 +++- src/store/store.spec.js | 11 +++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index 9d23d112..623d7963 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -623,7 +623,9 @@ export const useMainStore = defineStore({ // We capture the member number (entered as policy number) once, so we don't overwrite it with returned policy number on subsequent lookups order.policy.memberNumber = order.policy.policyNumber; } - order.policy.policyNumber = responsePolicy.policyNumber; + if (responsePolicy.policyNumber != null) { + order.policy.policyNumber = responsePolicy.policyNumber; + } } // populate vehicles diff --git a/src/store/store.spec.js b/src/store/store.spec.js index c52ee6cf..b74610a1 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -1519,6 +1519,17 @@ describe('Store', () => { // Asserts expect(store.order.policy.memberNumber).toBe(originalPolicyNumber); expect(store.order.policy.policyNumber).toBe(returnedPolicyNumber); + + // Act again + await store.getCoveragePolicyInfo(); + + // Assert again + expect(globalMethods.callHttpClient).toHaveBeenNthCalledWith(2, expect.objectContaining({ + payload: expect.objectContaining({ + policyNumber: returnedPolicyNumber, + memberNumber: originalPolicyNumber + }) + })); }) it('null response by api => insuranceCoverage.coverageType is NONE', async () => { // Arrange From 196dc7962cb635674fc5c075cdda0868c9409450 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 21 Jul 2026 19:34:55 +0000 Subject: [PATCH 4/5] INSR-10446: Fix remaining review nits in store spec --- src/store/store.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index b74610a1..b4846792 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -1520,7 +1520,7 @@ describe('Store', () => { expect(store.order.policy.memberNumber).toBe(originalPolicyNumber); expect(store.order.policy.policyNumber).toBe(returnedPolicyNumber); - // Act again + // Act again await store.getCoveragePolicyInfo(); // Assert again @@ -1530,7 +1530,7 @@ describe('Store', () => { memberNumber: originalPolicyNumber }) })); - }) + }); it('null response by api => insuranceCoverage.coverageType is NONE', async () => { // Arrange store.issConfig.isCoverageEnabled = true; From 61c408d784863c430c9addc52c24423269c7fc8d Mon Sep 17 00:00:00 2001 From: AHumphriesSL Date: Tue, 21 Jul 2026 15:37:21 -0400 Subject: [PATCH 5/5] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/store/store.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index b4846792..a443e9b9 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -1501,7 +1501,7 @@ describe('Store', () => { const originalPolicyNumber = getRandomString(6, 6); store.order.policy.policyNumber = originalPolicyNumber; const returnedPolicyNumber = getRandomString(6, 6); - const responseNoPolicies = { + const responseWithPolicy = { data: { policies: [{ policyNumber: returnedPolicyNumber @@ -1511,7 +1511,7 @@ describe('Store', () => { store.issConfig.isCoverageEnabled = true; store.applicationUser.coverageLookupAttempts = 0; store.issConfig.useMemberNumber = true; - globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(responseNoPolicies)); + globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve(responseWithPolicy)); // Act await store.getCoveragePolicyInfo();