From 550a1c836342e996087aed61572c0129875ec37b Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 14:55:37 -0500 Subject: [PATCH 1/8] Replacing most issConfig parent account numbers with order ones --- src/store/index.js | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index c9192a98..fbb2b5fb 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -565,6 +565,10 @@ export const useMainStore = defineStore({ this.updateCoverageType(coverageType.Deductible); const insured = responsePolicy.insureds?.[0]; + // populate parent account number + // todo confirm that this is the right policy + order.parentAccountNumber = responsePolicy.parentAccountNumber; + // populate policy holder details from policy lookup order.customer.address.streetAddress = insured?.address; order.customer.address.city = insured?.city; @@ -694,7 +698,7 @@ export const useMainStore = defineStore({ endpoint: endpoints.FinalDeductible.url, payload: { referralCorrelationId: this.order.referralCorrelationId, - accountNumber: this.issConfig.parentAccountNumber?.toString() ?? '', + accountNumber: this.order.parentAccountNumber?.toString() ?? '', endorsements: endorsementAnswersForPayload, manualGlassNames: manualGlassNamesArray, policyState: this.order.customer.address.state, @@ -722,7 +726,7 @@ export const useMainStore = defineStore({ getDuplicateReferrals() { const params = new URLSearchParams({ - parentAccountNumber: this.issConfig.parentAccountNumber, + parentAccountNumber: this.order.parentAccountNumber, customerPhoneNumber: this.order.contactInfo.servicePhone, policyNumber: this.order.policy.policyNumber, emailAddress: this.order.customer.emailAddress, @@ -879,7 +883,7 @@ export const useMainStore = defineStore({ endDate, applicationName: applicationConfig.APPLICATION_NAME, billToAccountNumber: this.billToAccountNumber, - parentAccountNumber: this.issConfig.parentAccountNumber, // this.payment.parentAccountNumber, + parentAccountNumber: order.parentAccountNumber, // this.payment.parentAccountNumber, carId: vehicle.carId, lineItems, glassPieces, @@ -943,7 +947,7 @@ export const useMainStore = defineStore({ shopAppointmentType, applicationName: applicationConfig.APPLICATION_NAME, billToAccountNumber: this.billToAccountNumber, - parentAccountNumber: this.issConfig.parentAccountNumber, // this.payment.parentAccountNumber, + parentAccountNumber: this.order.parentAccountNumber, // this.payment.parentAccountNumber, carId: vehicle.carId, lineItems, glassPieces, @@ -1007,7 +1011,7 @@ export const useMainStore = defineStore({ getProviders(serviceZipCode) { const { carId } = this.order.vehicle; const damageType = this.damage.isRepair ? 'Repair' : 'Replace'; - const { parentAccountNumber } = this.issConfig; + const { parentAccountNumber } = this.order; const partsWithRecal = getTopLevelGlassPartsWithRecal(this.order.lineItems.glassParts); const windshieldPartWithRecal = partsWithRecal?.length > 0 ? partsWithRecal[0] : null; const safeliteOnly = true; @@ -1026,7 +1030,7 @@ export const useMainStore = defineStore({ getTpaProviders(zipCode, radius) { const { carId } = this.order.vehicle; const damageType = this.damage.isRepair ? 'Repair' : 'Replace'; - const { parentAccountNumber } = this.issConfig; + const { parentAccountNumber } = this.order; const partsWithRecal = getTopLevelGlassPartsWithRecal(this.order.lineItems.glassParts); const windshieldPartWithRecal = partsWithRecal?.length > 0 ? partsWithRecal[0] : null; const safeliteOnly = false; @@ -1047,7 +1051,7 @@ export const useMainStore = defineStore({ return new Promise((resolve, reject) => { globalMethods.callHttpClient({ method: endpoints.GetAccountInfo.method, - endpoint: endpoints.GetAccountInfo.url + this.issConfig.parentAccountNumber + endpoint: endpoints.GetAccountInfo.url + this.order.parentAccountNumber }).then((response) => { this.order.carrierPhoneNumber = response.data.phoneNumber; return resolve(response.data); @@ -1130,6 +1134,7 @@ export const useMainStore = defineStore({ endpoint: `${endpoints.GetGlassFees.url}?${params.toString()}${partNumberListQueryString}` }); }, + // TODO do we even use this anymore? async getSupportingItems() { const { glassParts } = this.lineItems; const { carId } = this.vehicle; @@ -1458,7 +1463,7 @@ export const useMainStore = defineStore({ claimNumber: insuranceCoverage.claimNumber }, payment: { - parentAccountNumber: this.issConfig.parentAccountNumber, + parentAccountNumber: this.order.payment.parentAccountNumber, billToAccountNumber: this.billToAccountNumber, paypalToken: payment.paypalToken, paymentMethod: payment.paymentMethod === paymentMethods.PayNow ? null : payment.paymentMethod, @@ -1556,6 +1561,7 @@ export const useMainStore = defineStore({ payload: { referralNumber: duplicate.referralNumber, referralDate: duplicate.responseDate, + // TODO confirm this is right to use here parentAccountNumber: issConfig.parentAccountNumber, referralCorrelationId: duplicate.correlationId } @@ -2649,7 +2655,7 @@ export const useMainStore = defineStore({ const { order, issConfig } = this; try { const params = new URLSearchParams({ - parentAccountNumber: issConfig.parentAccountNumber.toString(), + parentAccountNumber: order.parentAccountNumber.toString(), providerNumber: this.providerNumber, typeOfClaim: 'GLASS ONLY', lineOfBusiness: 'PERSONAL', From 48eaebc9b52119384314650522ae1692440a3415 Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 14:57:58 -0500 Subject: [PATCH 2/8] Missed one --- src/store/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index fbb2b5fb..55d0b1d7 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -610,7 +610,7 @@ export const useMainStore = defineStore({ payload: { referralCorrelationId: this.order.referralCorrelationId, - accountNumber: this.issConfig.parentAccountNumber?.toString() ?? '', + accountNumber: this.order.parentAccountNumber?.toString() ?? '', policyData: this.order.policy.policyData, isItac: isITAC, insured: { From b253d3d78eeac297aa9b05696fba4975264d777c Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 15:42:50 -0500 Subject: [PATCH 3/8] Just spacing --- src/layouts/entry-page/entry-page.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/entry-page/entry-page.vue b/src/layouts/entry-page/entry-page.vue index 2abbb5a0..455e6c6f 100644 --- a/src/layouts/entry-page/entry-page.vue +++ b/src/layouts/entry-page/entry-page.vue @@ -70,7 +70,7 @@ export default { } if (clientData.parameters?.length > 0) { - const finalParams = this.combineClientParameters(clientData.parameters, {...queryStringParams, ...decryptedParams}); + const finalParams = this.combineClientParameters(clientData.parameters, { ...queryStringParams, ...decryptedParams }); this.populateStoreItemsFromParams(finalParams); } From 7e5938510e8ccd20ca53d3ae29257c74ab5bacae Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 16:08:47 -0500 Subject: [PATCH 4/8] Using order parent account number --- src/store/index.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 55d0b1d7..221888a2 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -1554,15 +1554,14 @@ export const useMainStore = defineStore({ }); }, async loadSession(duplicate) { - const { order, issConfig } = this; + const { order } = this; const response = await globalMethods.callHttpClient({ method: endpoints.LoadSession.method, endpoint: endpoints.LoadSession.url, payload: { referralNumber: duplicate.referralNumber, referralDate: duplicate.responseDate, - // TODO confirm this is right to use here - parentAccountNumber: issConfig.parentAccountNumber, + parentAccountNumber: order.parentAccountNumber, referralCorrelationId: duplicate.correlationId } }); From d9c6139b21f0f1ce792901eecf71fd8658790dc9 Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 16:22:43 -0500 Subject: [PATCH 5/8] fixing response policy account number name --- src/store/index.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 221888a2..6abb1775 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -566,8 +566,7 @@ export const useMainStore = defineStore({ const insured = responsePolicy.insureds?.[0]; // populate parent account number - // todo confirm that this is the right policy - order.parentAccountNumber = responsePolicy.parentAccountNumber; + order.parentAccountNumber = responsePolicy.accountNumber; // populate policy holder details from policy lookup order.customer.address.streetAddress = insured?.address; From da5ec8d8e92a092fa2f8e1f9b6994d181c840719 Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 16:27:33 -0500 Subject: [PATCH 6/8] Removing comment --- src/store/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index 6abb1775..0be3f3e9 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -1133,7 +1133,6 @@ export const useMainStore = defineStore({ endpoint: `${endpoints.GetGlassFees.url}?${params.toString()}${partNumberListQueryString}` }); }, - // TODO do we even use this anymore? async getSupportingItems() { const { glassParts } = this.lineItems; const { carId } = this.vehicle; From 61737998846205ee2b95515c6cf8800146f3da4e Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Mon, 25 Nov 2024 17:05:05 -0500 Subject: [PATCH 7/8] Fixing tests --- src/store/index.js | 2 +- src/store/store.spec.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 0be3f3e9..5b7a8bce 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -1461,7 +1461,7 @@ export const useMainStore = defineStore({ claimNumber: insuranceCoverage.claimNumber }, payment: { - parentAccountNumber: this.order.payment.parentAccountNumber, + parentAccountNumber: this.order.parentAccountNumber, billToAccountNumber: this.billToAccountNumber, paypalToken: payment.paypalToken, paymentMethod: payment.paymentMethod === paymentMethods.PayNow ? null : payment.paymentMethod, diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 69242242..c53fa5ac 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -844,7 +844,7 @@ describe('Store', () => { it('calls api with expected payment', async () => { // Arrange const parentAccountNumber = getRandomString(6, 6); - store.issConfig.parentAccountNumber = parentAccountNumber; + store.order.parentAccountNumber = parentAccountNumber; globalMethods.callHttpClient = jest.fn().mockReturnValue(Promise.resolve({})); // Act @@ -1740,7 +1740,7 @@ describe('Store', () => { const policyData = getRandomString(100, 200); store.order.referralCorrelationId = referralCorrelationId; - store.issConfig.parentAccountNumber = parentAccountNumber; + store.order.parentAccountNumber = parentAccountNumber; store.order.currentDeductible = currentDeductible; store.order.originalDeductible = originalDeductible; store.order.policy.status = status; @@ -1837,7 +1837,7 @@ describe('Store', () => { const policyData = getRandomString(100, 200); store.order.referralCorrelationId = referralCorrelationId; - store.issConfig.parentAccountNumber = parentAccountNumber; + store.order.parentAccountNumber = parentAccountNumber; store.order.currentDeductible = currentDeductible; store.order.originalDeductible = originalDeductible; store.order.policy.status = status; @@ -1939,7 +1939,7 @@ describe('Store', () => { const carId = getRandomString(10, 14); const parentAccountNumber = getRandomString(6, 6); - store.issConfig.parentAccountNumber = parentAccountNumber; + store.order.parentAccountNumber = parentAccountNumber; store.order.damage.isRepair = isRepair; store.order.vehicle.carId = carId; const zipCode = getRandomString(6, 6); From f1df4cc69a79411457c2462838b3b0b8cde88df0 Mon Sep 17 00:00:00 2001 From: Michaela Brydon Date: Tue, 26 Nov 2024 13:33:42 -0500 Subject: [PATCH 8/8] If value truthy then set --- src/store/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/store/index.js b/src/store/index.js index 5b7a8bce..373a38b7 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -566,7 +566,9 @@ export const useMainStore = defineStore({ const insured = responsePolicy.insureds?.[0]; // populate parent account number - order.parentAccountNumber = responsePolicy.accountNumber; + if (responsePolicy.accountNumber) { + order.parentAccountNumber = responsePolicy.accountNumber; + } // populate policy holder details from policy lookup order.customer.address.streetAddress = insured?.address;