From 70c46a8cd56b5b42e8dfa3d099edfbd78850db8e Mon Sep 17 00:00:00 2001
From: Kulbhushan Kaushik <kulbhushan.kaushik@safelite.com>
Date: Wed, 21 Sep 2022 08:00:24 -0400
Subject: [PATCH] code review changes

---
 src/constants/store-actions.js            |  9 +--------
 src/layouts/vehicle-make/vehicle-make.vue |  1 -
 src/main.js                               |  5 ++---
 src/router/index.js                       |  1 -
 src/store/index.js                        | 20 ++++++++++----------
 5 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/src/constants/store-actions.js b/src/constants/store-actions.js
index 9ca8f586..7912446a 100644
--- a/src/constants/store-actions.js
+++ b/src/constants/store-actions.js
@@ -27,7 +27,7 @@ const storeActions = {
     VALIDATE_ZIP: "validateZip",
     CLEAR_VIN: "clearVin",
 
-     // VEHICLE MUTATIONS
+     // VEHICLE Actions
      UPDATE_YEAR: "updateYear",
      UPDATE_MAKE: "updateMake",
      UPDATE_MODEL: "updateModel",
@@ -40,13 +40,6 @@ const storeActions = {
      UPDATE_VEHICLE_VIN: "updateVehicleVin",
      UPDATE_VEHICLE: "updateVehicle",
 
-     UPDATE_LAST_PAGE_VISITED: "updateLastPageVisited",
-   
-  
-    // DEPENDENCY MUTATIONS
-    
-    // SAVE COMPONENT STATE
-
   };
   
   export { storeActions };
diff --git a/src/layouts/vehicle-make/vehicle-make.vue b/src/layouts/vehicle-make/vehicle-make.vue
index 105bec84..cb13bd16 100644
--- a/src/layouts/vehicle-make/vehicle-make.vue
+++ b/src/layouts/vehicle-make/vehicle-make.vue
@@ -8,7 +8,6 @@
 </template>
 
 <script>
-    import { issStore } from "@/store/index";
     import { storeActions } from "@/constants/store-actions";
     export default {
         name: 'vehicle-make',
diff --git a/src/main.js b/src/main.js
index 44a9ca20..74f6b847 100644
--- a/src/main.js
+++ b/src/main.js
@@ -4,14 +4,13 @@ import App from './App.vue';
 import router from './router';
 import "../node_modules/bootstrap/dist/js/bootstrap.js";
 import piniaPluginPersistedstate from 'pinia-plugin-persistedstate';
-import { issStore } from './store';
+import { useMainStore } from './store';
 
 const vueApp = createApp(App);
 const pinia = createPinia();
 pinia.use(piniaPluginPersistedstate);
 vueApp.use(pinia);
-const store = issStore();
-vueApp.config.globalProperties.$store = store;
+vueApp.config.globalProperties.$store = useMainStore();
 vueApp.use(router);
 vueApp.mount("#app");
 
diff --git a/src/router/index.js b/src/router/index.js
index 7a1f608f..2cb551af 100644
--- a/src/router/index.js
+++ b/src/router/index.js
@@ -2,7 +2,6 @@ import { createWebHistory, createRouter } from "vue-router";
 import { lazyLoadComponent } from "./dynamic-routing/component-loader";
 import { endpoints } from "../constants/mock-endpoints";
 import globalMethods from "@/global-methods";
-import { storeActions } from "../constants/store-actions";
 
 const routes = [
     {
diff --git a/src/store/index.js b/src/store/index.js
index 7b6e17ae..b35f1ab9 100644
--- a/src/store/index.js
+++ b/src/store/index.js
@@ -3,8 +3,8 @@ import { endpoints } from "@/constants/endpoints.js";
 import globalMethods from "@/global-methods";
 import { storeActions } from "@/constants/store-actions";
 
-export const issStore = defineStore({
-    id: 'issStore',
+export const useMainStore = defineStore({
+    id: 'main',
     state()  {
       return {
         order: {
@@ -66,20 +66,20 @@ export const issStore = defineStore({
     getters: {},
     actions:
     {
-      updateYear(state, year) {
-        state.order.vehicle.year = year;
+      updateYear(year) {
+        this.order.vehicle.year = year;
       },
-      updateMake(state, make) {
-        state.order.vehicle.make = make;
+      updateMake(make) {
+        this.order.vehicle.make = make;
       },
-      updateModel(state, model) {
-        state.order.vehicle.model = model;
+      updateModel(model) {
+        this.order.vehicle.model = model;
       },
       // Vehicle
       saveVehicleYear(year) 
       {
-          if (this.$state.order.vehicle.year !== year) {
-            this.updateYear(this.$state,year);
+          if (this.order.vehicle.year !== year) {
+            this.updateYear(year);
           }
       },
     },