From 8ab98384252da62bbaa33efc6dc0864c3376ecc0 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Fri, 20 Jan 2023 15:30:32 -0500 Subject: [PATCH 01/12] SSR-199 --- .../base-input-button/base-input-button.vue | 2 +- .../button-functionality-props.js | 0 .../button-question/button-question.spec.js | 2 +- .../button-question/button-question.vue | 0 .../dropdown-question/dropdown-question.spec.js | 0 .../dropdown-question/dropdown-question.vue | 0 .../modal/modal.spec.js | 0 .../modal/modal.vue | 0 .../question-chain/question-chain.spec.js | 2 +- .../question-chain/question-chain.vue | 2 +- .../text-block/text-block.spec.js | 0 .../text-block/text-block.vue | 0 .../textbox-question/textbox-question.spec.js | 0 .../textbox-question/textbox-question.vue | 0 .../address-questions/address-questions.spec.js | 2 +- .../address-questions/address-questions.vue | 4 ++-- .../button-question-modal.spec.js | 0 .../button-question-modal.vue | 2 +- .../loading-modal/loading-modal.spec.js | 0 .../loading-modal/loading-modal.vue | 0 .../nav-button/nav-button.spec.js | 0 .../nav-button/nav-button.vue | 0 .../questions-page-layout.spec.js | 2 +- .../questions-page-layout.vue | 12 ++++++------ .../site-footer/site-footer.spec.js | 0 .../site-footer/site-footer.vue | 0 .../site-header/menu-modal/menu-modal.spec.js | 0 .../site-header/menu-modal/menu-modal.vue | 0 .../site-header/site-header.spec.js | 2 +- .../site-header/site-header.vue | 2 +- .../button-back/button-back.spec.js | 0 .../site-sub-header/button-back/button-back.vue | 0 .../site-sub-header/site-sub-header.spec.js | 2 +- .../site-sub-header/site-sub-header.vue | 2 +- .../vehicle-banner/vehicle-banner.spec.js | 0 .../vehicle-banner/vehicle-banner.vue | 0 src/layouts/address-lookup/address-lookup.vue | 10 +++++----- .../customer-questions/customer-questions.vue | 4 ++-- src/layouts/address-vehicles/address-vehicles.vue | 8 ++++---- .../capability-questions/capability-questions.vue | 8 ++++---- .../coverage-statement/coverage-statement.vue | 8 ++++---- .../license-plate-lookup/license-plate-lookup.vue | 10 +++++----- .../molding-questions/molding-questions.vue | 8 ++++---- src/layouts/part-questions/part-questions.vue | 2 +- .../policy-holder-details.vue | 10 +++++----- .../damage-location-question.vue | 2 +- .../replace-options-question.vue | 2 +- .../side-door-options/side-door-options.vue | 2 +- src/layouts/vehicle-damage/vehicle-damage.vue | 8 ++++---- .../windshield-chip-count-question.vue | 2 +- .../windshield-damage-type-question.vue | 2 +- src/layouts/vehicle-lookup/vehicle-lookup.vue | 8 ++++---- .../vin-lookup-methods/vin-lookup-methods.vue | 2 +- .../vehicle-make/make-question/make-question.vue | 2 +- src/layouts/vehicle-make/vehicle-make.vue | 8 ++++---- .../model-question/model-question.vue | 2 +- src/layouts/vehicle-model/vehicle-model.vue | 8 ++++---- .../glass-part-question/glass-part-question.vue | 2 +- src/layouts/vehicle-parts/vehicle-parts.vue | 8 ++++---- .../style-question/style-question.vue | 2 +- src/layouts/vehicle-style/vehicle-style.vue | 8 ++++---- src/layouts/vehicle-year/vehicle-year.vue | 8 ++++---- .../vehicle-year/year-question/year-question.vue | 2 +- src/layouts/vin-lookup/vin-lookup.vue | 8 ++++---- .../vin-lookup/vin-question/vin-question.vue | 2 +- src/layouts/welcome-page/welcome-page.vue | 14 +++++++------- src/mixins/input-button-wrapper-mixin.js | 2 +- .../list-button-horizontal.vue | 2 +- src/ux-components/list-button/list-button.vue | 2 +- src/ux-components/list-card/list-card.vue | 2 +- 70 files changed, 108 insertions(+), 108 deletions(-) rename src/{common-components => digital-components}/base-input-button/base-input-button.vue (98%) rename src/{common-components => digital-components}/base-input-button/button-functionality-props.js (100%) rename src/{common-components => digital-components}/button-question/button-question.spec.js (99%) rename src/{common-components => digital-components}/button-question/button-question.vue (100%) rename src/{common-components => digital-components}/dropdown-question/dropdown-question.spec.js (100%) rename src/{common-components => digital-components}/dropdown-question/dropdown-question.vue (100%) rename src/{common-components => digital-components}/modal/modal.spec.js (100%) rename src/{common-components => digital-components}/modal/modal.vue (100%) rename src/{common-components => digital-components}/question-chain/question-chain.spec.js (99%) rename src/{common-components => digital-components}/question-chain/question-chain.vue (98%) rename src/{common-components => digital-components}/text-block/text-block.spec.js (100%) rename src/{common-components => digital-components}/text-block/text-block.vue (100%) rename src/{common-components => digital-components}/textbox-question/textbox-question.spec.js (100%) rename src/{common-components => digital-components}/textbox-question/textbox-question.vue (100%) rename src/{common-components => iss-components}/address-questions/address-questions.spec.js (99%) rename src/{common-components => iss-components}/address-questions/address-questions.vue (98%) rename src/{common-components => iss-components}/button-question-modal/button-question-modal.spec.js (100%) rename src/{common-components => iss-components}/button-question-modal/button-question-modal.vue (98%) rename src/{common-components => iss-components}/loading-modal/loading-modal.spec.js (100%) rename src/{common-components => iss-components}/loading-modal/loading-modal.vue (100%) rename src/{common-components => iss-components}/nav-button/nav-button.spec.js (100%) rename src/{common-components => iss-components}/nav-button/nav-button.vue (100%) rename src/{common-components => iss-components}/questions-page-layout/questions-page-layout.spec.js (98%) rename src/{common-components => iss-components}/questions-page-layout/questions-page-layout.vue (87%) rename src/{common-components => iss-components}/site-footer/site-footer.spec.js (100%) rename src/{common-components => iss-components}/site-footer/site-footer.vue (100%) rename src/{common-components => iss-components}/site-header/menu-modal/menu-modal.spec.js (100%) rename src/{common-components => iss-components}/site-header/menu-modal/menu-modal.vue (100%) rename src/{common-components => iss-components}/site-header/site-header.spec.js (88%) rename src/{common-components => iss-components}/site-header/site-header.vue (97%) rename src/{common-components => iss-components}/site-sub-header/button-back/button-back.spec.js (100%) rename src/{common-components => iss-components}/site-sub-header/button-back/button-back.vue (100%) rename src/{common-components => iss-components}/site-sub-header/site-sub-header.spec.js (88%) rename src/{common-components => iss-components}/site-sub-header/site-sub-header.vue (95%) rename src/{common-components => iss-components}/vehicle-banner/vehicle-banner.spec.js (100%) rename src/{common-components => iss-components}/vehicle-banner/vehicle-banner.vue (100%) diff --git a/src/common-components/base-input-button/base-input-button.vue b/src/digital-components/base-input-button/base-input-button.vue similarity index 98% rename from src/common-components/base-input-button/base-input-button.vue rename to src/digital-components/base-input-button/base-input-button.vue index f67ead49..8768bb8c 100644 --- a/src/common-components/base-input-button/base-input-button.vue +++ b/src/digital-components/base-input-button/base-input-button.vue @@ -30,7 +30,7 @@ import { handleButtonComponentFocus, handleInputComponentBlur, } from "@/helpers/button-question-focus-helper"; -import { inputButtonProps } from "@/common-components/base-input-button/button-functionality-props"; +import { inputButtonProps } from "@/digital-components/base-input-button/button-functionality-props"; export default { name: "base-input-button", diff --git a/src/common-components/base-input-button/button-functionality-props.js b/src/digital-components/base-input-button/button-functionality-props.js similarity index 100% rename from src/common-components/base-input-button/button-functionality-props.js rename to src/digital-components/base-input-button/button-functionality-props.js diff --git a/src/common-components/button-question/button-question.spec.js b/src/digital-components/button-question/button-question.spec.js similarity index 99% rename from src/common-components/button-question/button-question.spec.js rename to src/digital-components/button-question/button-question.spec.js index b958da8c..427faa99 100644 --- a/src/common-components/button-question/button-question.spec.js +++ b/src/digital-components/button-question/button-question.spec.js @@ -1,5 +1,5 @@ import { shallowMount } from "@vue/test-utils"; -import buttonQuestion from "@/common-components/button-question/button-question"; +import buttonQuestion from "@/digital-components/button-question/button-question"; import { getMountOptions } from "@/helpers/unit-test-helper.js"; describe("buttonQuestion.vue", () => { diff --git a/src/common-components/button-question/button-question.vue b/src/digital-components/button-question/button-question.vue similarity index 100% rename from src/common-components/button-question/button-question.vue rename to src/digital-components/button-question/button-question.vue diff --git a/src/common-components/dropdown-question/dropdown-question.spec.js b/src/digital-components/dropdown-question/dropdown-question.spec.js similarity index 100% rename from src/common-components/dropdown-question/dropdown-question.spec.js rename to src/digital-components/dropdown-question/dropdown-question.spec.js diff --git a/src/common-components/dropdown-question/dropdown-question.vue b/src/digital-components/dropdown-question/dropdown-question.vue similarity index 100% rename from src/common-components/dropdown-question/dropdown-question.vue rename to src/digital-components/dropdown-question/dropdown-question.vue diff --git a/src/common-components/modal/modal.spec.js b/src/digital-components/modal/modal.spec.js similarity index 100% rename from src/common-components/modal/modal.spec.js rename to src/digital-components/modal/modal.spec.js diff --git a/src/common-components/modal/modal.vue b/src/digital-components/modal/modal.vue similarity index 100% rename from src/common-components/modal/modal.vue rename to src/digital-components/modal/modal.vue diff --git a/src/common-components/question-chain/question-chain.spec.js b/src/digital-components/question-chain/question-chain.spec.js similarity index 99% rename from src/common-components/question-chain/question-chain.spec.js rename to src/digital-components/question-chain/question-chain.spec.js index 64260ddf..e0e2fb15 100644 --- a/src/common-components/question-chain/question-chain.spec.js +++ b/src/digital-components/question-chain/question-chain.spec.js @@ -1,5 +1,5 @@ import { shallowMount } from "@vue/test-utils"; -import questionChain from "@/common-components/question-chain/question-chain.vue"; +import questionChain from "@/digital-components/question-chain/question-chain.vue"; import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { nextTick } from "vue"; diff --git a/src/common-components/question-chain/question-chain.vue b/src/digital-components/question-chain/question-chain.vue similarity index 98% rename from src/common-components/question-chain/question-chain.vue rename to src/digital-components/question-chain/question-chain.vue index 11874670..c66d4dcd 100644 --- a/src/common-components/question-chain/question-chain.vue +++ b/src/digital-components/question-chain/question-chain.vue @@ -17,7 +17,7 @@ \ No newline at end of file + + \ No newline at end of file From b13b80de237330ed83ccd3313e5b918601313c45 Mon Sep 17 00:00:00 2001 From: Kulbhushan Kaushik Date: Mon, 23 Jan 2023 08:35:36 -0500 Subject: [PATCH 05/12] commit --- .../address-questions/address-questions.vue | 13 +++++++++++++ .../policy-holder-details/policy-holder-details.vue | 3 ++- src/store/index.js | 2 ++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/iss-components/address-questions/address-questions.vue b/src/iss-components/address-questions/address-questions.vue index 96ec7f97..b05d1c94 100644 --- a/src/iss-components/address-questions/address-questions.vue +++ b/src/iss-components/address-questions/address-questions.vue @@ -31,6 +31,17 @@ @keydown.enter.prevent /> +
+
+ +
+
@@ -98,12 +109,14 @@ export default { type: Object, default: () => ({ streetAddress: "", + streetAddress2: "", city: "", state: "", zipCode: "", }), }, validationRules: String, + includeStreetAddress2:false, }, data() { return { diff --git a/src/layouts/policy-holder-details/policy-holder-details.vue b/src/layouts/policy-holder-details/policy-holder-details.vue index 5efbf5a7..68d9249a 100644 --- a/src/layouts/policy-holder-details/policy-holder-details.vue +++ b/src/layouts/policy-holder-details/policy-holder-details.vue @@ -28,7 +28,7 @@ validationRules="last-name-required" />
- + { customer: { address: { streetAddress: null, + streetAddress2: null, city: null, state: null, zipCode: null, @@ -668,6 +669,7 @@ export const useMainStore = defineStore({ updatePolicyHolderDetails(customerQuestions) { this.order.customer.address.streetAddress = customerQuestions.addressQuestions.streetAddress; + this.order.customer.address.streetAddress2 = customerQuestions.addressQuestions.streetAddress2; this.order.customer.address.city = customerQuestions.addressQuestions.city; this.order.customer.address.state = customerQuestions.addressQuestions.state; this.order.customer.address.zipCode = customerQuestions.addressQuestions.zipCode; From 2fa12be3599194bd0558badcbce17a6c5a0d4ddc Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 09:45:43 -0500 Subject: [PATCH 06/12] SSR-235 --- src/ux-components/text-link/text-link.vue | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/ux-components/text-link/text-link.vue b/src/ux-components/text-link/text-link.vue index 1e22e2b0..49d08ffb 100644 --- a/src/ux-components/text-link/text-link.vue +++ b/src/ux-components/text-link/text-link.vue @@ -11,10 +11,6 @@ {{text}} - - {{text}} - - {{text}} @@ -33,6 +29,12 @@ }, methods: { handleClick(event) { + this.pushEventToGA( + this.$route.query[this.queryStrings.ISS_PAGE], + this.GaActions.CLICKED, + this.text, + true + ); this.$emit("click-event"); }, }, @@ -41,10 +43,9 @@ \ No newline at end of file From ae4817bcf47aef2076aaf125feae85260b190795 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:12:39 -0500 Subject: [PATCH 07/12] Fix vin-location-information test affected by text-link --- .../vin-location-information.spec.js | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js b/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js index b6a5ed5d..c493fde7 100644 --- a/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js +++ b/src/layouts/vin-lookup/vin-location-information/vin-location-information.spec.js @@ -2,12 +2,23 @@ import { render } from '@testing-library/vue'; import userEvent from '@testing-library/user-event'; import '@testing-library/jest-dom'; +import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import VinLocationInformationComponent from './vin-location-information.vue'; const mockText = Object.freeze({ HEADER: 'Mock Header', BODY: 'Mock Body', }); +const mockRoute = { + query: { + issPage: issPageValues.VIN_LOOKUP, + }, +}; +const mockRouter = { + navigate: jest.fn(), +}; const mountOptions = { global: { @@ -27,9 +38,22 @@ const mountOptions = { return ''; }), + pushEventToGA: jest.fn() }, + computed: { + GaActions() { + return GaActions; + }, + queryStrings() { + return queryStrings; + }, + } }, ], + mocks: { + $route: mockRoute, + $router: mockRouter, + }, }, }; From 2171f473c0e2a30366b40cb7ae5308bda7b3ae34 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:17:33 -0500 Subject: [PATCH 08/12] Fix vin-lookup test affected by text-link --- src/layouts/vin-lookup/vin-lookup.spec.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/layouts/vin-lookup/vin-lookup.spec.js b/src/layouts/vin-lookup/vin-lookup.spec.js index bdd7fbd7..894ac297 100644 --- a/src/layouts/vin-lookup/vin-lookup.spec.js +++ b/src/layouts/vin-lookup/vin-lookup.spec.js @@ -6,6 +6,8 @@ import { createTestingPinia } from '@pinia/testing'; import userEvent from '@testing-library/user-event'; import { errorMessages } from '@/constants/error-messages'; import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; import { routerParams } from '@/router/router-params'; import { useMainStore } from '@/store'; @@ -134,11 +136,18 @@ const mountOptions = { getFooterInfoBoxHeight: jest.fn(() => 80), cssClassNameForCmsWidget: jest.fn(() => 'widget-name-mock-class'), getPageNameByQueryString: jest.fn(() => ''), + pushEventToGA: jest.fn(), }, computed: { + GaActions() { + return GaActions; + }, navigationScenarios() { return navigationScenarios; }, + queryStrings() { + return queryStrings; + }, }, }, ], From 5af50be77b9fa229deb4da22fde15c6e34cfe641 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 10:19:37 -0500 Subject: [PATCH 09/12] Fix vehicle-lookup test affected by text-link --- src/layouts/vehicle-lookup/vehicle-lookup.spec.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js index a84b712e..12a84a88 100644 --- a/src/layouts/vehicle-lookup/vehicle-lookup.spec.js +++ b/src/layouts/vehicle-lookup/vehicle-lookup.spec.js @@ -1,6 +1,9 @@ /* eslint-env jest */ import { mount } from '@vue/test-utils'; import { navigationScenarios } from '@/router/router-constants/navigation-scenarios'; +import { issPageValues } from '@/router/router-constants/issPage-values'; +import { queryStrings } from '@/constants/query-strings'; +import { GaActions } from "@/constants/analytics"; import VehicleLookup from './vehicle-lookup.vue'; const vinLookupMethodsMockData = { @@ -55,6 +58,12 @@ function setupMocks() { mixins: [ { computed: { + GaActions() { + return GaActions; + }, + queryStrings() { + return queryStrings; + }, navigationScenarios() { return navigationScenarios; }, @@ -80,6 +89,7 @@ function setupMocks() { }), getFooterInfoBoxHeight: jest.fn(() => 80), getPageNameByQueryString: jest.fn(() => "vehicle-lookup"), + pushEventToGA: jest.fn(), }, }, ], From f0cae00486b5d418ab579046de43f57f669e929b Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 11:12:34 -0500 Subject: [PATCH 10/12] SSR-236 --- src/digital-components/text-block/text-block.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/digital-components/text-block/text-block.vue b/src/digital-components/text-block/text-block.vue index a12d3f39..33854e14 100644 --- a/src/digital-components/text-block/text-block.vue +++ b/src/digital-components/text-block/text-block.vue @@ -1,6 +1,6 @@ From abc5889b0ce313c4418ec17ed277b126a8ec4d70 Mon Sep 17 00:00:00 2001 From: Johan Gunawan Date: Mon, 23 Jan 2023 12:50:14 -0500 Subject: [PATCH 11/12] SSR-237 --- .../button-question/button-question.vue | 481 +++++++++--------- 1 file changed, 241 insertions(+), 240 deletions(-) diff --git a/src/digital-components/button-question/button-question.vue b/src/digital-components/button-question/button-question.vue index 82f402e0..9b610437 100644 --- a/src/digital-components/button-question/button-question.vue +++ b/src/digital-components/button-question/button-question.vue @@ -1,76 +1,79 @@