From 5481bac095530d828a6be292072f914d4201cead Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Tue, 6 Jun 2023 13:26:37 -0400 Subject: [PATCH 01/26] WIP --- src/layouts/policy-vehicles/policy-vehicles.vue | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index a85cc583..be5f17dc 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -8,7 +8,7 @@
- + Date: Tue, 6 Jun 2023 18:04:21 -0400 Subject: [PATCH 02/26] display correct vehicle image WIP --- .../policy-vehicles/policy-vehicles.vue | 56 ++++++++++++++++--- 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index be5f17dc..42144ec4 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -50,9 +50,13 @@ export default { mixins: [BaseFormMixin], data() { return { - selectedVehicleVin: "", - bailout: false - } + selectedVehicleVin: "", + displayGeneric: false, + bailout: false + } + }, + mounted() { + useMainStore().resetVehicleState(); }, async beforeRouteEnter(to, from, next) { @@ -146,10 +150,48 @@ export default { VehiclesFromApi() { return useMainStore().pageData(issPageValues.POLICY_VEHICLES); }, - displayGeneric() { - return this.selectedVehicleVin && !this.selectedStyle; - } - }, + selectedVehicle() { + const vehicle = this.mainStore.lookupVehicleByVin(this.selectedVehicleVin); + return vehicle; + }, + //displayGeneric() { + // const selectedVehicle = useMainStore().lookupVehicleByVin(this.selectedVehicleVin); + // const styleOptions = this.mainStore.getVehicleStyles( + // selectedVehicle.year, + // selectedVehicle.make, + // selectedVehicle.model, + // ); + + + // const styleOptions = this.selectedVehicle.style; + + // if (styleOptions.length > 1) { + // return true; + // } + // return false; + //} + }, + watch: { + async selectedVehicleVin(value) { + const vehicle = await this.lookupVehicleByVin(value); + if (value === "Vehicle not listed") { + this.mainStore.resetVehicleState(); + } + this.mainStore.updateVehicle(vehicle.data); + + const styleOptions = await this.mainStore.getVehicleStyles( + vehicle.data.year, + vehicle.data.make, + vehicle.data.model + ) + + if (styleOptions.length > 1) { + this.displayGeneric = true; + } + + } + + }, components: { siteHeader, siteFooter, From b4f3117f41fbfb519d8fcd35d1ce1512a1d94b11 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Wed, 7 Jun 2023 11:00:39 -0400 Subject: [PATCH 03/26] refactor --- .../policy-vehicles/policy-vehicles.vue | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 42144ec4..92a33108 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -51,11 +51,12 @@ export default { data() { return { selectedVehicleVin: "", - displayGeneric: false, + displayGeneric: true, bailout: false } }, mounted() { + // clear previously selected vehicle so that the blurred vehicle image displays on page entry useMainStore().resetVehicleState(); }, async beforeRouteEnter(to, from, next) @@ -173,24 +174,30 @@ export default { }, watch: { async selectedVehicleVin(value) { - const vehicle = await this.lookupVehicleByVin(value); if (value === "Vehicle not listed") { + // clear previously selected vehicle and image this.mainStore.resetVehicleState(); + this.displayGeneric = true; } - this.mainStore.updateVehicle(vehicle.data); - + + else { + // get vehicle details from selected vin + const vehicle = await this.lookupVehicleByVin(value); + // save selected vehicle to the store + this.mainStore.updateVehicle(vehicle.data); + this.displayGeneric = false; + const styleOptions = await this.mainStore.getVehicleStyles( vehicle.data.year, vehicle.data.make, vehicle.data.model ) - + // if there is more than 1 style for the selected vehicle, display blurred image if (styleOptions.length > 1) { this.displayGeneric = true; } - + } } - }, components: { siteHeader, From 042a732d04680579e06c3171dd33893064e382c8 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Wed, 7 Jun 2023 16:19:04 -0400 Subject: [PATCH 04/26] all scenarios besides 1B --- .../policy-vehicles/policy-vehicles.vue | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 92a33108..83b56e02 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -154,23 +154,7 @@ export default { selectedVehicle() { const vehicle = this.mainStore.lookupVehicleByVin(this.selectedVehicleVin); return vehicle; - }, - //displayGeneric() { - // const selectedVehicle = useMainStore().lookupVehicleByVin(this.selectedVehicleVin); - // const styleOptions = this.mainStore.getVehicleStyles( - // selectedVehicle.year, - // selectedVehicle.make, - // selectedVehicle.model, - // ); - - - // const styleOptions = this.selectedVehicle.style; - - // if (styleOptions.length > 1) { - // return true; - // } - // return false; - //} + }, }, watch: { async selectedVehicleVin(value) { @@ -183,19 +167,30 @@ export default { else { // get vehicle details from selected vin const vehicle = await this.lookupVehicleByVin(value); + + if (vehicle.error) { + this.mainStore.resetVehicleState(); + this.displayGeneric = true; + } + // save selected vehicle to the store this.mainStore.updateVehicle(vehicle.data); - this.displayGeneric = false; - + this.displayGeneric = true; + const styleOptions = await this.mainStore.getVehicleStyles( vehicle.data.year, vehicle.data.make, vehicle.data.model ) - // if there is more than 1 style for the selected vehicle, display blurred image - if (styleOptions.length > 1) { + + // if there is more than 1 style for the selected vehicle, display generic/blurred image + if (styleOptions.data.length > 1) { this.displayGeneric = true; } + else { + // display clear image of vehicle + this.displayGeneric = false; + } } } }, From e85852bd451ec94596ee1cb8612df6c45890cae8 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Thu, 8 Jun 2023 10:53:02 -0400 Subject: [PATCH 05/26] updates --- src/layouts/policy-vehicles/policy-vehicles.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 83b56e02..82ab834f 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -168,6 +168,7 @@ export default { // get vehicle details from selected vin const vehicle = await this.lookupVehicleByVin(value); + // handle error in case vehicle info doesn't come back for selected VIN if (vehicle.error) { this.mainStore.resetVehicleState(); this.displayGeneric = true; @@ -184,7 +185,7 @@ export default { ) // if there is more than 1 style for the selected vehicle, display generic/blurred image - if (styleOptions.data.length > 1) { + if (styleOptions?.data?.length > 1) { this.displayGeneric = true; } else { From 7e23c40602ef28db42a3341acf3ed233e070628b Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Thu, 8 Jun 2023 16:10:47 -0400 Subject: [PATCH 06/26] autoselect if only one vehicle on policy --- src/layouts/policy-vehicles/policy-vehicles.vue | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.vue b/src/layouts/policy-vehicles/policy-vehicles.vue index 82ab834f..f38516f6 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.vue +++ b/src/layouts/policy-vehicles/policy-vehicles.vue @@ -56,8 +56,7 @@ export default { } }, mounted() { - // clear previously selected vehicle so that the blurred vehicle image displays on page entry - useMainStore().resetVehicleState(); + this.autoSelectIfOneVehicle(); }, async beforeRouteEnter(to, from, next) { @@ -127,8 +126,12 @@ export default { }, }; } - }, - + }, + autoSelectIfOneVehicle() { + if (this.VehiclesFromApi.length == 1) { + this.selectedVehicleVin = this.VehiclesFromApi[0].vin; + } + } }, computed:{ VehiclesForQuestions() { @@ -165,7 +168,7 @@ export default { } else { - // get vehicle details from selected vin + // get vehicle details from selected VIN const vehicle = await this.lookupVehicleByVin(value); // handle error in case vehicle info doesn't come back for selected VIN @@ -177,7 +180,8 @@ export default { // save selected vehicle to the store this.mainStore.updateVehicle(vehicle.data); this.displayGeneric = true; - + + // get the style(s) associated with the selected YMM const styleOptions = await this.mainStore.getVehicleStyles( vehicle.data.year, vehicle.data.make, From 0fecc0d98968108641a4582f03618236a001c177 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Thu, 8 Jun 2023 16:11:12 -0400 Subject: [PATCH 07/26] unit test update --- src/layouts/policy-vehicles/policy-vehicles.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.spec.js b/src/layouts/policy-vehicles/policy-vehicles.spec.js index 1d2f6875..7f45d1cf 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.spec.js +++ b/src/layouts/policy-vehicles/policy-vehicles.spec.js @@ -87,7 +87,7 @@ describe("policy-vehicles.vue", () => { // Act await wrapper.setData({ - selectedVehicleVin: vehicleSelectionOptions.VEHICLE_NOT_LISTED, + selectedVehicleVin: "Vehicle not listed", }); await wrapper.vm.forwardButtonAction(); From d627f6c38d8858f799db7f7885ff8c6967469221 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Mon, 12 Jun 2023 09:55:55 -0400 Subject: [PATCH 08/26] WIP set spacing between footer and last element on page. --- .../questions-page-layout.vue | 3 +- .../site-footer/site-footer.vue | 27 +++--- src/layouts/address-lookup/address-lookup.vue | 5 +- .../license-plate-lookup.vue | 1 + .../policy-holder-details.vue | 17 ++-- src/layouts/vehicle-damage/vehicle-damage.vue | 1 + src/layouts/vehicle-lookup/vehicle-lookup.vue | 2 +- .../glass-part-question.vue | 8 +- .../vehicle-selection/vehicle-selection.vue | 93 ++++++++++--------- src/layouts/vin-lookup/vin-lookup.vue | 4 +- src/layouts/welcome-page/welcome-page.vue | 17 ++-- 11 files changed, 92 insertions(+), 86 deletions(-) diff --git a/src/iss-components/questions-page-layout/questions-page-layout.vue b/src/iss-components/questions-page-layout/questions-page-layout.vue index 657d02b9..9a500e89 100644 --- a/src/iss-components/questions-page-layout/questions-page-layout.vue +++ b/src/iss-components/questions-page-layout/questions-page-layout.vue @@ -16,7 +16,7 @@ alertClass="alert-warning" :manualHeadline="alertFewMoreQuestionsHeader" :manualCopy="alertFewMoreQuestionsCopy" - v-bind:isDismissible="false" + v-bind:isDismissible="false" class="mt-5"/>
- -
-
-
- +
+
+
+ -
-
- +
+ +
+
+
+
-
-
-
@@ -77,8 +78,8 @@ export default { }, buttonText() { return this.customButtontext - ? this.customButtontext - : this.getCmsContent(this.cmsWidgetName, "ForwardButtonText"); + ? this.customButtontext + : this.getCmsContent(this.cmsWidgetName, "ForwardButtonText"); }, footerImageURL() { diff --git a/src/layouts/address-lookup/address-lookup.vue b/src/layouts/address-lookup/address-lookup.vue index ea0b4622..40d3bd92 100644 --- a/src/layouts/address-lookup/address-lookup.vue +++ b/src/layouts/address-lookup/address-lookup.vue @@ -41,14 +41,13 @@ - -
{ vm.setCmsContent(resultMap.cmsContent); - }); - + }); + }, methods: { @@ -101,8 +102,8 @@ export default { }, async forwardButtonAction() - { - this.mainStore.updatePolicyHolderDetails(this.customerQuestions); + { + this.mainStore.updatePolicyHolderDetails(this.customerQuestions); return this.navigateForward(); }, @@ -114,7 +115,7 @@ export default { {}, {}, this.vehiclesFound - ); + ); else this.$router.navigate( this.navigationScenarios.CLICKED_FORWARD_POLICY_UNVERIFIED, @@ -135,7 +136,7 @@ export default { firstName : this.mainStore.order.customer.firstName, lastName : this.mainStore.order.customer.lastName, } - }, + }, }, computed:{ isCoverageEnabled(){ @@ -143,7 +144,7 @@ export default { }, vehiclesCount(){ return this.vehiclesFound.length; - } + } }, components: { siteHeader, diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index 5106203c..7ee5102c 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -51,6 +51,7 @@ groupName="BackGlassReplaceOptionsQuestion" validationRules="replace-options-required" /> - +
diff --git a/src/layouts/vehicle-parts/glass-part-question/glass-part-question.vue b/src/layouts/vehicle-parts/glass-part-question/glass-part-question.vue index 9b1beaec..e8f662ef 100644 --- a/src/layouts/vehicle-parts/glass-part-question/glass-part-question.vue +++ b/src/layouts/vehicle-parts/glass-part-question/glass-part-question.vue @@ -181,12 +181,12 @@ export default { }, AutoSelectIfSinglePart() { - if (this.partsForSelectedTint?.length > 0) + if (this.partsForSelectedTint?.length > 0) { // Check if only a single part is present for the tint and set the v-model if it is. if (this.partsForSelectedTint?.length == 1) { this.selectedPartNumber = { value: this.partsForSelectedTint[0].partNumber }; - + // //select element with matching partNumber this.$nextTick(() => { const radioInput = document.querySelector('input[value=' + this.selectedPartNumber + ']'); @@ -199,7 +199,7 @@ export default { } } }, - + // Loads the preselected values from the store. LoadPreselectedValues() { this.$nextTick(() => { @@ -208,7 +208,7 @@ export default { { this.selectedTint = this.modelValue.color; } - }); + }); }, }, watch: { diff --git a/src/layouts/vehicle-selection/vehicle-selection.vue b/src/layouts/vehicle-selection/vehicle-selection.vue index 5e0aa53b..32d04c87 100644 --- a/src/layouts/vehicle-selection/vehicle-selection.vue +++ b/src/layouts/vehicle-selection/vehicle-selection.vue @@ -1,5 +1,5 @@ @@ -159,12 +160,12 @@ export default { this.$router.navigate(scenario, this.$route); }, navigateWithTPAAck() { - this.mainStore.saveProviderPreferenceData({selectedProvider: this.selectedProvider, tpaAcknowledgement: this.tpaAcknowledgement}); + this.mainStore.saveProviderPreferenceData({selectedProvider: this.selectedProvider, tpaAcknowledgement: this.tpaAcknowledgement}); this.navigateForward(this.navigationScenarios.CLICKED_FORWARD_WITH_TPA_ENABLED); }, forwardButtonAction() { if(this.selectedProvider) { - let scenario = null; + let scenario = null; switch (this.selectedProvider) { case options.SAFELITE: scenario = this.navigationScenarios.CLICKED_FORWARD_WITH_SAFELITE; @@ -186,7 +187,7 @@ export default { break; }; this.navigateForward(scenario); - this.mainStore.saveProviderPreferenceData({selectedProvider: this.selectedProvider, tpaAcknowledgement: this.tpaAcknowledgement}); + this.mainStore.saveProviderPreferenceData({selectedProvider: this.selectedProvider, tpaAcknowledgement: this.tpaAcknowledgement}); } }, openStateSteeringModal() { diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index 3b93b6c9..77a2ff10 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -31,11 +31,12 @@ validationRules="selection-required" class="service-location-button-question mb-1"/>
-
+
{ vm.setCmsContent(resultMap.cmsContent); vm.setData( @@ -161,7 +162,7 @@ export default { }, displayMilitaryZipAlert() { return this.zipContainsMilitaryBase && this.isServiceableMobile; - } + } }, methods: { arePagePrerequisiteValid() { @@ -258,11 +259,11 @@ export default { .service-location-button-question { .question-text { margin-top: 1.5rem; - + span { text-align: center; } - + } } From e5622762b6bf13e2fa5f375a77fa5ff579ca77d9 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Mon, 12 Jun 2023 10:42:51 -0400 Subject: [PATCH 10/26] Set footer spacing for schedule page. --- src/layouts/schedule-page/schedule-page.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/layouts/schedule-page/schedule-page.vue b/src/layouts/schedule-page/schedule-page.vue index 228a8386..f1ce943c 100644 --- a/src/layouts/schedule-page/schedule-page.vue +++ b/src/layouts/schedule-page/schedule-page.vue @@ -6,6 +6,7 @@

Placeholder for schedule page

Date: Mon, 12 Jun 2023 11:04:12 -0400 Subject: [PATCH 11/26] added unit test for auto selecting vehicle --- .../policy-vehicles/policy-vehicles.spec.js | 40 +++++++++---------- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/layouts/policy-vehicles/policy-vehicles.spec.js b/src/layouts/policy-vehicles/policy-vehicles.spec.js index 7f45d1cf..5cecac66 100644 --- a/src/layouts/policy-vehicles/policy-vehicles.spec.js +++ b/src/layouts/policy-vehicles/policy-vehicles.spec.js @@ -4,7 +4,6 @@ import { shallowMount } from "@vue/test-utils"; import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { useMainStore } from "@/store"; import { fetchCmsContentForPage } from "@/helpers/cms-content-helper"; -import {vehicleSelectionOptions} from "@/constants/vehicle-selection-options"; import { navigationScenarios } from "@/router/router-constants/navigation-scenarios"; // Mock fetchCmsContentForPage @@ -33,17 +32,6 @@ describe("policy-vehicles.vue", () => { //Assert expect(wrapper.vm.$router.navigate).toBeCalled(); }); - test("Should navigate to CLICKED_BACK if backButtonAction is run", async () => { - // Arrange - const { wrapper } = setupMocks({}); - - // Act - await wrapper.vm.backButtonAction(); - - //Assert - expect(wrapper.vm.$router.navigate).toBeCalled(); - }); - test("Selected vehicle VIN do match vehicles listed in our system (CarIDs) found then navigate forward to vehicle-damage page.", async () => { //Arrange const { wrapper } = setupMocks({}); @@ -99,6 +87,16 @@ describe("policy-vehicles.vue", () => { {} ); }); + test("first vehicle is auto-selected if only one vehicle on policy", async () => { + //Arrange + const { wrapper } = setupMocks({}); + + // Act + await wrapper.vm.$nextTick(); + + // Assert + expect(wrapper.vm.selectedVehicleVin).toBe("5NMS3CADXLH233004"); + }); }); function setupMocks({ @@ -109,15 +107,15 @@ function setupMocks({ useMainStore().applicationUser = { pageData: { "policy-vehicles": - [ - { - vehicleMake: "Hyundai", - vehicleModel: "Santa Fe", - vehicleStyle: "4 door utility", - vehicleYear: 2020, - vin: "5NMS3CADXLH233004", - }, - ], + [ + { + vehicleMake: "Hyundai", + vehicleModel: "Santa Fe", + vehicleStyle: "4 door utility", + vehicleYear: 2020, + vin: "5NMS3CADXLH233004", + }, + ], } }; useMainStore().lookupVehicleByVin = jest.fn().mockImplementation(() => { From c7552b7f5cb4d0e4d79edff5f31cbd6179b15765 Mon Sep 17 00:00:00 2001 From: Jason Wheeler Date: Mon, 12 Jun 2023 11:04:14 -0400 Subject: [PATCH 12/26] Had to reset values prior to getting new values because if the same values comes back and it auto selects the watch won't trigger because the value doesn't technically change --- src/layouts/vehicle-selection/vehicle-selection.vue | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/layouts/vehicle-selection/vehicle-selection.vue b/src/layouts/vehicle-selection/vehicle-selection.vue index 5e0aa53b..1ae0b6db 100644 --- a/src/layouts/vehicle-selection/vehicle-selection.vue +++ b/src/layouts/vehicle-selection/vehicle-selection.vue @@ -140,33 +140,28 @@ export default { watch: { selectedYear(value) { this.mainStore.updateVehicleYear(value); + this.$refs["vehicleMakeQuestion"].clearValues(); if(value) { this.$refs["vehicleMakeQuestion"].getNewValues(); } - else{ - this.$refs["vehicleMakeQuestion"].clearValues(); - } }, selectedMake(value) { this.mainStore.updateVehicleMake(value); + this.$refs["vehicleModelQuestion"].clearValues(); if(value) { this.$refs["vehicleModelQuestion"].getNewValues(); } - else{ - this.$refs["vehicleModelQuestion"].clearValues(); - } }, selectedModel(value) { this.mainStore.updateVehicleModel(value); + this.$refs["vehicleStyleQuestion"].clearValues(); if(value) { this.$refs["vehicleStyleQuestion"].getNewValues(); } - else{ - this.$refs["vehicleStyleQuestion"].clearValues(); - } + }, selectedStyle(value) { this.mainStore.updateVehicleStyle(value); From 866919efcb1fa6824a54e16cb66dd02c0e252579 Mon Sep 17 00:00:00 2001 From: Katie Kroell Date: Mon, 12 Jun 2023 14:34:30 -0400 Subject: [PATCH 13/26] prevent aggressive validation in fields with regex rules --- src/digital-components/textbox-question/textbox-question.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/digital-components/textbox-question/textbox-question.vue b/src/digital-components/textbox-question/textbox-question.vue index bbbafa9e..c502681c 100644 --- a/src/digital-components/textbox-question/textbox-question.vue +++ b/src/digital-components/textbox-question/textbox-question.vue @@ -14,7 +14,7 @@ ]"> Date: Mon, 12 Jun 2023 14:41:43 -0400 Subject: [PATCH 14/26] Fix so that button border shows fully. --- src/iss-components/site-footer/site-footer.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/iss-components/site-footer/site-footer.vue b/src/iss-components/site-footer/site-footer.vue index 76cd9055..691192ac 100644 --- a/src/iss-components/site-footer/site-footer.vue +++ b/src/iss-components/site-footer/site-footer.vue @@ -127,6 +127,7 @@ export default { - \ No newline at end of file + From ac976b54fb9f6220c97e742ff5f768a9a2cad42f Mon Sep 17 00:00:00 2001 From: Jason Wheeler Date: Mon, 19 Jun 2023 15:19:41 -0400 Subject: [PATCH 19/26] Set modal button position to be absolute while relative to parent rather than the page. This prevents the button from scrolling down with the page since the header was unstuck. Also correct white space issues on welcome page. --- .../site-header/menu-modal/menu-modal.vue | 37 ++++++++++++------- .../site-header/site-header.vue | 1 + src/layouts/welcome-page/welcome-page.vue | 2 +- 3 files changed, 26 insertions(+), 14 deletions(-) diff --git a/src/iss-components/site-header/menu-modal/menu-modal.vue b/src/iss-components/site-header/menu-modal/menu-modal.vue index 98caab16..868b0693 100644 --- a/src/iss-components/site-header/menu-modal/menu-modal.vue +++ b/src/iss-components/site-header/menu-modal/menu-modal.vue @@ -1,13 +1,13 @@