From 647eb4c9198d24e131d329cb6f7a93f5c6d71d56 Mon Sep 17 00:00:00 2001 From: brydon1 Date: Wed, 6 Sep 2023 17:21:58 -0400 Subject: [PATCH 1/2] Remove bailout when no vehicle found --- src/layouts/vin-lookup/vin-lookup.vue | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index bb91d977..67bd391f 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -112,8 +112,7 @@ export default { vehicleFromLookup: null, vin: this.getVinFromStore(), forwardButtonCarStyle: '', - vinPopulatedOnPageLoad: this.getVinFromStore()?.length > 0, - bailout: false + vinPopulatedOnPageLoad: this.getVinFromStore()?.length > 0 }; }, computed: { @@ -179,15 +178,8 @@ export default { // because the form itself actually passes its client-side validation. // SSR-189 Scenario #4. this.$refs.siteFooter.enableForwardAction(); - this.bailout = true; } - if (this.bailout) { - return this.$router.navigate( - this.navigationScenarios.CLICKED_FORWARD_WITH_BAILOUT, - this.$route - ); - } // Add vin bcs the response from the service doesn't contain vin this.vehicleFromLookup = Object.assign(vehicleLookupResponse.data, { vin: this.vin }); } From b95124b428508013c9cf5438c02d0fbb6d24bbbf Mon Sep 17 00:00:00 2001 From: brydon1 Date: Thu, 7 Sep 2023 11:05:48 -0400 Subject: [PATCH 2/2] Removing bailout navigation test --- src/layouts/vin-lookup/vin-lookup.spec.js | 28 ----------------------- 1 file changed, 28 deletions(-) diff --git a/src/layouts/vin-lookup/vin-lookup.spec.js b/src/layouts/vin-lookup/vin-lookup.spec.js index 2e59dd23..d38cd24c 100644 --- a/src/layouts/vin-lookup/vin-lookup.spec.js +++ b/src/layouts/vin-lookup/vin-lookup.spec.js @@ -476,34 +476,6 @@ describe('vin-lookup.vue', () => { ); }); }); - - test('Selected vehicle VIN do not match vehicles (CarIDs) in our system then navigate forward to bailout page.', async () => { - // Arrange - const user = userEvent.setup(); - lookupVehicleByVin.mockResponse.data.error = true; - - jest.spyOn(VinLookupComponent.methods, lookupVehicleByVin.methodName) - .mockResolvedValue(lookupVehicleByVinError.mockResponse); - - mountOptions.data = () => ({ - needToLookupVehicle: true, - bailout: true, - vin: mockValidVin - }); - - const { container } = render(VinLookupComponent, mountOptions); - const continueButton = container.querySelector(continueButtonQuerySelector); - await user.click(continueButton); - - await flushPromises(); - await waitFor(() => { - expect(mockRouter.navigate).toHaveBeenCalledTimes(1); - expect(mockRouter.navigate).toHaveBeenCalledWith( - navigationScenarios.CLICKED_FORWARD_WITH_BAILOUT, - mockRoute - ); - }); - }); }); }); });