jason/DigitalConsumer.ISS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1206 from Safelite/feature/jzimmerman/INSR-9498

Browse source 
INSR-9498: Force experiment api calls to not bailout.
This commit is contained in:
Jeremy-Z 2026-05-04 09:46:24 -04:00 committed by GitHub
commit 606263bf06
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/router/index.js
View file

@ -43,7 +43,11 @@ const routes = [
updateSessionIdCookie(); updateSessionIdCookie();
} }
await runExperiments(issPageToUse); // fmg has this further down try {
await runExperiments(issPageToUse);
} catch (error) {
console.error('Failed to run experiments during route navigation.', error);
}
} }
// Intercept all navigation if a submitted order exists in storage // Intercept all navigation if a submitted order exists in storage

11
src/store/index.js
View file

@ -2547,13 +2547,17 @@ export const useMainStore = defineStore({
sessionKey: getSessionKeyValue(), sessionKey: getSessionKeyValue(),
pageName pageName
} }
} },
bailoutOnError: false
}); });
}, },
logExperimentIfExists(pageName, universe) { logExperimentIfExists(pageName, universe) {
const experiment = this.applicationUser.experiments.find((e) => e.universeName === universe); const experiment = this.applicationUser.experiments.find((e) => e.universeName === universe);
if (experiment !== undefined) { if (experiment !== undefined) {
this.logExperimentExposure(pageName, experiment); void this.logExperimentExposure(pageName, experiment)
.catch((error) => {
console.error(`Failed to log experiment exposure: ${error?.data ?? error}`);
});
} }
}, },
logPageView({ userId, sessionKey, pageName, referralSequenceNumber, parentAccountNumber, sessionId, action, event, shouldUseSessionId, experimentsForUser }) { logPageView({ userId, sessionKey, pageName, referralSequenceNumber, parentAccountNumber, sessionId, action, event, shouldUseSessionId, experimentsForUser }) {
@ -2858,7 +2862,8 @@ export const useMainStore = defineStore({
const response = await globalMethods.callHttpClient({ const response = await globalMethods.callHttpClient({
method: endpoints.RunExperimentsForTrigger.method, method: endpoints.RunExperimentsForTrigger.method,
endpoint: endpoints.RunExperimentsForTrigger.url, endpoint: endpoints.RunExperimentsForTrigger.url,
payload payload: payload,
bailoutOnError: false
}); });
this.updateExperiments(response.data.experiments); this.updateExperiments(response.data.experiments);