From bd2f7a2f12f065a07366b87588da6081c2f686c1 Mon Sep 17 00:00:00 2001 From: Josh Dassinger Date: Fri, 6 Dec 2024 10:31:22 -0600 Subject: [PATCH 1/3] SSR-1942 Attempt to fix timing issues with playwright --- .../address-questions/address-questions.vue | 5 ++++- src/layouts/bailout-page/bailout-page.vue | 3 +++ .../policy-holder-details.vue | 2 +- src/layouts/vin-lookup/vin-lookup.vue | 21 +++++++------------ 4 files changed, 15 insertions(+), 16 deletions(-) diff --git a/src/iss-components/address-questions/address-questions.vue b/src/iss-components/address-questions/address-questions.vue index 57b9d0dc..8ab07362 100644 --- a/src/iss-components/address-questions/address-questions.vue +++ b/src/iss-components/address-questions/address-questions.vue @@ -13,7 +13,7 @@ disableAutoFill validationRules="street-address-required" @keydown.enter.prevent - @focusout="fillInAddress()" /> + @focusout="onAutocompleteFocusOut()" /> 0) { diff --git a/src/layouts/bailout-page/bailout-page.vue b/src/layouts/bailout-page/bailout-page.vue index 692837e1..a6921804 100644 --- a/src/layouts/bailout-page/bailout-page.vue +++ b/src/layouts/bailout-page/bailout-page.vue @@ -193,6 +193,9 @@ export default { } }, methods: { + arePagePrerequisitesValid() { + return !!this.mainStore.pageData(issPageValues.BAILOUT_PAGE); + }, backButtonAction() { // route to move backwards this.mainStore.resetBailout(); diff --git a/src/layouts/policy-holder-details/policy-holder-details.vue b/src/layouts/policy-holder-details/policy-holder-details.vue index 2758f64f..165fb775 100644 --- a/src/layouts/policy-holder-details/policy-holder-details.vue +++ b/src/layouts/policy-holder-details/policy-holder-details.vue @@ -19,7 +19,7 @@ id="address-questions-wrapper" ref="addressQuestions" v-model="customerQuestions.addressQuestions" - includeStreetAddress2="true" /> + :includeStreetAddress2="true" /> 0 && this.hasValidCarId(), - hasBailedOut: false }; }, computed: { @@ -231,13 +230,12 @@ export default { this.needToLookupVehicle = false; - return null; + return; } let isSelectedGlassAvailableForVehicle = true; if (this.isCarIdDifferentFromTheStore) { - isSelectedGlassAvailableForVehicle = - await isGlassAvailableForCarId(this.vehicleFromLookup.carId); + isSelectedGlassAvailableForVehicle = await isGlassAvailableForCarId(this.vehicleFromLookup.carId); } // navigate back to vehicle-damage @@ -255,7 +253,7 @@ export default { ); // navigate() doesn't stop the processing flow - return null; + return; } // save vehicle to store if it hasn't already been saved @@ -268,28 +266,23 @@ export default { this.navigationScenarios.CORRECTED_VIN_FROM_POLICY_VEHICLE, this.$route ); - return null; + return; } const partsOrQuestionsResponse = await this.getPartsOrQuestions(); if (partsOrQuestionsResponse.error) { this.mainStore.setBailout(bailoutMessage.PartsServiceError(partsOrQuestionsResponse.error.data)); window.console.error('Error on retrieving PartsOrQuestions'); - this.$refs.siteFooter.removeLoader(); - this.hasBailedOut = true; + // this.$refs.siteFooter.removeLoader(); this.$router.navigate( this.navigationScenarios.CLICKED_FORWARD_WITH_BAILOUT, this.$route ); + return; } // Comes from vehicleQuestionsMixin.navigateForward() - if (!this.hasBailedOut) { - await this.navigateForward( - partsOrQuestionsResponse.data.partsOrQuestions, - this - ); - } + await this.navigateForward(partsOrQuestionsResponse.data.partsOrQuestions, this); }, async lookupVehicleByVin(vin) { try { From d47b86e0cdbec9baac1e87c9022d75884aab504f Mon Sep 17 00:00:00 2001 From: Josh Dassinger Date: Fri, 6 Dec 2024 10:42:34 -0600 Subject: [PATCH 2/3] SSR-1942 Removed commented removeLoader() call --- src/layouts/vin-lookup/vin-lookup.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index 2f8f4d0f..4cc724f5 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -273,7 +273,6 @@ export default { if (partsOrQuestionsResponse.error) { this.mainStore.setBailout(bailoutMessage.PartsServiceError(partsOrQuestionsResponse.error.data)); window.console.error('Error on retrieving PartsOrQuestions'); - // this.$refs.siteFooter.removeLoader(); this.$router.navigate( this.navigationScenarios.CLICKED_FORWARD_WITH_BAILOUT, this.$route From 62b7f318c2b092e412c9e7acfe9af244cd7ebd39 Mon Sep 17 00:00:00 2001 From: Josh Dassinger Date: Fri, 6 Dec 2024 11:39:55 -0600 Subject: [PATCH 3/3] SSR-1942 use fillInAddressUsingFirstItem instead for address-questions focus out --- src/iss-components/address-questions/address-questions.vue | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/iss-components/address-questions/address-questions.vue b/src/iss-components/address-questions/address-questions.vue index 8ab07362..55abd09c 100644 --- a/src/iss-components/address-questions/address-questions.vue +++ b/src/iss-components/address-questions/address-questions.vue @@ -13,7 +13,7 @@ disableAutoFill validationRules="street-address-required" @keydown.enter.prevent - @focusout="onAutocompleteFocusOut()" /> + @focusout="fillInAddressUsingFirstItem()" /> 0) {