From 292c46fe34a56dd5b453b5ac4e9704933c1aea4c Mon Sep 17 00:00:00 2001
From: Jason Wheeler <jason.wheeler@safelite.com>
Date: Wed, 9 Nov 2022 12:12:42 -0500
Subject: [PATCH] completed tests, removed old 404 page and cleared up a few
 warnings

---
 .../dropdown-question/dropdown-question.spec.js       |  2 +-
 .../dropdown-question/dropdown-question.vue           |  2 ++
 .../textbox-question/textbox-question.vue             |  1 +
 .../vehicle-banner/vehicle-banner.vue                 |  5 ++---
 src/layouts/error-404/error-404.vue                   | 11 -----------
 src/router/router-constants/issPage-values.js         |  1 -
 src/store/store.spec.js                               |  9 +++++----
 7 files changed, 11 insertions(+), 20 deletions(-)
 delete mode 100644 src/layouts/error-404/error-404.vue

diff --git a/src/common-components/dropdown-question/dropdown-question.spec.js b/src/common-components/dropdown-question/dropdown-question.spec.js
index 381f3489..237e087c 100644
--- a/src/common-components/dropdown-question/dropdown-question.spec.js
+++ b/src/common-components/dropdown-question/dropdown-question.spec.js
@@ -152,7 +152,7 @@ describe("dropdownQuestion.vue", () => {
     const wrapper = shallowMount(dropdownQuestion, {
       propsData: {
         options: {},
-        modelValue: 0,
+        modelValue: "0",
       },
       mixins: [mockMixin]
     });
diff --git a/src/common-components/dropdown-question/dropdown-question.vue b/src/common-components/dropdown-question/dropdown-question.vue
index 8e6ae0fa..43c81ccb 100644
--- a/src/common-components/dropdown-question/dropdown-question.vue
+++ b/src/common-components/dropdown-question/dropdown-question.vue
@@ -37,6 +37,8 @@ export default {
 		disableAutoFill: Boolean,
 		validationRules: String, 
 		cmsWidgetName: String,
+		hasError: Boolean,
+		errors: Array
 	},
 	setup(props) {
 		const propsClone = Object.assign({}, props);
diff --git a/src/common-components/textbox-question/textbox-question.vue b/src/common-components/textbox-question/textbox-question.vue
index 7733c02b..3cb13e18 100644
--- a/src/common-components/textbox-question/textbox-question.vue
+++ b/src/common-components/textbox-question/textbox-question.vue
@@ -55,6 +55,7 @@ export default {
 		validationRules: String,
 		cmsWidgetName: String,
 		maxLength: String,
+		disableAutoFill: Boolean,
 	},
 	setup(props) {
 		const propsClone = Object.assign({}, props);
diff --git a/src/common-components/vehicle-banner/vehicle-banner.vue b/src/common-components/vehicle-banner/vehicle-banner.vue
index 9fffd974..4ffebe12 100644
--- a/src/common-components/vehicle-banner/vehicle-banner.vue
+++ b/src/common-components/vehicle-banner/vehicle-banner.vue
@@ -9,7 +9,6 @@
 </template>
 
 <script>
-import { useMainStore } from "@/store";
 export default {
   name: "vehicle-banner",
   props: {
@@ -25,7 +24,7 @@ export default {
           return this.genericVehicleImage;  
         }
   
-        const imageUrl = useMainStore().order.vehicle.imageUrl;
+        const imageUrl = this.mainStore.order.vehicle.imageUrl;
         if (!imageUrl || imageUrl === "NULL"){
           return this.getUnmatchedVehicleIcon();
         }
@@ -53,7 +52,7 @@ export default {
   },
   methods: {
     getUnmatchedVehicleIcon(){
-       switch(useMainStore().order.vehicle.category){
+       switch(this.mainStore.order.vehicle.category){
           case this.vehicleCategories.CAR:
             return this.carUnmatchedVehicleIcon;
           case this.vehicleCategories.SUV:
diff --git a/src/layouts/error-404/error-404.vue b/src/layouts/error-404/error-404.vue
deleted file mode 100644
index 7b5f6c52..00000000
--- a/src/layouts/error-404/error-404.vue
+++ /dev/null
@@ -1,11 +0,0 @@
-<template>
-<div>
-    404: Page Not Found
-</div>
-</template>
-
-<script>
-    export default {
-        name: 'error-404'
-    }
-</script>
\ No newline at end of file
diff --git a/src/router/router-constants/issPage-values.js b/src/router/router-constants/issPage-values.js
index 07ea81bd..c31fa083 100644
--- a/src/router/router-constants/issPage-values.js
+++ b/src/router/router-constants/issPage-values.js
@@ -1,5 +1,4 @@
 export const issPageValues = {
-    ERROR_404: "error-404",
     WELCOME_PAGE: "welcome-page",
     VEHICLE_MAKE: "vehicle-make",
     VEHICLE_YEAR: "vehicle-year",
diff --git a/src/store/store.spec.js b/src/store/store.spec.js
index 49444767..9f5db937 100644
--- a/src/store/store.spec.js
+++ b/src/store/store.spec.js
@@ -3,6 +3,7 @@ import { createApp } from 'vue';
 import { createPinia } from "pinia";
 import App from '@/App.vue';
 
+
 describe("Store", () => {
 
     let store;
@@ -36,7 +37,7 @@ describe("Store", () => {
             },
         };
 
-        store.addEventToBus(store, event);
+        store.addEventToBus(event);
 
         expect(store.applicationUser.eventBus[0]).toEqual(event);
     });
@@ -53,11 +54,11 @@ describe("Store", () => {
             },
         };
 
-        store.addEventToBus(store, event);
+        store.addEventToBus(event);
 
         expect(store.applicationUser.eventBus.length).toBe(1);
 
-        store.removeEventFromBus(store, { category: event.category, subCategory: event.subCategory })
+        store.removeEventFromBus({ category: event.category, subCategory: event.subCategory })
 
         expect(store.applicationUser.eventBus.length).toBe(0);
     });
@@ -74,7 +75,7 @@ describe("Store", () => {
             },
         };
 
-        store.addEventToBus(store, event);
+        store.addEventToBus(event);
 
         const actual = store.eventBusItem(event.category, event.subCategory)