From 26e177116056ada580f9280ac968c74e90e22d0c Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Fri, 28 Apr 2023 19:50:34 +0530 Subject: [PATCH] navigationScenarios optimised navigationScenarios optimised --- .../policy-holder-details/policy-holder-details.vue | 2 +- src/layouts/welcome-page/welcome-page.vue | 2 +- src/router/router-constants/navigation-scenarios.js | 8 +++++--- src/router/router-constants/routing-table.js | 4 ++-- src/router/router.spec.js | 2 +- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/layouts/policy-holder-details/policy-holder-details.vue b/src/layouts/policy-holder-details/policy-holder-details.vue index 324babc7..6a75e5b7 100644 --- a/src/layouts/policy-holder-details/policy-holder-details.vue +++ b/src/layouts/policy-holder-details/policy-holder-details.vue @@ -132,7 +132,7 @@ export default { ); else this.$router.navigate( - this.navigationScenarios.CLICKED_FORWARD_POLICY_HOLDER_DETAILS, + this.navigationScenarios.CLICKED_FORWARD_POLICY_UNVERIFIED, this.$route ); }, diff --git a/src/layouts/welcome-page/welcome-page.vue b/src/layouts/welcome-page/welcome-page.vue index 3757e2e4..737c636c 100644 --- a/src/layouts/welcome-page/welcome-page.vue +++ b/src/layouts/welcome-page/welcome-page.vue @@ -241,7 +241,7 @@ export default { navigateForward() { this.$router.navigate( - this.navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE, + this.navigationScenarios.CLICKED_FORWARD, this.$route ); }, diff --git a/src/router/router-constants/navigation-scenarios.js b/src/router/router-constants/navigation-scenarios.js index 7bdb0f02..f0a0c871 100644 --- a/src/router/router-constants/navigation-scenarios.js +++ b/src/router/router-constants/navigation-scenarios.js @@ -10,10 +10,12 @@ const navigationScenarios = { SELECTED_YEAR: "SELECTED_YEAR", SELECTED_MAKE: "SELECTED_MAKE", SELECTED_MODEL: "SELECTED_MODEL", - SELECTED_STYLE: "SELECTED_STYLE", - CLICKED_FORWARD_WELCOME_PAGE: "CLICKED_FORWARD_WELCOME_PAGE", - CLICKED_FORWARD_POLICY_HOLDER_DETAILS: "CLICKED_FORWARD_POLICY_HOLDER_DETAILS", + SELECTED_STYLE: "SELECTED_STYLE", + + //Policy Holder Details + CLICKED_FORWARD_POLICY_UNVERIFIED: "CLICKED_FORWARD_POLICY_UNVERIFIED", CLICKED_FORWARD_POLICY_VERIFIED: "CLICKED_FORWARD_POLICY_VERIFIED", + // Vehicle Damage CLICKED_FORWARD_WITH_REPAIR: 'CLICKED_FORWARD_WITH_REPAIR', diff --git a/src/router/router-constants/routing-table.js b/src/router/router-constants/routing-table.js index 30df077c..b8681067 100644 --- a/src/router/router-constants/routing-table.js +++ b/src/router/router-constants/routing-table.js @@ -375,7 +375,7 @@ const routingTable = function(store) { destinationIssPageValue: issPageValues.WELCOME_PAGE }, { - scenario: navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE, + scenario: navigationScenarios.CLICKED_FORWARD, destinationIssPageValue: issPageValues.POLICY_HOLDER_DETAILS } ] @@ -388,7 +388,7 @@ const routingTable = function(store) { destinationIssPageValue: issPageValues.WELCOME_PAGE }, { - scenario: navigationScenarios.CLICKED_FORWARD_POLICY_HOLDER_DETAILS, + scenario: navigationScenarios.CLICKED_FORWARD_POLICY_UNVERIFIED, destinationIssPageValue: issPageValues.VEHICLE_YEAR }, { diff --git a/src/router/router.spec.js b/src/router/router.spec.js index 67962988..92301ca9 100644 --- a/src/router/router.spec.js +++ b/src/router/router.spec.js @@ -15,7 +15,7 @@ describe("Router", () => { it("Should push next view when navigating locally", () => { - let scenario = navigationScenarios.CLICKED_FORWARD_WELCOME_PAGE; + let scenario = navigationScenarios.CLICKED_FORWARD; let currentRoute = { query: { issPage: issPageValues.WELCOME_PAGE }}; router.push = jest.fn();