diff --git a/src/constants/experiments.js b/src/constants/experiments.js index 18676ce4..ede13562 100644 --- a/src/constants/experiments.js +++ b/src/constants/experiments.js @@ -4,7 +4,11 @@ const experimentUniverses = Object.freeze({ const experimentSettings = Object.freeze({ GOOGLE_CUSTOM_DIMENSION_INDEX: 'Google Custom Dimension Index', - ISS_DISPLAY_PAY_IN_ADVANCE: 'DisplayPIAInsurance' + ISS_DISPLAY_PAY_IN_ADVANCE: 'DisplayPIAInsurance', + ISS_FEATURE_TOGGLE_IS_MOBILE_FEE_HIDDEN: 'HideMobileFee', + ISS_FEATURE_TOGGLE_IS_MOBILE_FEE_OVERRIDDEN: 'HideMobileFee', + ISS_FEATURE_TOGGLE_IS_RECYCLE_FEE_HIDDEN: 'HideRecycleFee', + ISS_FEATURE_TOGGLE_IS_RECYCLE_FEE_OVERRIDDEN: 'HideRecycleFee' }); const experimentTriggers = Object.freeze({ diff --git a/src/helpers/experiment-helper.js b/src/helpers/experiment-helper.js index c0f0d3a8..861b2ad2 100644 --- a/src/helpers/experiment-helper.js +++ b/src/helpers/experiment-helper.js @@ -1,18 +1,21 @@ -export function hasExperimentSetting(experimentSettings, settingName) { - return Object.hasOwn(experimentSettings, settingName); +/* eslint-disable max-len */ +import { experimentSettings } from '@/constants/experiments'; + +export function hasExperimentSetting(storeExperimentSettings, settingName) { + return Object.hasOwn(storeExperimentSettings, settingName); } -export function getExperimentSettingValue(experimentSettings, settingName) { - return hasExperimentSetting(experimentSettings, settingName) - ? experimentSettings[settingName] +export function getExperimentSettingValue(storeExperimentSettings, settingName) { + return hasExperimentSetting(storeExperimentSettings, settingName) + ? storeExperimentSettings[settingName] : null; } -export function getFeatureTogglesQueryString(experimentSettings) { - const isMobileFeeHidden = getExperimentSettingValue(experimentSettings, 'HideMobileFee') === 'true'; - const isMobileFeeOverridden = getExperimentSettingValue(experimentSettings, 'OverrideMobileFee') === 'true'; - const isRecycleFeeHidden = getExperimentSettingValue(experimentSettings, 'HideRecycleFee') === 'true'; - const isRecycleFeeOverridden = getExperimentSettingValue(experimentSettings, 'OverrideRecycleFee') === 'true'; +export function getFeatureTogglesQueryString(storeExperimentSettings) { + const isMobileFeeHidden = getExperimentSettingValue(storeExperimentSettings, experimentSettings.ISS_FEATURE_TOGGLE_IS_MOBILE_FEE_HIDDEN) === 'true'; + const isMobileFeeOverridden = getExperimentSettingValue(storeExperimentSettings, experimentSettings.ISS_FEATURE_TOGGLE_IS_MOBILE_FEE_OVERRIDDEN) === 'true'; + const isRecycleFeeHidden = getExperimentSettingValue(storeExperimentSettings, experimentSettings.ISS_FEATURE_TOGGLE_IS_RECYCLE_FEE_HIDDEN) === 'true'; + const isRecycleFeeOverridden = getExperimentSettingValue(storeExperimentSettings, experimentSettings.ISS_FEATURE_TOGGLE_IS_RECYCLE_FEE_OVERRIDDEN) === 'true'; return `FeatureToggles.IsMobileFeeHidden=${isMobileFeeHidden}` + `&FeatureToggles.IsMobileFeeOverridden=${isMobileFeeOverridden}` diff --git a/src/iss-components/cart-dropdown/cart-dropdown.spec.js b/src/iss-components/cart-dropdown/cart-dropdown.spec.js index 265a3e13..dcf6ddc7 100644 --- a/src/iss-components/cart-dropdown/cart-dropdown.spec.js +++ b/src/iss-components/cart-dropdown/cart-dropdown.spec.js @@ -3,7 +3,7 @@ import { createTestingPinia } from '@pinia/testing'; import cartDropdown from '@/iss-components/cart-dropdown/cart-dropdown.vue'; // Supporting Files -import {getEnumName, getMountOptions} from '@/helpers/unit-test-helper.js'; +import { getEnumName, getMountOptions } from '@/helpers/unit-test-helper.js'; import { useMainStore, getDefaultState } from '@/store'; import { formatAmountInDollars } from '@/helpers/text-helper.js'; import partTypeStrings from '@/constants/part-type-strings'; @@ -43,6 +43,7 @@ function getMountedComponent(mainInitialState = {}, initialData = {}, propsData }); useMainStore(testingPinia); + mountOptions.global.mixins[0].methods.getSettingValue = jest.fn(() => 'false'); mountOptions.global.plugins = [testingPinia]; mountOptions.data = () => (initialData); mountOptions.propsData = propsData; @@ -1338,7 +1339,6 @@ describe('cart-dropdown component', () => { const { wrapper } = getMountedComponent(storeData); formatAmountInDollars.mockReturnValueOnce(dollarAmount); - // Act const result = wrapper.vm.getDisplayed(0); diff --git a/src/iss-components/cart-dropdown/cart-dropdown.vue b/src/iss-components/cart-dropdown/cart-dropdown.vue index f181d6e8..887a99f5 100644 --- a/src/iss-components/cart-dropdown/cart-dropdown.vue +++ b/src/iss-components/cart-dropdown/cart-dropdown.vue @@ -163,6 +163,7 @@ import { formatAmountInDollars } from '@/helpers/text-helper.js'; import { getHighestFullySatisfiedTier, getPackageContents } from '@/helpers/service-package-helper.js'; // Constants +import { experimentSettings } from '@/constants/experiments'; import partTypeStrings from '@/constants/part-type-strings.js'; import cartItemType from '@/constants/cart-item-type.js'; import widgetFields from '@/constants/cms-widget-fields.js'; @@ -322,8 +323,8 @@ export default { } }); const items = vapsCartItemsNotInPackage.filter((item) => item != null); - const isRecycleFeeHidden = this.getSettingValue('HideRecycleFee') === 'true'; - const isMobileFeeHidden = this.getSettingValue('HideMobileFee') === 'true'; + const isRecycleFeeHidden = this.getSettingValue(experimentSettings.ISS_FEATURE_TOGGLE_IS_RECYCLE_FEE_HIDDEN) === 'true'; + const isMobileFeeHidden = this.getSettingValue(experimentSettings.ISS_FEATURE_TOGGLE_IS_MOBILE_FEE_HIDDEN) === 'true'; if (this.recycleFeeCartItem && !isRecycleFeeHidden) { items.push(this.recycleFeeCartItem); }