Move data members to computeds

Data members should be used for data that cannot be derived from other constants/logic
This commit is contained in:
scottkiener-at-safelite 2026-01-14 10:24:12 -05:00
parent 34199fba0c
commit 155ba5b1df

View file

@ -30,7 +30,7 @@
href="#" href="#"
@clickEvent="forwardButtonAction(options.TPA)" /> @clickEvent="forwardButtonAction(options.TPA)" />
<siteFooter <siteFooter
:ref="SITE_FOOTER_REF_NAME" :ref="componentRefs.SITE_FOOTER_REF_NAME"
class="mt-5" class="mt-5"
cmsWidgetName="SiteFooterWidget" cmsWidgetName="SiteFooterWidget"
:isForwardButtonHidden="true" :isForwardButtonHidden="true"
@ -39,10 +39,10 @@
</div> </div>
</div> </div>
<steeringModal <steeringModal
:ref="STEERING_MODAL_REF_NAME" :ref="componentRefs.STEERING_MODAL_REF_NAME"
cmsWidgetName="StateSteeringModal" /> cmsWidgetName="StateSteeringModal" />
<tpaRecalModal <tpaRecalModal
:ref="TPA_RECAL_MODAL_REF_NAME" :ref="componentRefs.TPA_RECAL_MODAL_REF_NAME"
cmsWidgetName="TPARecalModal" cmsWidgetName="TPARecalModal"
:ackError="ackError" :ackError="ackError"
@buttonClick="navigateWithTPAAck" /> @buttonClick="navigateWithTPAAck" />
@ -111,11 +111,7 @@ export default {
}); });
}, },
data() { data() {
return {
STEERING_MODAL_REF_NAME,
TPA_RECAL_MODAL_REF_NAME,
SITE_FOOTER_REF_NAME
};
}, },
computed: { computed: {
ackError() { ackError() {
@ -130,6 +126,14 @@ export default {
// Expose options for use in the template // Expose options for use in the template
options() { options() {
return options; return options;
},
// Expose component refs for use in the template
componentRefs() {
return {
STEERING_MODAL_REF_NAME,
TPA_RECAL_MODAL_REF_NAME,
SITE_FOOTER_REF_NAME
};
} }
}, },
mounted() { mounted() {