Merge pull request #746 from Safelite/SSR-1349-qa-fixes

SSR-1349 QA UI fixes.
This commit is contained in:
bmauger 2024-06-11 12:52:59 -04:00 committed by GitHub
commit 138efb9ccd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 14 deletions

View file

@ -304,12 +304,13 @@ export default {
<style lang="scss" scoped> <style lang="scss" scoped>
.alert-provide-vin { .alert-provide-vin {
font-size: 0.875rem; font-size: 0.75rem;
line-height: 1.4; line-height: 1.4;
a { a {
//Per Devyn. This can't be documented in Figma so there is a comment with the Prototype mocks on the Quote page in Figma //Per Devyn. This can't be documented in Figma so there is a comment with the Prototype mocks on the Quote page in Figma
text-underline-offset: 4px; text-underline-offset: 4px;
line-height: inherit; line-height: inherit;
font-weight: $font-weight-bold;
} }
} }

View file

@ -23,7 +23,7 @@
<vehicleQuestion <vehicleQuestion
ref="vehicleYearQuestion" ref="vehicleYearQuestion"
v-model="selectedYear" v-model="selectedYear"
class="mb-2 mt-4" class="mb-1 mt-4"
cmsWidgetName="VehicleYearQuestion" cmsWidgetName="VehicleYearQuestion"
:updateValues="updateYearValues" :updateValues="updateYearValues"
validationRules="year-required" validationRules="year-required"
@ -31,7 +31,7 @@
<vehicleQuestion <vehicleQuestion
ref="vehicleMakeQuestion" ref="vehicleMakeQuestion"
v-model="selectedMake" v-model="selectedMake"
class="mb-2 mt-4" class="mb-1 mt-4"
cmsWidgetName="VehicleMakeQuestion" cmsWidgetName="VehicleMakeQuestion"
:updateValues="updateMakeValues" :updateValues="updateMakeValues"
validationRules="make-required" validationRules="make-required"
@ -39,7 +39,7 @@
<vehicleQuestion <vehicleQuestion
ref="vehicleModelQuestion" ref="vehicleModelQuestion"
v-model="selectedModel" v-model="selectedModel"
class="mb-2 mt-4" class="mb-1 mt-4"
cmsWidgetName="VehicleModelQuestion" cmsWidgetName="VehicleModelQuestion"
:updateValues="updateModelValues" :updateValues="updateModelValues"
validationRules="model-required" validationRules="model-required"
@ -47,7 +47,7 @@
<vehicleQuestion <vehicleQuestion
ref="vehicleStyleQuestion" ref="vehicleStyleQuestion"
v-model="selectedStyle" v-model="selectedStyle"
class="mb-2 mt-4" class="mb-1 mt-4"
cmsWidgetName="VehicleStyleQuestion" cmsWidgetName="VehicleStyleQuestion"
:updateValues="updateStyleValues" :updateValues="updateStyleValues"
validationRules="style-required" validationRules="style-required"
@ -104,7 +104,7 @@ export default {
siteFooter, siteFooter,
// eslint-disable-next-line vue/no-reserved-component-names // eslint-disable-next-line vue/no-reserved-component-names
Form, Form,
vehicleQuestion, vehicleQuestion
}, },
mixins: [baseFormMixin], mixins: [baseFormMixin],
@ -116,8 +116,8 @@ export default {
const promiseResultMap = [ const promiseResultMap = [
{ {
resultKey: 'cmsContent', resultKey: 'cmsContent',
promise: cmsContentPromise, promise: cmsContentPromise
}, }
]; ];
const resultMap = await settleAllPromises(promiseResultMap); const resultMap = await settleAllPromises(promiseResultMap);
@ -129,7 +129,7 @@ export default {
}, },
props: { props: {
cmsWidgetName: String, cmsWidgetName: String,
validationRules: String, validationRules: String
}, },
data() { data() {
const { year, make, model, style } = useMainStore().order.vehicle; const { year, make, model, style } = useMainStore().order.vehicle;
@ -137,13 +137,13 @@ export default {
selectedYear: year, selectedYear: year,
selectedMake: make, selectedMake: make,
selectedModel: model, selectedModel: model,
selectedStyle: style, selectedStyle: style
}; };
}, },
computed: { computed: {
displayGeneric() { displayGeneric() {
return !this.selectedStyle; return !this.selectedStyle;
}, }
}, },
watch: { watch: {
@ -171,7 +171,7 @@ export default {
selectedStyle(value) { selectedStyle(value) {
this.mainStore.updateVehicleStyle(value); this.mainStore.updateVehicleStyle(value);
this.mainStore.setVehicle(); this.mainStore.setVehicle();
}, }
}, },
mounted() { mounted() {
this.$refs.vehicleYearQuestion.getNewValues(); this.$refs.vehicleYearQuestion.getNewValues();
@ -220,8 +220,8 @@ export default {
}, },
async updateStyleValues() { async updateStyleValues() {
return this.mainStore.getVehicleStyles(); return this.mainStore.getVehicleStyles();
}, }
}, }
}; };
</script> </script>