From 1149939337c30343384b36be3b77c3899c93fe71 Mon Sep 17 00:00:00 2001
From: Alex Humphries <Alex.Humphries@safelite.com>
Date: Mon, 29 Jun 2026 10:22:14 -0400
Subject: [PATCH] INSR-10111: Address various Copilot comments

- Add unit tests for mapStringToPhoneNumber function
- Remove console.log from mapStringToPhoneNumber function
- Update welcome-page.vue to await getCarrierAccountInfo() in setup()
- getCarrierAccountInfo() again when submitting order, in case of
  account# change
- Change import for toDisplayPhoneNumber to use absolute path
---
 src/helpers/cms-content-helper.js         | 10 ++++------
 src/helpers/cms-content-helper.spec.js    | 12 +++++++++++-
 src/layouts/welcome-page/welcome-page.vue |  4 ++--
 src/store/index.js                        |  1 +
 4 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/src/helpers/cms-content-helper.js b/src/helpers/cms-content-helper.js
index 47aade98..dae1dadb 100644
--- a/src/helpers/cms-content-helper.js
+++ b/src/helpers/cms-content-helper.js
@@ -1,6 +1,6 @@
 import dynamicStrings from '@/constants/dynamic-strings';
 import { useMainStore } from '@/store';
-import { toDisplayPhoneNumber } from './text-helper';
+import { toDisplayPhoneNumber } from '@/helpers/text-helper';
 
 /**
  * @function getStringWithCustomValues
@@ -325,18 +325,16 @@ function mapStringToState(str) {
  * @function mapStringToPhoneNumber
  * @param str
  */
-function mapStringToPhoneNumber(str) {
+export function mapStringToPhoneNumber(str) {
     const startIndex = str.indexOf(`{${dynamicStrings.PHONE_NUMBER}`);
-    console.log('startIndex', startIndex);
-    console.log('str', str);
+
     let textToReplace = str.substring(startIndex, str.length);
     textToReplace = textToReplace.substring(0, textToReplace.indexOf('}') + 1);
-    console.log('textToReplace', textToReplace);
+
     const phoneNumber = textToReplace.substring(
         dynamicStrings.PHONE_NUMBER.length + 2,
         textToReplace.length - 1
     );
-    console.log('phoneNumber', phoneNumber);
     const displayPhoneNumber = toDisplayPhoneNumber(phoneNumber);
 
     const returnVal = str.replace(textToReplace, displayPhoneNumber);
diff --git a/src/helpers/cms-content-helper.spec.js b/src/helpers/cms-content-helper.spec.js
index a69a10c5..a6a4338d 100644
--- a/src/helpers/cms-content-helper.spec.js
+++ b/src/helpers/cms-content-helper.spec.js
@@ -1,4 +1,4 @@
-import { getStringWithCustomValues } from '@/helpers/cms-content-helper.js';
+import { getStringWithCustomValues, mapStringToPhoneNumber } from '@/helpers/cms-content-helper.js';
 
 describe('getStringWithCustomValues', () => {
     test.each([
@@ -16,3 +16,13 @@ describe('getStringWithCustomValues', () => {
         expect(getStringWithCustomValues(str, customValueMap)).toBe(expected);
     });
 });
+
+describe('mapStringToPhoneNumber', () => {
+    test.each([
+        ['{phoneNumber:1234567890}', '123-456-7890'],
+        ['{phoneNumber:12345678901}', '1-234-567-8901'],
+        ['{phoneNumber:123}', ''],
+    ])('mapStringToPhoneNumber(%s) should return %s', (str, expected) => {
+        expect(mapStringToPhoneNumber(str)).toBe(expected);
+    });
+});
diff --git a/src/layouts/welcome-page/welcome-page.vue b/src/layouts/welcome-page/welcome-page.vue
index b95ba858..9e082e27 100644
--- a/src/layouts/welcome-page/welcome-page.vue
+++ b/src/layouts/welcome-page/welcome-page.vue
@@ -227,12 +227,12 @@ export default {
             vm.checkContinueFromCookie();
         });
     },
-    setup() {
+    async setup() {
         const mainStore = useMainStore();
 
         // Set order account number from the issConfig.
         mainStore.order.parentAccountNumber = mainStore.issConfig.parentAccountNumber;
-        mainStore.getCarrierAccountInfo();
+        await mainStore.getCarrierAccountInfo();
 
         return { mainStore };
     },
diff --git a/src/store/index.js b/src/store/index.js
index 5f9742df..dee920e0 100644
--- a/src/store/index.js
+++ b/src/store/index.js
@@ -3162,6 +3162,7 @@ export const useMainStore = defineStore({
             if (this.hasSubmittedOrder()) {
                 return;
             }
+            await this.getCarrierAccountInfo();
             const submittedOrder = this.order;
             const { experiments } = this.applicationUser;
             const { issConfig, hasRecalibrationPart } = this;