From 277a451ccf9cc9436561331734f00c5b1ff4570d Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Fri, 6 Mar 2026 09:56:36 -0500 Subject: [PATCH 1/5] Auto stash before merge of "develop" and "origin/develop" Fixing the issue with missing session key. --- src/constants/cookie-names.js | 3 +-- src/helpers/cookie-helper.js | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/constants/cookie-names.js b/src/constants/cookie-names.js index 9ee326f4..9a19c39f 100644 --- a/src/constants/cookie-names.js +++ b/src/constants/cookie-names.js @@ -14,8 +14,7 @@ const cookieNames = Object.freeze({ // Existing Safelite.com cookies DXDEV: 'dxdev', - SESSION_ID: 'sid', - SESSION_KEY: 'skey' + SESSION_ID: 'sid' }); const cookieExpirations = Object.freeze({ diff --git a/src/helpers/cookie-helper.js b/src/helpers/cookie-helper.js index 9f199611..9579ba51 100644 --- a/src/helpers/cookie-helper.js +++ b/src/helpers/cookie-helper.js @@ -165,7 +165,7 @@ export function getDeviceIdValue() { Gets value of skey cookie, returns 0 if not found. */ export function getSessionKeyValue() { - const cookieValue = getCookieValueByName(cookieNames.SESSION_KEY); + const cookieValue = getCookieValueByName(cookieNames.ISS_SESSION_KEY); if (cookieValue) { return cookieValue; @@ -281,7 +281,8 @@ export function setSessionIdIfUnset(value) { } export function setSessionKeyIfUnset(value) { - if (!isCookieSet(cookieNames.ISS_SESSION_KEY)) { + console.error("Current SessionKey Value: " + getSessionKeyValue() + " - New Value: " + value); + if (getSessionKeyValue() === 0) { setCookieProperties( { [cookieNames.ISS_SESSION_KEY]: value From ecf5ba48ab49260366eeea7da03c51663d6ee15c Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Fri, 6 Mar 2026 09:56:36 -0500 Subject: [PATCH 2/5] INSR-8742: Fixing the issue with missing session key. --- src/constants/cookie-names.js | 3 +-- src/helpers/cookie-helper.js | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/constants/cookie-names.js b/src/constants/cookie-names.js index 9ee326f4..9a19c39f 100644 --- a/src/constants/cookie-names.js +++ b/src/constants/cookie-names.js @@ -14,8 +14,7 @@ const cookieNames = Object.freeze({ // Existing Safelite.com cookies DXDEV: 'dxdev', - SESSION_ID: 'sid', - SESSION_KEY: 'skey' + SESSION_ID: 'sid' }); const cookieExpirations = Object.freeze({ diff --git a/src/helpers/cookie-helper.js b/src/helpers/cookie-helper.js index 9f199611..9579ba51 100644 --- a/src/helpers/cookie-helper.js +++ b/src/helpers/cookie-helper.js @@ -165,7 +165,7 @@ export function getDeviceIdValue() { Gets value of skey cookie, returns 0 if not found. */ export function getSessionKeyValue() { - const cookieValue = getCookieValueByName(cookieNames.SESSION_KEY); + const cookieValue = getCookieValueByName(cookieNames.ISS_SESSION_KEY); if (cookieValue) { return cookieValue; @@ -281,7 +281,8 @@ export function setSessionIdIfUnset(value) { } export function setSessionKeyIfUnset(value) { - if (!isCookieSet(cookieNames.ISS_SESSION_KEY)) { + console.error("Current SessionKey Value: " + getSessionKeyValue() + " - New Value: " + value); + if (getSessionKeyValue() === 0) { setCookieProperties( { [cookieNames.ISS_SESSION_KEY]: value From c2929cb68a4ca9421ad3f98da2f21bf70aa21f5f Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Fri, 6 Mar 2026 10:30:28 -0500 Subject: [PATCH 3/5] Added ref seq num + parent account number to logpage payloads. --- src/mixins/analytics-mixin.js | 15 +++++++++++---- src/store/index.js | 4 +++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/mixins/analytics-mixin.js b/src/mixins/analytics-mixin.js index 964ec5be..085aa4f9 100644 --- a/src/mixins/analytics-mixin.js +++ b/src/mixins/analytics-mixin.js @@ -46,38 +46,45 @@ export default { return ''; }, logPageView(pageEvent) { + const store = useMainStore(); const currentPageName = this.getPageNameByQueryString(); + const payload = { userId: getDeviceIdValue(), sessionKey: getSessionKeyValue(), pageName: currentPageName, + referralSequenceNumber: store.order.referralSequenceNumber, + parentAccountNumber: store.order.parentAccountNumber, sessionId: getSessionIdValue(), action: '', event: pageEvent, shouldUseSessionId: false, - experimentsForUser: useMainStore().applicationUser.experiments + experimentsForUser: store.applicationUser.experiments }; - useMainStore().logPageView(payload); + store.logPageView(payload); }, logCustomEvent(category, action, label, value) { + const store = useMainStore(); const currentPageName = this.getPageNameByQueryString(); const payload = { userId: getDeviceIdValue(), sessionKey: getSessionKeyValue(), pageName: currentPageName, + referralSequenceNumber: store.order.referralSequenceNumber, + parentAccountNumber: store.order.parentAccountNumber, sessionId: getSessionIdValue(), category, action, label, value, shouldUseSessionId: false, - experimentsForUser: useMainStore().applicationUser.experiments + experimentsForUser: store.applicationUser.experiments }; - useMainStore().logCustomEvent(payload); + store.logCustomEvent(payload); }, pushEventToGA(category, action, label, pushToLogApp = false, valueToLogType = null) { diff --git a/src/store/index.js b/src/store/index.js index 543a9c1b..40540841 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -2516,12 +2516,14 @@ export const useMainStore = defineStore({ this.logExperimentExposure(pageName, experiment); } }, - logPageView({ userId, sessionKey, pageName, sessionId, action, event, shouldUseSessionId, experimentsForUser }) { + logPageView({ userId, sessionKey, pageName, referralSequenceNumber, parentAccountNumber, sessionId, action, event, shouldUseSessionId, experimentsForUser }) { const payload = { userId, sessionKey, sessionId, pageName, + referralSequenceNumber, + parentAccountNumber, applicationName: applicationConfig.APPLICATION_NAME, action, event, From 9f35e93e3cd7b890bdbe2110f22e17ecede096ac Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Fri, 6 Mar 2026 11:47:56 -0500 Subject: [PATCH 4/5] Changed the analytics calls to not bailout on failure. --- src/mixins/analytics-mixin.js | 4 ++-- src/store/index.js | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mixins/analytics-mixin.js b/src/mixins/analytics-mixin.js index 085aa4f9..297bb8e2 100644 --- a/src/mixins/analytics-mixin.js +++ b/src/mixins/analytics-mixin.js @@ -54,7 +54,7 @@ export default { sessionKey: getSessionKeyValue(), pageName: currentPageName, referralSequenceNumber: store.order.referralSequenceNumber, - parentAccountNumber: store.order.parentAccountNumber, + parentAccountNumber: store.order.parentAccountNumber ?? 0, sessionId: getSessionIdValue(), action: '', event: pageEvent, @@ -74,7 +74,7 @@ export default { sessionKey: getSessionKeyValue(), pageName: currentPageName, referralSequenceNumber: store.order.referralSequenceNumber, - parentAccountNumber: store.order.parentAccountNumber, + parentAccountNumber: store.order.parentAccountNumber ?? 0, sessionId: getSessionIdValue(), category, action, diff --git a/src/store/index.js b/src/store/index.js index 40540841..d886006b 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -2535,7 +2535,8 @@ export const useMainStore = defineStore({ method: endpoints.LogPageView.method, endpoint: endpoints.LogPageView.url, payload, - logApiCall: false + logApiCall: false, + bailoutOnError: false }).then( (response) => response, (error) => { @@ -2564,7 +2565,8 @@ export const useMainStore = defineStore({ method: endpoints.LogCustomEvent.method, endpoint: endpoints.LogCustomEvent.url, payload, - logApiCall: false + logApiCall: false, + bailoutOnError: false }).then( (response) => response, (error) => { @@ -2592,7 +2594,8 @@ export const useMainStore = defineStore({ method: endpoints.InitializeSession.method, endpoint: endpoints.InitializeSession.url, payload, - logApiCall: false + logApiCall: false, + bailoutOnError: false }).then( (response) => response, (error) => { From 743de4c152cd6fe449d26f18612e3be39af184e6 Mon Sep 17 00:00:00 2001 From: Jeremy-Z Date: Tue, 10 Mar 2026 14:13:50 -0400 Subject: [PATCH 5/5] Removed debugging statement. --- src/helpers/cookie-helper.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/helpers/cookie-helper.js b/src/helpers/cookie-helper.js index 9579ba51..d2143424 100644 --- a/src/helpers/cookie-helper.js +++ b/src/helpers/cookie-helper.js @@ -281,7 +281,6 @@ export function setSessionIdIfUnset(value) { } export function setSessionKeyIfUnset(value) { - console.error("Current SessionKey Value: " + getSessionKeyValue() + " - New Value: " + value); if (getSessionKeyValue() === 0) { setCookieProperties( {