848e74f6ec
The isMobileStaticRecalibrationApplicable computed property in schedule.vue had incorrect operator precedence that made it far too permissive. Due to misplaced parentheses, the condition evaluated as: (displayMSR && RECAL_FEE_PART && enableMSRSplitPay) || isCashItacNoComp || isInsurable This meant ANY cash/ITAC/NoComp order OR any order with an insurable mobile fee part would be considered MSR-applicable, regardless of whether displayMSR was enabled or the mobile fee part was actually the RECAL MOBILE fee. As a result, isServiceableMobile could return true even when the backend explicitly set isRecalibrationServiceableMobile to false, causing: - Mobile schedule API calls for orders that cannot be serviced mobile - Mobile appointment type being offered when it should not be - Incorrect UI state on the schedule page The fix aligns schedule.vue with the correct logic already present in service-location.vue and service-location-june-2025.vue: displayMSR && RECAL_FEE_PART && (enableMSRSplitPay || isCashItacNoComp || isInsurable) This ensures all three base conditions (MSR experiment enabled, correct fee part, and payment eligibility) must be met before MSR is considered applicable. Co-authored-by: Mark Harris <mark.harris@safelite.com> |
||
|---|---|---|
| playwright-tests | ||
| public | ||
| src | ||
| temp | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierrc | ||
| azure-pipelines-automated-testing.yml | ||
| azure-pipelines.yml | ||
| babel.config.js | ||
| Dockerfile.playwright | ||
| environment-variables.js | ||
| jest.config.js | ||
| jsconfig.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| vue.config.js | ||
| vue.release.config.js | ||
Fix My Glass Vue Project
This Repository is for Fix My Glass front end Vue and documentation associated with it.
Routing
We are using Vue Router 4.x for our front end routing. We are using a runtime dynamic routing solution. Some more information about dynamic routing can be found on the official Vue Router documentation.
Next() - Is a function that is native to Vue Router in which we call in order to send the user where want them to go based on some logic we have. You can read more about Navigation Guards and the Next() function on the Vue Router documentation.
GetRouteInfoFromPageName(PageName) - This method typically takes the query string value of fmgPage and passes it into a call to our Content Service. The service will pull information on the page; matching page name passed to page name in our Cms. If we have a match, we will compile the route information and send it to our router to process. If we do not have a that page in our Cms, the user will be served back a 404 page while retaining the structure.
GoToFunnelStartOn404(next) - When a user tries to go to a page that doesn't exist in the CMS, they will be put back to the 'Start' of the funnel which is whatever page is marked as the homepage on Sitefinity.