From 1c55729af5e465a1f1aeb21674ac5d62c57c5528 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Mon, 14 Oct 2024 15:50:25 -0400 Subject: [PATCH 1/3] CSR-2253 CSR-2253 default option threshold on save quote email --- src/layouts/quote/quote.vue | 53 ++++++++++++++++++++++--------------- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 7722e2c09..83386e973 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -299,8 +299,9 @@ export default { const getIsInsuranceSelectedValue = (availableLineItems, insuranceThreshold) => { const serviceLocationState = store.getters.order.serviceLocation.state; - // Override if coming back from QuoteDetails. Remove override after Quote release - const isInsuranceOverrideValue = to.query?.isInsurance; + + // usually true when returning from heritage but can be false when returning from heritage on a save quote + const isInsuranceFromQueryString = to.query?.isInsurance; const defaultIsInsuranceSelectedValue = store.getters.order.payment.isInsurance; const hideRecalCost = experimentMixin.methods @@ -311,34 +312,42 @@ export default { if ( serviceLocationState != null && payWithInsuranceStates.find((item) => item === serviceLocationState) - ) + ) { return true; - else if (isInsuranceOverrideValue != null) { - return isInsuranceOverrideValue == "true"; - } else if (defaultIsInsuranceSelectedValue != null) { - return defaultIsInsuranceSelectedValue; - } else { - if (availableLineItems) { - const lineItemsForCalculatingPrice = hideRecalCost - ? baseMixin.methods.filterOutFees( - baseMixin.methods.filterOutRecalibration(availableLineItems) // Strip out recal before filtering out fees - ) - : baseMixin.methods.filterOutFees(availableLineItems); - - return ( - baseMixin.methods.getTierOnePackagePrice(lineItemsForCalculatingPrice) > - insuranceThreshold - ); // compare base price vs arbitrary threshold (representing insurance price) - } else { - return null; - } } + + if (defaultIsInsuranceSelectedValue != null) { + return defaultIsInsuranceSelectedValue; + } + + if (availableLineItems) { + const lineItemsForCalculatingPrice = hideRecalCost + ? baseMixin.methods.filterOutFees( + baseMixin.methods.filterOutRecalibration(availableLineItems) // Strip out recal before filtering out fees + ) + : baseMixin.methods.filterOutFees(availableLineItems); + + if (isInsuranceFromQueryString != null) { + if (isInsuranceFromQueryString == "true") { + return true; + } + } + + return ( + baseMixin.methods.getTierOnePackagePrice(lineItemsForCalculatingPrice) > + insuranceThreshold + ); // compare base price vs arbitrary threshold (representing insurance price) + } + + return null; }; + let thresholdToUse = INSURANCE_TAB_TO_DISPLAY_THRESHOLD_DEFAULT; let internalThreshold = experimentMixin.methods.getSettingValue( experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL ); const isExternalParameter = store.getters.externalParameterState?.isExternalParameter; + console.log("parm:" + isExternalParameter); if (isExternalParameter === externalParameterStatus.NOT_SET) { // there are no active or inactive external parameters; use internal threshold From b383418c5b76eedc06203e6c95e1bbee0d162c4b Mon Sep 17 00:00:00 2001 From: CarlNation Date: Mon, 14 Oct 2024 15:52:04 -0400 Subject: [PATCH 2/3] remove console.log remove console.log --- src/layouts/quote/quote.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 83386e973..61f966a3f 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -347,7 +347,6 @@ export default { experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL ); const isExternalParameter = store.getters.externalParameterState?.isExternalParameter; - console.log("parm:" + isExternalParameter); if (isExternalParameter === externalParameterStatus.NOT_SET) { // there are no active or inactive external parameters; use internal threshold From ff104643032afe4a6b1692981f358f8daeec36c5 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Tue, 15 Oct 2024 07:05:18 -0400 Subject: [PATCH 3/3] CSR-2253 CSR-2253 --- src/layouts/quote/quote.spec.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/layouts/quote/quote.spec.js b/src/layouts/quote/quote.spec.js index c83801693..24b37d376 100644 --- a/src/layouts/quote/quote.spec.js +++ b/src/layouts/quote/quote.spec.js @@ -376,7 +376,7 @@ describe("quote.vue", () => { //Assert expect(wrapper.vm.isInsuranceSelected).toBe(true); }); - test("should default to cash if query param 'isInsurance' is false", async () => { + test("should use amount threshold if query param 'isInsurance' is false", async () => { //Arrange store.getters = { lineItems: { @@ -403,6 +403,7 @@ describe("quote.vue", () => { settingName: "SERVICE_PACKAGE_DISCOUNT", }, }; + mockTierOnePrice = 200; const { wrapper } = setupMocks({}); //Act