From f64b6ad31c6a8cf4efbb0ebe7a5d61a55b2862b3 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Wed, 25 Oct 2023 14:57:19 -0400 Subject: [PATCH] A couple, not all, code review changes --- src/fmg-components/cart/cart.vue | 2 +- .../add-vaps-modal-buttons/add-vaps-modal-buttons.vue | 7 ------- src/layouts/payment-method/payment-method.vue | 10 +++++----- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/fmg-components/cart/cart.vue b/src/fmg-components/cart/cart.vue index 26fa7866a..5a2ea7a70 100644 --- a/src/fmg-components/cart/cart.vue +++ b/src/fmg-components/cart/cart.vue @@ -79,7 +79,7 @@ import { getHighestFullySatisfiedTier, getPackageContents } from "@/helpers/serv import textLink from "@/ux-components/text-link/text-link"; import textBlock from "@/digital-components/text-block/text-block"; import { LineItemUtilities } from "@/store"; -import { deepClone } from "@/helpers/object-helper"; + export default { name: "cart", diff --git a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue index ccbb8c8d1..3fc426d63 100644 --- a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue +++ b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue @@ -156,13 +156,6 @@ export default { return answers; }, }, - watch: { - modelValue: { - handler(newValue) { - console.log(newValue); - }, - }, - }, components: { buttonQuestion, contentGroupModal, diff --git a/src/layouts/payment-method/payment-method.vue b/src/layouts/payment-method/payment-method.vue index e9c966628..9b9a74784 100644 --- a/src/layouts/payment-method/payment-method.vue +++ b/src/layouts/payment-method/payment-method.vue @@ -148,7 +148,7 @@ export default { ...glassParts, ]; - const lineItems = store.getters.order.lineItems; + const lineItemsFromStore = store.getters.order.lineItems; await baseMixin.methods.dispatchStoreActionWithLogging( storeActions.PRICE_ORDER_ITEMS_AND_SAVE_SERVER_DATA, @@ -176,21 +176,21 @@ export default { const lineItemUtilities = new LineItemUtilities(); lineItemUtilities.addGuidToLineItemsIfNotAlreadyThere(availableLineItems); - const cartLineItems = mapTaxedAvailableLineItemsToStoreFormat( + const lineItems = mapTaxedAvailableLineItemsToStoreFormat( availableLineItems, - lineItems + lineItemsFromStore ); // Call the "next" function to complete the transition to this page. next((vm) => { vm.setCmsContent(resultMap.cmsContent); vm.availableLineItems = taxedAvailableLineItems; - vm.cartLineItems = cartLineItems; + vm.lineItems = lineItems; }); }, data() { return { - cartLineItems: [], + lineItems: [], availableLineItems: [], paymentMethodInternalModel: this.getPaymentMethodFromStore(), };