jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1144 from Safelite/feature/CSR-1368-tr

Browse source 
Address tech review comments
This commit is contained in:
chloeherdsafelite 2023-06-05 16:24:15 -04:00 committed by GitHub
commit f456f384db
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/layouts/review/review.vue
View file

@ -40,7 +40,7 @@
<vehicleReview <vehicleReview
cmsWidgetName="VehicleReviewWidget" cmsWidgetName="VehicleReviewWidget"
:vehicle="vehicleInfo" :vehicle="vehicleInfo"
@edit-clicked="navigateToVehicleYear" /> @edit-clicked="editVehicle" />
</div> </div>
<hr class="my-0" /> <hr class="my-0" />
@ -93,9 +93,9 @@ export default {
}, },
backButtonAction() {}, backButtonAction() {},
forwardButtonAction() {}, forwardButtonAction() {},
navigateToVehicleYear() { editVehicle() {
this.$router.navigateWithoutSaving( this.$router.navigateWithoutSaving(
this.navigationScenarios.REVIEW_VEHICLE_EDIT, this.navigationScenarios.CLICKED_VEHICLE_EDIT,
this.$route this.$route
); );
}, },

2
src/router/router-constants/navigation-scenarios.js
View file

@ -50,7 +50,7 @@ const navigationScenarios = {
SELECTED_LOCATION: "SELECTED_LOCATION", SELECTED_LOCATION: "SELECTED_LOCATION",
// Review // Review
REVIEW_VEHICLE_EDIT: "REVIEW_VEHICLE_EDIT", CLICKED_VEHICLE_EDIT: "CLICKED_VEHICLE_EDIT",
}; };
export { navigationScenarios }; export { navigationScenarios };

2
src/router/router-constants/routing-table.js
View file

@ -439,7 +439,7 @@ const routingTable = function (store) {
fmgPageValue: fmgPageValues.REVIEW, fmgPageValue: fmgPageValues.REVIEW,
maps: [ maps: [
{ {
scenario: navigationScenarios.REVIEW_VEHICLE_EDIT, scenario: navigationScenarios.CLICKED_VEHICLE_EDIT,
destinationFmgPageValue: fmgPageValues.VEHICLE_YEAR, destinationFmgPageValue: fmgPageValues.VEHICLE_YEAR,
}, },
], ],