From 26e3023995fe86cc4b74459b5dab31968c6c87f1 Mon Sep 17 00:00:00 2001 From: Donielle Austin Date: Mon, 9 May 2022 15:01:57 -0400 Subject: [PATCH 1/7] ui defect --- src/layouts/estimate/estimate.vue | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/layouts/estimate/estimate.vue b/src/layouts/estimate/estimate.vue index 67b1918e1..8c7db34dc 100644 --- a/src/layouts/estimate/estimate.vue +++ b/src/layouts/estimate/estimate.vue @@ -10,9 +10,14 @@
+ \ No newline at end of file + + + \ No newline at end of file From 89633cec71c50325b0cb3d0b354a46792985f2d0 Mon Sep 17 00:00:00 2001 From: Donielle Austin Date: Mon, 9 May 2022 15:07:58 -0400 Subject: [PATCH 2/7] ui defect --- src/layouts/estimate/estimate.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/estimate/estimate.vue b/src/layouts/estimate/estimate.vue index 8c7db34dc..708e532f1 100644 --- a/src/layouts/estimate/estimate.vue +++ b/src/layouts/estimate/estimate.vue @@ -13,7 +13,7 @@ Date: Mon, 9 May 2022 15:17:46 -0400 Subject: [PATCH 3/7] CSR-520 remove close modal gold plating --- .../loading-modal/loading-modal.spec.js | 56 +------------------ .../loading-modal/loading-modal.vue | 27 +-------- src/layouts/address-lookup/address-lookup.vue | 2 +- .../license-plate-lookup.vue | 2 +- src/layouts/vin-lookup/vin-lookup.vue | 2 +- 5 files changed, 7 insertions(+), 82 deletions(-) diff --git a/src/common-components/loading-modal/loading-modal.spec.js b/src/common-components/loading-modal/loading-modal.spec.js index ca7717cca..7a500ce73 100644 --- a/src/common-components/loading-modal/loading-modal.spec.js +++ b/src/common-components/loading-modal/loading-modal.spec.js @@ -17,7 +17,7 @@ jest.mock('@/assets/img/windshield.png', () => 'windshield.png') describe("loadingModal", () => { test("showModal sets modal visible", async () => { // Arrange - const { wrapper } = setupMocks({ clickOutCloses: false }); + const { wrapper } = setupMocks(); wrapper.vm.isModalVisible = false; //Act @@ -30,54 +30,7 @@ describe("loadingModal", () => { }); -describe("loadingModal", () => { - test("closeModal sets modal not visible", async () => { - // Arrange - const { wrapper } = setupMocks({ clickOutCloses: false }); - wrapper.vm.isModalVisible = true; - - //Act - wrapper.vm.closeModal(); - - // Assert - expect(wrapper.vm.isModalVisible).toEqual(false); - wrapper.unmount(); - }); -}); - -describe("loadingModal", () => { - test("canClose calls closeModal", async () => { - // Arrange - const { wrapper } = setupMocks({ clickOutCloses: true }); - wrapper.vm.isModalVisible = true; - - //Act - wrapper.vm.canClose(); - - // Assert - expect(wrapper.vm.isModalVisible).toEqual(false); - wrapper.unmount(); - }); -}); - -describe("loadingModal", () => { - test("canClose does not call closeModal", async () => { - // Arrange - const { wrapper } = setupMocks({ clickOutCloses: false }); - wrapper.vm.isModalVisible = true; - - //Act - wrapper.vm.canClose(); - - // Assert - expect(wrapper.vm.isModalVisible).toEqual(true); - wrapper.unmount(); - }); -}); - -function setupMocks({ - clickOutCloses -}) { +function setupMocks() { //Mock store store.dispatch = jest.fn(() => {}); @@ -89,9 +42,6 @@ function setupMocks({ }, }); - //Mock props - mountOptions.propsData = { clickOutCloses: clickOutCloses }; const wrapper = shallowMount(loadingModal, mountOptions); - return { wrapper }; -} +} \ No newline at end of file diff --git a/src/common-components/loading-modal/loading-modal.vue b/src/common-components/loading-modal/loading-modal.vue index 4f1365802..9665c6ea5 100644 --- a/src/common-components/loading-modal/loading-modal.vue +++ b/src/common-components/loading-modal/loading-modal.vue @@ -1,7 +1,6 @@