From e538f4d8c2ee8e5382db458597f39c2722c58394 Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 18 Sep 2024 15:32:07 -0400 Subject: [PATCH 1/2] CSR-2166: add experiments as an externalParameter in store and capture in router --- src/constants/query-strings.js | 1 + src/constants/store-mutations.js | 1 + src/router/index.js | 7 +++++++ src/store/index.js | 6 ++++++ 4 files changed, 15 insertions(+) diff --git a/src/constants/query-strings.js b/src/constants/query-strings.js index 9fb379836..3cdfd655f 100644 --- a/src/constants/query-strings.js +++ b/src/constants/query-strings.js @@ -44,6 +44,7 @@ const queryStrings = { CJUNCTION: "cjunction", ORGANIC: "organic", ORGANIC_SOCIAL: "organic_social", + EXPERIMENTS: "experiments", }; export { queryStrings }; diff --git a/src/constants/store-mutations.js b/src/constants/store-mutations.js index 494be36e3..a2e630454 100644 --- a/src/constants/store-mutations.js +++ b/src/constants/store-mutations.js @@ -103,6 +103,7 @@ const storeMutations = { UPDATE_EXTERNAL_PARAMETER_IS_INSURANCE: "updateExternalParameterIsInsurance", UPDATE_EXTERNAL_PARAMETER_VIN_SELECTION: "updateExternalParameterVinSelection", UPDATE_EXTERNAL_PARAMETER_SERVICE_PACKAGE: "updateExternalParameterServicePackage", + UPDATE_EXTERNAL_PARAMETER_EXPERIMENTS: "updateExternalParameterExperiments", //RESET EXTERNAL_PARAMETER MUTATIONS RESET_EXTERNAL_PARAMETER_VEHICLE_STATE: "resetExternalParameterVehicleState", diff --git a/src/router/index.js b/src/router/index.js index 4549f9e7c..c58151002 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -615,6 +615,7 @@ function updateExternalParameterState() { const externalParameterVinSelection = getQuerystringParameter(queryStrings.VIN_SELECTION); const externalParameterServicePackage = getQuerystringParameter(queryStrings.SERVICE_PACKAGE); const externalParameterNumberOfChips = getQuerystringParameter(queryStrings.NUMBER_OF_CHIPS); + const externalParameterExperiments = getQuerystringParameter(queryStrings.EXPERIMENTS); if ( externalParameterYear && externalParameterMake && @@ -664,6 +665,12 @@ function updateExternalParameterState() { externalParameterVinSelection ); } + if (externalParameterExperiments) { + store.commit( + storeMutations.UPDATE_EXTERNAL_PARAMETER_EXPERIMENTS, + externalParameterExperiments + ); + } } export default router; diff --git a/src/store/index.js b/src/store/index.js index 6faeab921..587f71df8 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -472,6 +472,10 @@ export const mutations = { externalParameterState.quote.servicePackage = servicePackage; saveExternalParameterState(externalParameterState); }, + updateExternalParameterExperiments(state, experiments) { + externalParameterState.quote.experiments = experiments; + saveExternalParameterState(externalParameterState); + }, //RESET ExternalParameter MUTATIONS resetExternalParameterVehicleState(state) { externalParameterState.vehicle.year = null; @@ -500,6 +504,7 @@ export const mutations = { resetExternalParameterQuoteState(state) { externalParameterState.quote.isInsurance = null; externalParameterState.quote.servicePackage = null; + externalParameterState.quote.experiments = null; saveExternalParameterState(externalParameterState); }, resetIsExternalParameter(state) { @@ -3402,6 +3407,7 @@ function createExternalParameterDefaultState() { quote: { isInsurance: null, servicePackage: null, + experiments: null, }, }; // set to session storage From 0ca54edddf80b22990a89c96cb2380b2dcd95111 Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Thu, 19 Sep 2024 10:01:01 -0400 Subject: [PATCH 2/2] CSR-2166: updates to external parameter naming --- src/constants/store-mutations.js | 2 +- src/router/index.js | 8 ++++---- src/store/index.js | 11 +++++++---- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/constants/store-mutations.js b/src/constants/store-mutations.js index a2e630454..c03d51432 100644 --- a/src/constants/store-mutations.js +++ b/src/constants/store-mutations.js @@ -103,7 +103,7 @@ const storeMutations = { UPDATE_EXTERNAL_PARAMETER_IS_INSURANCE: "updateExternalParameterIsInsurance", UPDATE_EXTERNAL_PARAMETER_VIN_SELECTION: "updateExternalParameterVinSelection", UPDATE_EXTERNAL_PARAMETER_SERVICE_PACKAGE: "updateExternalParameterServicePackage", - UPDATE_EXTERNAL_PARAMETER_EXPERIMENTS: "updateExternalParameterExperiments", + UPDATE_EXTERNAL_PARAMETER_SOURCE: "updateExternalParameterSource", //RESET EXTERNAL_PARAMETER MUTATIONS RESET_EXTERNAL_PARAMETER_VEHICLE_STATE: "resetExternalParameterVehicleState", diff --git a/src/router/index.js b/src/router/index.js index c58151002..83a7b0148 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -615,7 +615,7 @@ function updateExternalParameterState() { const externalParameterVinSelection = getQuerystringParameter(queryStrings.VIN_SELECTION); const externalParameterServicePackage = getQuerystringParameter(queryStrings.SERVICE_PACKAGE); const externalParameterNumberOfChips = getQuerystringParameter(queryStrings.NUMBER_OF_CHIPS); - const externalParameterExperiments = getQuerystringParameter(queryStrings.EXPERIMENTS); + const externalParameterSource = getQuerystringParameter(queryStrings.EXPERIMENTS); if ( externalParameterYear && externalParameterMake && @@ -665,10 +665,10 @@ function updateExternalParameterState() { externalParameterVinSelection ); } - if (externalParameterExperiments) { + if (externalParameterSource) { store.commit( - storeMutations.UPDATE_EXTERNAL_PARAMETER_EXPERIMENTS, - externalParameterExperiments + storeMutations.UPDATE_EXTERNAL_PARAMETER_SOURCE, + externalParameterSource ); } } diff --git a/src/store/index.js b/src/store/index.js index 587f71df8..6ed37e445 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -472,8 +472,8 @@ export const mutations = { externalParameterState.quote.servicePackage = servicePackage; saveExternalParameterState(externalParameterState); }, - updateExternalParameterExperiments(state, experiments) { - externalParameterState.quote.experiments = experiments; + updateExternalParameterSource(state, source) { + externalParameterState.source = source; saveExternalParameterState(externalParameterState); }, //RESET ExternalParameter MUTATIONS @@ -504,7 +504,10 @@ export const mutations = { resetExternalParameterQuoteState(state) { externalParameterState.quote.isInsurance = null; externalParameterState.quote.servicePackage = null; - externalParameterState.quote.experiments = null; + saveExternalParameterState(externalParameterState); + }, + resetExternalParameterSourceState(state) { + externalParameterState.source = null; saveExternalParameterState(externalParameterState); }, resetIsExternalParameter(state) { @@ -3407,8 +3410,8 @@ function createExternalParameterDefaultState() { quote: { isInsurance: null, servicePackage: null, - experiments: null, }, + source: null, }; // set to session storage saveExternalParameterState(externalParameterDefaultState);