jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CSR-1843: fix places where link causes scroll to top

Browse source
This commit is contained in:
Adam Caouette 2023-11-29 08:04:31 -05:00
parent 7f37cd6db1
commit e725baf852
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/fmg-components/cart/cart.vue
View file

@ -7,7 +7,7 @@
@click="toggleIsExpanded()"> @click="toggleIsExpanded()">
<a <a
aria-label="expand cart" aria-label="expand cart"
href="#!" href="javascript:void(0)"
class="col d-flex justify-content-between py-0"> class="col d-flex justify-content-between py-0">
<span class="label">{{ amountDueText }}</span> <span class="label">{{ amountDueText }}</span>
<span class="label amount-due">{{ getFormattedAmount("", amountDue) }}</span> <span class="label amount-due">{{ getFormattedAmount("", amountDue) }}</span>
@ -30,7 +30,7 @@
ref="removeLink" ref="removeLink"
linkType="text" linkType="text"
:text="removeLinkText" :text="removeLinkText"
href="#!" href="javascript:void(0)"
@click-event="removeItem(cartItem.cartItemType, cartItem.category)"> @click-event="removeItem(cartItem.cartItemType, cartItem.category)">
<template v-slot:after-text> <template v-slot:after-text>
<span class="sr-only">{{ cartItem.name }}</span> <span class="sr-only">{{ cartItem.name }}</span>
@ -53,13 +53,13 @@
ref="removeLink" ref="removeLink"
linkType="text" linkType="text"
:text="removeLinkText" :text="removeLinkText"
href="#!" href="javascript:void(0)"
@click-event="removeItem(cartItem.cartItemType, cartItem.category)" /> @click-event="removeItem(cartItem.cartItemType, cartItem.category)" />
<textLink <textLink
v-else-if="cartItem == recycleFeeCartItem && recyclingModalCmsWidgetName" v-else-if="cartItem == recycleFeeCartItem && recyclingModalCmsWidgetName"
linkType="text" linkType="text"
:text="recycleFeeCartItem.name" :text="recycleFeeCartItem.name"
href="#!" href="javascript:void(0)"
@click-event="openModal(recyclingModalCmsWidgetName)" /> @click-event="openModal(recyclingModalCmsWidgetName)" />
<span v-else-if="cartItem == recycleFeeCartItem"> <span v-else-if="cartItem == recycleFeeCartItem">
{{ recycleFeeCartItem.name }} {{ recycleFeeCartItem.name }}

4
src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
View file

@ -4,7 +4,7 @@
id="promoLinkPromptId" id="promoLinkPromptId"
linkType="text" linkType="text"
:text="promoLinkText" :text="promoLinkText"
href="#!" href="javascript:void(0)"
@click-event="openModal" /> @click-event="openModal" />
<modal <modal
:ref="modalName" :ref="modalName"
@ -57,7 +57,7 @@
ref="removeLink" ref="removeLink"
linkType="text" linkType="text"
:text="removeLinkText" :text="removeLinkText"
href="#!" href="javascript:void(0)"
@click-event="removeItem(promoCode)" /> @click-event="removeItem(promoCode)" />
</div> </div>
</modal> </modal>