From f2b4cd5e90e9fcdbfd89cb503baafc86022c01bb Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 19 Feb 2025 15:11:01 -0500 Subject: [PATCH 1/3] CASH-153: updates after tech review --- ...-2.vue => date-picker-for-pricing-by-day.vue} | 14 +++++++++++--- src/layouts/schedule/schedule.vue | 16 +++++++++------- 2 files changed, 20 insertions(+), 10 deletions(-) rename src/experiment-components/{date-picker-2.vue => date-picker-for-pricing-by-day.vue} (99%) diff --git a/src/experiment-components/date-picker-2.vue b/src/experiment-components/date-picker-for-pricing-by-day.vue similarity index 99% rename from src/experiment-components/date-picker-2.vue rename to src/experiment-components/date-picker-for-pricing-by-day.vue index 414f794e0..df4c9b140 100644 --- a/src/experiment-components/date-picker-2.vue +++ b/src/experiment-components/date-picker-for-pricing-by-day.vue @@ -99,8 +99,16 @@ // Supporting files import loader from "@/ux-components/loader/loader"; import store from "@/store"; -import { TIMINGFUNC_MAP, BUFFER_OFFSET, MONTHS_OF_YEAR } from "@/digital-components/date-picker/mixins/constants"; -import { selectableDaysOptions, requiredParameter, forceTwoDigitString } from "@/digital-components/date-picker/mixins/helpers"; +import { + TIMINGFUNC_MAP, + BUFFER_OFFSET, + MONTHS_OF_YEAR, +} from "@/digital-components/date-picker/mixins/constants"; +import { + selectableDaysOptions, + requiredParameter, + forceTwoDigitString, +} from "@/digital-components/date-picker/mixins/helpers"; import { convertDateToDateString, convertDateStringToDate, @@ -111,7 +119,7 @@ import { deepClone } from "@/helpers/object-helper"; import { v4 as uuidv4 } from "uuid"; export default { - name: "datePicker2", + name: "datePickerForPricingByDay", data() { return { isLoading: true, diff --git a/src/layouts/schedule/schedule.vue b/src/layouts/schedule/schedule.vue index 0853664e2..27587d08c 100644 --- a/src/layouts/schedule/schedule.vue +++ b/src/layouts/schedule/schedule.vue @@ -18,8 +18,8 @@ marginTopSizeOverride="1" /> - - Date: Fri, 21 Feb 2025 18:15:56 +0530 Subject: [PATCH 2/3] CASH-151 remove extra spacing from service packages tiles --- src/experiment-components/service-package-radio.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/experiment-components/service-package-radio.vue b/src/experiment-components/service-package-radio.vue index a3bfd9937..4aae00bc0 100644 --- a/src/experiment-components/service-package-radio.vue +++ b/src/experiment-components/service-package-radio.vue @@ -233,8 +233,7 @@ export default { min-height: 52px; max-height: 126px; @include media-breakpoint-up(md) { - max-height: 500px; - padding-bottom: 3rem; + max-height: 500px; } transition: max-height 0.25s ease-in; From 75345b9f9d79200bef8155ebb0c121a68e84ee89 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Fri, 21 Feb 2025 14:28:16 -0500 Subject: [PATCH 3/3] CASH-291 CASH-291 cannot recreate locally. adding some debug info to try and determine in dev/sys or qa --- src/layouts/quote/quote.vue | 36 ++++++++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index eb8268551..838fbf256 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -367,10 +367,18 @@ export default { } } - return ( - baseMixin.methods.getTierOnePackagePrice(lineItemsForCalculatingPrice) > - insuranceThreshold - ); // compare base price vs arbitrary threshold (representing insurance price) + const tierOnePrice = baseMixin.methods.getTierOnePackagePrice(lineItemsForCalculatingPrice); + // prettier-ignore + { + if (store.getters.applicationUser.loggingOption) { + console.log(new Date() + " tierOnePrice type: " + typeof tierOnePrice); + console.log(new Date() + " insuranceThreshold type: " + typeof insuranceThreshold); + console.log(new Date() + " tierOnePrice comparison: " + tierOnePrice + " > " + insuranceThreshold + "=" + (tierOnePrice > insuranceThreshold)); + } + } + + // compare base price vs arbitrary threshold (representing insurance price) + return (tierOnePrice > insuranceThreshold); } return null; @@ -397,6 +405,12 @@ export default { } if (isExternalParameter === externalParameterStatus.NOT_SET) { + // prettier-ignore + { + if (store.getters.applicationUser.loggingOption) { + console.log(new Date() + "quote.vue tab select EXTERNAL not set"); + } + } // there are no active or inactive external parameters; use internal threshold if (internalThreshold) thresholdToUse = internalThreshold; @@ -408,6 +422,13 @@ export default { } else { // user came from an external source, however, the externalParms may have been reset on service-zip, property-questions, etc... if (getBoolFromString(store.getters.externalParameterQuote?.isInsurance)) { + // prettier-ignore + { + if (store.getters.applicationUser.loggingOption) { + console.log(new Date() + "quote.vue tab select EXTERNAL ISINSURANCE"); + } + } + // did user intentionally select insurance? vm.isInsuranceSelected = true; vm.servicePackage = store.getters.externalParameterQuote.servicePackage; @@ -427,6 +448,13 @@ export default { } else { if (externalThreshold) thresholdToUse = externalThreshold; + // prettier-ignore + { + if (store.getters.applicationUser.loggingOption) { + console.log(new Date() + "quote.vue tab select NOT EXTERNAL"); + } + } + vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.availableLineItems, thresholdToUse