jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1296 from Safelite/feature/CSR-1582-revert-first-pr

Browse source 
Revert "Merge pull request #1278 from Safelite/feature/CSR-1582"
This commit is contained in:
scottkiener 2023-08-07 17:13:14 -04:00 committed by GitHub
commit e3dfbb6a47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/helpers/heritage-integration/navigation-helper.js
View file

@ -98,7 +98,7 @@ export async function skipVinLookupNotRepair() {
/* /*
Logic for getting the last "valid" page a user visited. Logic for getting the last "valid" page a user visited.
*/ */
export async function getLatestPageForRedirection() { async function getLatestPageForRedirection() {
// If this is a non-CTA navigation, determine where to send the user based on page prerequisites. // If this is a non-CTA navigation, determine where to send the user based on page prerequisites.
// This also works if a user has a 'fmg' start_type query string but no current order. // This also works if a user has a 'fmg' start_type query string but no current order.
// That shouldn't happen, but it's possible. // That shouldn't happen, but it's possible.

16
src/router/index.js
View file

@ -19,7 +19,6 @@ import { loadSessionIfPresent, saveSession } from "@/helpers/heritage-integratio
import { import {
getPageToRouteExistingOrderTo, getPageToRouteExistingOrderTo,
navigateToHeritageFunnel, navigateToHeritageFunnel,
getLatestPageForRedirection,
} from "@/helpers/heritage-integration/navigation-helper"; } from "@/helpers/heritage-integration/navigation-helper";
import baseMixin from "@/mixins/base-mixin"; import baseMixin from "@/mixins/base-mixin";
@ -125,21 +124,8 @@ const routes = [
.filter((x) => x.name === routeData[0].name)[0] .filter((x) => x.name === routeData[0].name)[0]
.components.default(); .components.default();
// The save quote link via heritage default.aspx... will land here.
// Heritage will attempt to send the customer to the lastest page in NextGen possible.
// If the link was created prior to reaching the end of NextGen, the save quote link
// was going to GoToFunnelStartOn404. This will send as deep into NextGen as possible.
if (!arePagePrerequisitesValid(nextComponent)) { if (!arePagePrerequisitesValid(nextComponent)) {
var pageToRedirectTo = await getLatestPageForRedirection(); await GoToFunnelStartOn404(next);
if (pageToRedirectTo) {
return next({
path: "/",
query: { fmgPage: pageToRedirectTo },
params: to.params,
});
} else {
await GoToFunnelStartOn404(next);
}
} }
// Assign current query string parameters, as well as our fmgPage one. // Assign current query string parameters, as well as our fmgPage one.