From e31f415aa4cb5fe06c89ec7579d1d956a1a0943b Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Tue, 26 Jul 2022 10:38:10 -0400 Subject: [PATCH] CSR-110: refactoring per PR review --- src/layouts/molding-questions/molding-questions.vue | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/layouts/molding-questions/molding-questions.vue b/src/layouts/molding-questions/molding-questions.vue index 04259a3c3..0ffaae411 100644 --- a/src/layouts/molding-questions/molding-questions.vue +++ b/src/layouts/molding-questions/molding-questions.vue @@ -141,11 +141,9 @@ export default { // call API parts method const partsLookup = await this.dispatchStoreAction(storeActions.GET_PARTS) .catch(() => { - this.$refs.funnelFooter.removeLoader(); + return this.$refs.funnelFooter.removeLoader(); }); - if (!partsLookup) { return } - const glassNameAndPartsForStore = partsLookup.data.glassNameAndPartsForStore; console.log("glassNameAndPartsForStore: ", glassNameAndPartsForStore); @@ -236,11 +234,11 @@ export default { } }); if (!hasMultipleParts) { - store.commit(storeMutations.UPDATE_GLASS_PARTS, collectedGlassParts); + this.$store.commit(storeMutations.UPDATE_GLASS_PARTS, collectedGlassParts); } this.navigateForward(hasMultipleParts, glassNameAndPartsForStore); }, - async navigateForward(hasMultipleParts, glassNameAndPartsForStore) { + navigateForward(hasMultipleParts, glassNameAndPartsForStore) { if (hasMultipleParts) { // if multiple parts on any glass // go to vehicle-parts page and pass the partsData