From 02b5e92bc829c18b1817a1689f7709111aa8fecf Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Thu, 25 Jul 2024 11:33:01 -0400 Subject: [PATCH 1/5] Frontend changes to not log errors for 404s --- src/global-methods.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/global-methods.js b/src/global-methods.js index c471a8c63..02118db1e 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -97,16 +97,18 @@ export default { true ); } - - // Do not route to error logic when no wipers found or no promo found (404s) + if (error.response.status != "404") { - //router.navigateError(); Emergency change for testing - skiener 03/12 - } + // Do not route to error logic when no wipers found or no promo found (404s) + // router.navigateError(); Emergency change for testing - skiener 03/12 - global.$logger.logError( - `${method}: ${endpoint}: ${error.message}`, - error.response - ); + // do not log 404 errors from services because we return NotFound + // when a service doesn't return an object + global.$logger.logError( + `${method}: ${endpoint}: ${error.message}`, + error.response + ); + } return reject(error.response); } From 2dee21887ae152c165cff6f3356d045a53f6293d Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Thu, 25 Jul 2024 11:45:10 -0400 Subject: [PATCH 2/5] Prettified --- src/global-methods.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/global-methods.js b/src/global-methods.js index 02118db1e..85fd02841 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -97,12 +97,12 @@ export default { true ); } - + if (error.response.status != "404") { // Do not route to error logic when no wipers found or no promo found (404s) // router.navigateError(); Emergency change for testing - skiener 03/12 - // do not log 404 errors from services because we return NotFound + // do not log 404 errors from services because we return NotFound // when a service doesn't return an object global.$logger.logError( `${method}: ${endpoint}: ${error.message}`, From 95b3ef7cc68f7276cb42f3c786e369c06f283539 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Tue, 6 Aug 2024 06:36:23 -0400 Subject: [PATCH 3/5] Added back router.navigateError for errors other than 404. --- src/global-methods.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/global-methods.js b/src/global-methods.js index 85fd02841..1c37ae92d 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -56,12 +56,16 @@ export default { additionalSuccessEventDataHandler, }) { return new Promise((resolve, reject) => { - const cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; + let cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; const payloadAndAnalyticsData = Object.assign({}, payload, { AppName: "FixMyGlass" }); const headers = { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings), }; + if (endpoint.includes("/vehicle/api/v1/vehicle/")) { + cfDistroUrl = "https://localhost:5001"; + } + axios({ method: method, url: cfDistroUrl + endpoint, @@ -100,7 +104,7 @@ export default { if (error.response.status != "404") { // Do not route to error logic when no wipers found or no promo found (404s) - // router.navigateError(); Emergency change for testing - skiener 03/12 + router.navigateError(); // do not log 404 errors from services because we return NotFound // when a service doesn't return an object From de7eb15032ab7803065fff886a00b82f7a063043 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Tue, 6 Aug 2024 07:06:35 -0400 Subject: [PATCH 4/5] Removed temp redirection to local vehicle service --- src/global-methods.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/global-methods.js b/src/global-methods.js index 1c37ae92d..9cb2696ff 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -62,10 +62,6 @@ export default { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings), }; - if (endpoint.includes("/vehicle/api/v1/vehicle/")) { - cfDistroUrl = "https://localhost:5001"; - } - axios({ method: method, url: cfDistroUrl + endpoint, From e50d4449285a91c7b9083bb45d10a050e6b9fc33 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Tue, 6 Aug 2024 07:08:15 -0400 Subject: [PATCH 5/5] Another local redirect fix --- src/global-methods.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/global-methods.js b/src/global-methods.js index 9cb2696ff..9426acede 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -56,7 +56,7 @@ export default { additionalSuccessEventDataHandler, }) { return new Promise((resolve, reject) => { - let cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; + const cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; const payloadAndAnalyticsData = Object.assign({}, payload, { AppName: "FixMyGlass" }); const headers = { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings),